You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "angelo-DNAStack (via GitHub)" <gi...@apache.org> on 2025/04/07 17:56:44 UTC
[PR] Core: Fix a cast that is too narrow [iceberg]
angelo-DNAStack opened a new pull request, #12743:
URL: https://github.com/apache/iceberg/pull/12743
The current cast assumes that the type of the exception matches the type of reconnectExc, in the JdbcClientPool the isConnectionException method can return true for any SQLException with the correct sql status. The exception is always a subclass of the parameterized type though.
Closes #11176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#issuecomment-2793244275
Can you please add a UT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "angelo-DNAStack (via GitHub)" <gi...@apache.org>.
angelo-DNAStack commented on PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#issuecomment-2917511977
Checking in on this PR again, please let me know if there are any additional changes required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2182455900
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -104,18 +173,37 @@ public int successfulAction() {
return actions;
}
- int succeedAfter(int succeedAfterAttempts) {
+ int succeedAfter(List<RuntimeException> exceptions) {
+ int succeedAfterAttempts = exceptions.size();
+ if (retryableFailures == succeedAfterAttempts) {
+ return successfulAction();
+ }
+
+ RuntimeException runtimeException = exceptions.get(retryableFailures);
+ retryableFailures++;
+ throw runtimeException;
+ }
+
+ int succeedAfter(int succeedAfterAttempts, Supplier<RuntimeException> exceptionSupplier) {
if (retryableFailures == succeedAfterAttempts - 1) {
return successfulAction();
}
retryableFailures++;
- throw new RetryableException();
+ throw exceptionSupplier.get();
+ }
+
+ int succeedAfter(int succeedAfterAttempts) {
+ return succeedAfter(succeedAfterAttempts, RetryableException::new);
}
int failWithNonRetryable() {
throw new NonRetryableException();
}
+
+ int failWithNonRetryableImplementationSpecific() {
Review Comment:
I would rename this to `throwCustomNonRetryableException`. Can you also please rename `failWithNonRetryable` to `throwNonRetryableException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "angelo-DNAStack (via GitHub)" <gi...@apache.org>.
angelo-DNAStack commented on PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#issuecomment-3057457636
> @angelo-DNAStack can you please fix formatting by running `./gradlew spotlessApply`?
Done, and apologies (not used to the tool chain)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "angelo-DNAStack (via GitHub)" <gi...@apache.org>.
angelo-DNAStack commented on PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#issuecomment-2825125101
Done, apologies for the delay it's been a busy few weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "angelo-DNAStack (via GitHub)" <gi...@apache.org>.
angelo-DNAStack commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2195741397
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -44,6 +46,29 @@ public void testRetrySucceedsWithinMaxAttempts() throws Exception {
}
}
+ @Test
+ public void testRetryWithImplementationSpecificException() throws Exception {
+ int maxRetries = 5;
+ int succeedAfterAttempts = 3;
+ try (MockClientPoolImpl mockClientPool =
+ new MockClientPoolImpl(2, RetryableException.class, true, maxRetries)) {
+ // initial the client pool with a client, so that we can verify the client is replaced
+ MockClient firstClient = mockClientPool.newClient();
+ mockClientPool.clients().add(firstClient);
+
+ int actions =
+ mockClientPool.run(
+ client ->
+ client.succeedAfter(
+ succeedAfterAttempts, () -> new ImplementationSpecificException(true)));
+ assertThat(actions)
+ .as("There should be exactly one successful action invocation")
+ .isEqualTo(1);
+ assertThat(mockClientPool.reconnectionAttempts()).isEqualTo(succeedAfterAttempts - 1);
+ assertThat(mockClientPool.clients().peekFirst().equals(firstClient)).isFalse();
Review Comment:
Done, also updated the same code in one of the existing tests for consistency's sake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "angelo-DNAStack (via GitHub)" <gi...@apache.org>.
angelo-DNAStack commented on PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#issuecomment-2867181389
Just wanted to check in and see if there was anything further I should do for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2084624210
##########
core/src/main/java/org/apache/iceberg/ClientPoolImpl.java:
##########
@@ -82,7 +82,7 @@ public <R> R run(Action<R, C, E> action, boolean retry) throws E, InterruptedExc
retryAttempts++;
Thread.sleep(CONNECTION_RETRY_WAIT_PERIOD_MS);
} else {
- throw reconnectExc.cast(exc);
+ throw (E) exc;
Review Comment:
all of the newly added tests are passing even without this change here. Ideally we would want to have a test that reproduces the underlying issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2182454505
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -84,6 +141,18 @@ static class RetryableException extends RuntimeException {}
static class NonRetryableException extends RuntimeException {}
+ static class ImplementationSpecificException extends NonRetryableException {
Review Comment:
```suggestion
static class CustomException extends NonRetryableException {
```
this reads shorter and also reduces test method name lengths. Can you please also rename the test methods to reflect that naming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "angelo-DNAStack (via GitHub)" <gi...@apache.org>.
angelo-DNAStack commented on PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#issuecomment-3053644747
> I've left a few comments that would be good to address around testing, but the fix LGTM. @angelo-DNAStack could you please address those so that we could get this into Iceberg 1.10?
Done, and apologies for the delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #12743:
URL: https://github.com/apache/iceberg/pull/12743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#issuecomment-3029789800
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2182461301
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -58,6 +83,25 @@ public void testRetriesExhaustedAndSurfacesFailure() {
}
}
+ @Test
+ public void testNonRetryableExceptionAfterRetryableException() {
Review Comment:
```suggestion
public void nonRetryableExceptionAfterRetryableException() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "angelo-DNAStack (via GitHub)" <gi...@apache.org>.
angelo-DNAStack commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2195742075
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -84,6 +141,18 @@ static class RetryableException extends RuntimeException {}
static class NonRetryableException extends RuntimeException {}
+ static class ImplementationSpecificException extends NonRetryableException {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#issuecomment-2929027882
@amogh-jahagirdar or @pvary could any of you help reviewing this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2084624210
##########
core/src/main/java/org/apache/iceberg/ClientPoolImpl.java:
##########
@@ -82,7 +82,7 @@ public <R> R run(Action<R, C, E> action, boolean retry) throws E, InterruptedExc
retryAttempts++;
Thread.sleep(CONNECTION_RETRY_WAIT_PERIOD_MS);
} else {
- throw reconnectExc.cast(exc);
+ throw (E) exc;
Review Comment:
all of the newly added tests are passing even without this change here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2182446858
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -44,6 +46,29 @@ public void testRetrySucceedsWithinMaxAttempts() throws Exception {
}
}
+ @Test
+ public void testRetryWithImplementationSpecificException() throws Exception {
+ int maxRetries = 5;
+ int succeedAfterAttempts = 3;
+ try (MockClientPoolImpl mockClientPool =
+ new MockClientPoolImpl(2, RetryableException.class, true, maxRetries)) {
+ // initial the client pool with a client, so that we can verify the client is replaced
+ MockClient firstClient = mockClientPool.newClient();
+ mockClientPool.clients().add(firstClient);
+
+ int actions =
+ mockClientPool.run(
+ client ->
+ client.succeedAfter(
+ succeedAfterAttempts, () -> new ImplementationSpecificException(true)));
+ assertThat(actions)
+ .as("There should be exactly one successful action invocation")
+ .isEqualTo(1);
+ assertThat(mockClientPool.reconnectionAttempts()).isEqualTo(succeedAfterAttempts - 1);
+ assertThat(mockClientPool.clients().peekFirst().equals(firstClient)).isFalse();
Review Comment:
this should be `assertThat(mockClientPool.clients()).first().isNotEqualTo(firstClient);` as that is more fluent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2182460247
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -69,6 +113,19 @@ public void testNoRetryingNonRetryableException() {
}
}
+ @Test
+ public void testNoRetryingNonRetryableImplementationSpecificException() {
Review Comment:
maybe name this `customNonRetryableExceptionIsNotRetried` as the name is quite difficult to decipher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2182444810
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -44,6 +46,29 @@ public void testRetrySucceedsWithinMaxAttempts() throws Exception {
}
}
+ @Test
+ public void testRetryWithImplementationSpecificException() throws Exception {
+ int maxRetries = 5;
+ int succeedAfterAttempts = 3;
+ try (MockClientPoolImpl mockClientPool =
+ new MockClientPoolImpl(2, RetryableException.class, true, maxRetries)) {
+ // initial the client pool with a client, so that we can verify the client is replaced
Review Comment:
```suggestion
// initialize the client pool with a client, so that we can verify the client is replaced
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2182454505
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -84,6 +141,18 @@ static class RetryableException extends RuntimeException {}
static class NonRetryableException extends RuntimeException {}
+ static class ImplementationSpecificException extends NonRetryableException {
Review Comment:
```suggestion
static class CustomException extends NonRetryableException {
```
this reads shorter and also reduces test method name lengths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2182462298
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -44,6 +46,29 @@ public void testRetrySucceedsWithinMaxAttempts() throws Exception {
}
}
+ @Test
+ public void testRetryWithImplementationSpecificException() throws Exception {
Review Comment:
```suggestion
public void customExceptionIsRetried() throws Exception {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#issuecomment-3055593039
@angelo-DNAStack can you please fix formatting by running `./gradlew spotlessApply`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix a cast that is too narrow [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra closed pull request #12743: Core: Fix a cast that is too narrow
URL: https://github.com/apache/iceberg/pull/12743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org