[GitHub] [unomi] sergehuber opened a new pull request #102: UNOMI-250 Refactoring services into seperate Java packages

[GitBox <gi...@apache.org>]

sergehuber opened a new pull request #102: UNOMI-250 Refactoring services into seperate Java packages
URL: https://github.com/apache/unomi/pull/102
 
 
   Right now we have a bit of a mess in our services implementation sub-project. All the service implementations are in the package:
   org.apache.unomi.services.services
   I propose that we rename this package to:
   org.apache.unomi.services.impl
   and that each service gets its own sub-package, for example the RulesServiceImpl would be in:
   org.apache.unomi.services.impl.rules
   This would make it much easier to activate/deactivate logging per service implementation, because currently it is tricky to get logging activated properly unless using configuration by class. Having it by package would be a lot better.
   Utility classes such as ThirdPartyService or the clustering event classes would also be moved with the service sub-package they belong to.
   In terms of impact this should minimal, only people activating logs should be notified that the class location has changed.
   
   Signed-off-by: Serge Huber <sh...@apache.org>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services