[jira] [Commented] (STORM-512) KafkaBolt doesn't handle ticks properly

["Niels Basjes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154583#comment-14154583 ] 

Niels Basjes commented on STORM-512:
------------------------------------

I'm willing to prepare a patch.
To make this more usable I think the proper way is to create a method that essentially returns a boolean in response to the question "Is this a tick tuple?".
Now I see two ways of doing this:
# A helper class with a static method. i.e.  TupleHelper.isTickTuple(Tuple t)
# An addition to the "Tuple" interface with a method "isTick".

I thing the latter is nicer because that also makes it very easy for application developers to handle ticks correctly.

In both scenarios the code would essentially be {code}return tuple.getSourceComponent().equals(Constants.SYSTEM_COMPONENT_ID) &&
           tuple.getSourceStreamId().equals(Constants.SYSTEM_TICK_STREAM_ID);{code}

Which solution direction do you guys want?

> KafkaBolt doesn't handle ticks properly
> ---------------------------------------
>
>                 Key: STORM-512
>                 URL: https://issues.apache.org/jira/browse/STORM-512
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Niels Basjes
>
> I found that when using the KafkaBolt the tick tuples are not handled properly. They should be ignored and the reality is that they are not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)