[GitHub] Klaster1 commented on a change in pull request #5844: Ignite 10538

[GitBox <gi...@apache.org>]

Klaster1 commented on a change in pull request #5844: Ignite 10538
URL: https://github.com/apache/ignite/pull/5844#discussion_r249640792
 
 

 ##########
 File path: modules/web-console/frontend/app/components/ignite-chart/controller.js
 ##########
 @@ -81,6 +81,13 @@ export class IgniteChartController {
      * @param {{chartOptions: ng.IChangesObject<import('chart.js').ChartConfiguration>, chartTitle: ng.IChangesObject<string>, chartDataPoint: ng.IChangesObject<IgniteChartDataPoint>, chartHistory: ng.IChangesObject<Array<IgniteChartDataPoint>>}} changes
      */
     async $onChanges(changes) {
+        if (changes.resultDataStatus && ['WAITING', 'ERROR'].includes(changes.resultDataStatus.currentValue) && this.chart) {
+            this.chart.destroy();
 
 Review comment:
   @AlexDel are you sure it's a good idea to kill chart instance when WAITING or ERROR happens? Consider the following case: an error happens during chart data poll request and some data points drop out; what's the current behavior and the change will affect it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services