You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/14 04:07:20 UTC
[GitHub] [druid] tarunparackal opened a new pull request #10394: Look flattextparser
tarunparackal opened a new pull request #10394:
URL: https://github.com/apache/druid/pull/10394
Fixes #10393.
### Description
While adding a global cached lookup with has header and skip header for csv file gives the following error.
java.lang.UnsupportedOperationException: hasHeaderRow or maxSkipHeaderRows is not supported. Please check the indexTask supports these options.
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
modified UriExtractionNamespace class . After creating the CSVParser startFileFromBeginning method need to be called . This method may or may not get called at the start of reading of every file depending on the type of IndexTasks. However in this scenario this is mandator for initializing the parser.
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
#### Fixed the bug
additionally while skipping the empty rows incase the skipHeaderRows , was throwing null pointer exception . Add a null check to skip.
<hr>
This PR has:
- [x] been self-reviewed.
<hr>
##### Key changed/added classes in this PR
* `UriExtractionNamespace`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tarunparackal closed pull request #10394: Look flattextparser
Posted by GitBox <gi...@apache.org>.
tarunparackal closed pull request #10394:
URL: https://github.com/apache/druid/pull/10394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tarunparackal commented on pull request #10394: Look flattextparser
Posted by GitBox <gi...@apache.org>.
tarunparackal commented on pull request #10394:
URL: https://github.com/apache/druid/pull/10394#issuecomment-692845975
Hi ,
I messed up the earlier PR and raised another PR . Could you please
review it .
https://github.com/apache/druid/pull/10398
On Tue, Sep 15, 2020 at 3:27 PM Tijo Thomas <no...@github.com>
wrote:
> *@tijoparacka* approved this pull request.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/druid/pull/10394#pullrequestreview-488520670>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AQIUBBDACXAMAXS6XX7NYP3SF43BPANCNFSM4RLDFNSQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org