You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/02 09:25:24 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #4639: cks: use HttpsURLConnection for checking api server
shwstppr opened a new pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639
### Description
Frobable fix for #4146 , #4637
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771882272
> Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2637
If I want to test this, how do I do so? You will have to give instructions to obtain/install the packages in my environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr edited a comment on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-785754851
@weizhouapache possible for you to test this and see if this fixes curl -L issue you highlighted in #4146?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773014094
Tried to do a quick deployment with the new packages --
It failed again... Below are relevant lines from Management Server log.
Are there any additional log files I can look into or additional checks I can do? If yes, please advise..
`2021-02-03 17:44:42,964 INFO [c.c.k.c.u.KubernetesClusterUtil] (API-Job-Executor-1:ctx-0078ab8c job-12195 ctx-65cc2bf7) (logid:4ac48e69) Waiting for Kubernetes cluster : k8test master node VMs to be accessible
2021-02-03 17:44:52,965 ERROR [c.c.k.c.a.KubernetesClusterActionWorker] (API-Job-Executor-1:ctx-0078ab8c job-12195 ctx-65cc2bf7) (logid:4ac48e69) Failed to setup Kubernetes cluster : k8test3 in usable state as unable to access master node VMs of the cluster
2021-02-03 17:44:59,052 INFO [c.c.k.c.a.KubernetesClusterActionWorker] (API-Job-Executor-1:ctx-0078ab8c job-12195 ctx-65cc2bf7) (logid:4ac48e69) Detached Kubernetes binaries from VM : k8test3-master in the Kubernetes cluster : k8test3
2021-02-03 17:45:02,995 INFO [c.c.k.c.a.KubernetesClusterActionWorker] (API-Job-Executor-1:ctx-0078ab8c job-12195 ctx-65cc2bf7) (logid:4ac48e69) Detached Kubernetes binaries from VM : k8test3-node-1 in the Kubernetes cluster : k8test3
2021-02-03 17:45:02,998 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-1:ctx-0078ab8c job-12195) (logid:4ac48e69) Complete async job-12195, jobStatus: FAILED, resultCode: 530, result: org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":"530","errortext":"Failed to setup Kubernetes cluster : k8test3 in usable state as unable to access master node VMs of the cluster"}
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771541279
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773507040
<b>Trillian test result (tid-3486)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33562 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4639-t3486-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-786504690
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-772278247
> > Packaging result: heavy_check_markcentos7 heavy_multiplication_xcentos8 heavy_check_markdebian. JID-2637
>
> If I want to test this, how do I do so? You will have to give instructions to obtain/install the packages in my environment.
@nxsbi do you want to test the fix in 4.15 or 4.14 or it doesn't matter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773432881
@shwstppr
Management server is able to curl -k the public IP of the VR. But it throws error if using just curl (without -k)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-785754851
@weizhouapache possible for you to test this and see if this fixes curl -L issue you highlighted in #4146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771495365
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-783277222
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773483059
@shwstppr That was it!! The Management Server was not able to reach the Virtual router on port 2222 via ssh.
Turned out, the main Hardware firewall (outside of Cloudstack) does not allow inter VLAN communication as a default. That is what was blocking it. I added rule to allow the communication, and was able to create a cluster just now!
Thanks so much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771540821
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773498653
Is there any option for Verbose logging which would have logged the ipAddress and Port that were used in the? That would have made it easier to determine the problem of not being able to connect to VR IP on port 2222... Just a thought.
`
socket.connect(new InetSocketAddress(ipAddress, port), 10000)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771594798
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773455467
@nxsbi service is not being able to connect to SSH with VR public IP and forwarded port (must be 2222), failing here
https://github.com/apache/cloudstack/blob/280c13a4bb103dd748ec304bfe0714a148c24602/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java#L247-L253
Are you able to manually do SSH from the management server?
`ssh -i /root/.ssh/id_rsa.cloud -p 2222 core@public_ip_of_network`
Firewall and port forwarding rules must be automatically provisioned by the service in the cluster's network.
Service uses SSH over 2222 to 2222+n ports. SSH on worker nodes are done only during k8s version upgrade
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-774011774
@nxsbi there is no way to make logging verbose for that section of code. Maybe something to improve in next release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773507040
<b>Trillian test result (tid-3486)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33562 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4639-t3486-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771495365
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-786642208
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-772401449
@nxsbi please find build packages here, http://download.cloudstack.org/testing/is-4637/
They are built against current 4.15 branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773117724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773086560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-785753940
@
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-783277222
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771495991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-772013278
<b>Trillian test result (tid-3471)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38279 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4639-t3471-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3612.86 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 112.05 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771513285
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-784993476
@shwstppr is this good to go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771495991
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-786642777
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773117724
@shwstppr
> cat /var/log/cloudstack/management/management-server.log | grep -i 4ac48e69
Here it is. I have cleansed the log for IP, passwords, Keys etc. so you may see XXXXX.. For IP I only changed the management LAN IPs and external IPs. You will see them as 192.168.100.XXX where XXX is the actual last bit of correct IP or as 172.100.100.100
[mgmt-4ac48e69cleansed.log](https://github.com/apache/cloudstack/files/5924132/mgmt-4ac48e69cleansed.log)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773024716
@shwstppr - Tested inside Master node, with curl just to see if the certificate issue persists -- Yes it does
Note this is with the new package build you provided
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-786533830
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2839
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#discussion_r568498231
##########
File path: plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java
##########
@@ -218,7 +221,10 @@ public static boolean isKubernetesClusterServerRunning(final KubernetesCluster k
boolean k8sApiServerSetup = false;
while (System.currentTimeMillis() < timeoutTime) {
try {
- String versionOutput = IOUtils.toString(new URL(String.format("https://%s:%d/version", ipAddress, port)), StringUtils.getPreferredCharset());
+ URL url = new URL(String.format("https://%s:%d/version", ipAddress, port));
+ HttpsURLConnection con = (HttpsURLConnection)url.openConnection();
Review comment:
should we configure it to ignore ssl cert validation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-772352406
okay @nxsbi, I'll share the 4.15 packages with the fix soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771595445
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi edited a comment on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi edited a comment on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773014094
Tried to do a quick deployment with the new packages --
It failed again... Below are relevant lines from Management Server log.
Are there any additional log files I can look into or additional checks I can do? If yes, please advise..
`2021-02-03 17:44:42,964 INFO [c.c.k.c.u.KubernetesClusterUtil] (API-Job-Executor-1:ctx-0078ab8c job-12195 ctx-65cc2bf7) (logid:4ac48e69) Waiting for Kubernetes cluster : k8test master node VMs to be accessible
2021-02-03 17:44:52,965 ERROR [c.c.k.c.a.KubernetesClusterActionWorker] (API-Job-Executor-1:ctx-0078ab8c job-12195 ctx-65cc2bf7) (logid:4ac48e69) Failed to setup Kubernetes cluster : k8test3 in usable state as unable to access master node VMs of the cluster
2021-02-03 17:44:59,052 INFO [c.c.k.c.a.KubernetesClusterActionWorker] (API-Job-Executor-1:ctx-0078ab8c job-12195 ctx-65cc2bf7) (logid:4ac48e69) Detached Kubernetes binaries from VM : k8test3-master in the Kubernetes cluster : k8test3
2021-02-03 17:45:02,995 INFO [c.c.k.c.a.KubernetesClusterActionWorker] (API-Job-Executor-1:ctx-0078ab8c job-12195 ctx-65cc2bf7) (logid:4ac48e69) Detached Kubernetes binaries from VM : k8test3-node-1 in the Kubernetes cluster : k8test3
2021-02-03 17:45:02,998 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-1:ctx-0078ab8c job-12195) (logid:4ac48e69) Complete async job-12195, jobStatus: FAILED, resultCode: 530, result: org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":"530","errortext":"Failed to setup Kubernetes cluster : k8test3 in usable state as unable to access master node VMs of the cluster"}
`
NOTE -- I can login into the Master node via command line with SSH Key, and I can see that the cluster is actually functional, however it does nto report so in the UI (I ssh using the user Core, and then sudo su to root). IF I run the commands as core, I get access denied, as all files are owned by root with user/group as no access.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-783997336
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-786486981
Packaging result: ✖centos7 ✖centos8 ✔debian. JID-2833
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-784115398
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-786456936
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-786504330
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#discussion_r568498231
##########
File path: plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java
##########
@@ -218,7 +221,10 @@ public static boolean isKubernetesClusterServerRunning(final KubernetesCluster k
boolean k8sApiServerSetup = false;
while (System.currentTimeMillis() < timeoutTime) {
try {
- String versionOutput = IOUtils.toString(new URL(String.format("https://%s:%d/version", ipAddress, port)), StringUtils.getPreferredCharset());
+ URL url = new URL(String.format("https://%s:%d/version", ipAddress, port));
+ HttpsURLConnection con = (HttpsURLConnection)url.openConnection();
Review comment:
should we configure it to ignore ssl cert validation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-772279915
> > > Packaging result: heavy_check_markcentos7 heavy_multiplication_xcentos8 heavy_check_markdebian. JID-2637
> >
> >
> > If I want to test this, how do I do so? You will have to give instructions to obtain/install the packages in my environment.
>
> @nxsbi do you want to test the fix in 4.15 or 4.14 or it doesn't matter?
@shwstppr I want to test in 4.15.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771610118
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-786954683
<b>Trillian test result (tid-3625)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36155 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4639-t3625-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_nic | `Error` | 49.50 | test_nic.py
test_01_migrate_VM_and_root_volume | `Error` | 60.96 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 50.01 | test_vm_life_cycle.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771540821
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-772827851
<b>Trillian test result (tid-3482)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40661 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4639-t3482-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 3605.90 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 3622.01 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 107.84 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#discussion_r581042829
##########
File path: plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java
##########
@@ -218,7 +221,10 @@ public static boolean isKubernetesClusterServerRunning(final KubernetesCluster k
boolean k8sApiServerSetup = false;
while (System.currentTimeMillis() < timeoutTime) {
try {
- String versionOutput = IOUtils.toString(new URL(String.format("https://%s:%d/version", ipAddress, port)), StringUtils.getPreferredCharset());
+ URL url = new URL(String.format("https://%s:%d/version", ipAddress, port));
+ HttpsURLConnection con = (HttpsURLConnection)url.openConnection();
Review comment:
and get more static analysis reports as issues?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-786456344
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-771882272
> Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2637
If I want to test this, how do I do so? You will have to give instructions to obtain/install the packages in my environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-783251280
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773086560
@nxsbi can you please share output of,
`cat /var/log/cloudstack/management/management-server.log | grep -i 4ac48e69`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-783251780
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org