You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by justinleet <gi...@git.apache.org> on 2018/06/08 22:04:28 UTC
[GitHub] metron pull request #1058: METRON-1612: Fix website download links
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/1058
METRON-1612: Fix website download links
## Contributor Comments
Couple things getting fixed related to the download links that came up as a result of a couple things during the release.
* Correct the https link for the keys (per https://www.apache.org/dev/release-distribution#download-links). Make sure the links use this correctly.
* Remove MD5. Per policy, we don't provide MD5. The release doesn't contain it, so the link was dead.
* Rename SHA to SHA1. Per policy, we don't provide a plain SHA file. Rename to SHA1
* Add SHA256. We have it, might as well provide the link to it.
See instructions for testing PR at https://cwiki.apache.org/confluence/display/METRON/Website+PR+Merge
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/metron downloadLinks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1058.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1058
----
commit 9fba8fa59bb1f7274c4fc0014a88289b0120bce6
Author: justinjleet <ju...@...>
Date: 2018-06-08T21:55:19Z
Updating download links to remove broken md5 link, rename sha, and add sha256
----
---
[GitHub] metron issue #1058: METRON-1612: Fix website download links
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1058
+1 by inspection, looks good.
---
[GitHub] metron issue #1058: METRON-1612: Fix website download links
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1058
Merged, and live on the site.
---
[GitHub] metron pull request #1058: METRON-1612: Fix website download links
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet closed the pull request at:
https://github.com/apache/metron/pull/1058
---