You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/26 22:19:08 UTC

[GitHub] eric-haibin-lin commented on a change in pull request #11357: [MXNET-331] Single machine All Reduce Topology-aware Communication

eric-haibin-lin commented on a change in pull request #11357: [MXNET-331] Single machine All Reduce Topology-aware Communication
URL: https://github.com/apache/incubator-mxnet/pull/11357#discussion_r198315324
 
 

 ##########
 File path: src/kvstore/kvstore_local.h
 ##########
 @@ -56,7 +57,12 @@ class KVStoreLocal : public KVStore {
    */
   explicit KVStoreLocal(bool use_device_comm) : KVStore() {
     if (use_device_comm) {
-      comm_ = new CommDevice();
+      bool tree = dmlc::GetEnv("MXNET_KVSTORE_USETREE", 0);
 
 Review comment:
   Can we also have python gpu kvstore test with MXNET_KVSTORE_USETREE set? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services