You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Jarcec <ja...@jarcec.net> on 2011/10/30 18:52:09 UTC

Review Request: SQOOP-378: Migrate manager package to new name space

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2618/
-----------------------------------------------------------

Review request for Sqoop and Bilung Lee.


Summary
-------

I've migrated manager package.


This addresses bug SQOOP-378.
    https://issues.apache.org/jira/browse/SQOOP-378


Diffs
-----

  /src/java/com/cloudera/sqoop/manager/CatalogQueryManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/ConnManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/Db2Manager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/DefaultManagerFactory.java 1195125 
  /src/java/com/cloudera/sqoop/manager/DirectMySQLManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/DirectPostgresqlManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/ExportJobContext.java 1195125 
  /src/java/com/cloudera/sqoop/manager/GenericJdbcManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/HsqldbManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/ImportJobContext.java 1195125 
  /src/java/com/cloudera/sqoop/manager/InformationSchemaManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/ManagerFactory.java 1195125 
  /src/java/com/cloudera/sqoop/manager/MySQLManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/MySQLUtils.java 1195125 
  /src/java/com/cloudera/sqoop/manager/OracleManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/SQLServerManager.java 1195125 
  /src/java/com/cloudera/sqoop/manager/SqlManager.java 1195125 
  /src/java/org/apache/sqoop/manager/CatalogQueryManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/ConnManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/Db2Manager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/DefaultManagerFactory.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/DirectMySQLManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/ExportJobContext.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/GenericJdbcManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/HsqldbManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/ImportJobContext.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/InformationSchemaManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/ManagerFactory.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/MySQLManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/MySQLUtils.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/OracleManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/PostgresqlManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/SQLServerManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/manager/SqlManager.java PRE-CREATION 

Diff: https://reviews.apache.org/r/2618/diff


Testing
-------


Thanks,

Jarek


Re: Review Request: SQOOP-378: Migrate manager package to new name space

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2618/#review2999
-----------------------------------------------------------

Ship it!


Thanks for the patch!

- Bilung


On 2011-10-30 17:52:09, Jarek Jarcec wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2618/
> -----------------------------------------------------------
> 
> (Updated 2011-10-30 17:52:09)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Summary
> -------
> 
> I've migrated manager package.
> 
> 
> This addresses bug SQOOP-378.
>     https://issues.apache.org/jira/browse/SQOOP-378
> 
> 
> Diffs
> -----
> 
>   /src/java/com/cloudera/sqoop/manager/CatalogQueryManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/ConnManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/Db2Manager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/DefaultManagerFactory.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/DirectMySQLManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/DirectPostgresqlManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/ExportJobContext.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/GenericJdbcManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/HsqldbManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/ImportJobContext.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/InformationSchemaManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/ManagerFactory.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/MySQLManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/MySQLUtils.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/OracleManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/SQLServerManager.java 1195125 
>   /src/java/com/cloudera/sqoop/manager/SqlManager.java 1195125 
>   /src/java/org/apache/sqoop/manager/CatalogQueryManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/ConnManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/Db2Manager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/DefaultManagerFactory.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/DirectMySQLManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/ExportJobContext.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/GenericJdbcManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/HsqldbManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/ImportJobContext.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/InformationSchemaManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/ManagerFactory.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/MySQLManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/MySQLUtils.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/OracleManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/PostgresqlManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/SQLServerManager.java PRE-CREATION 
>   /src/java/org/apache/sqoop/manager/SqlManager.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/2618/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek
> 
>