You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xinrong-meng (via GitHub)" <gi...@apache.org> on 2023/01/25 11:14:17 UTC
[GitHub] [spark] xinrong-meng commented on a diff in pull request #39739: [SPARK-42126][PYTHON][CONNECT] Accept return type in DDL strings for Python Scalar UDFs in Spark Connect
xinrong-meng commented on code in PR #39739:
URL: https://github.com/apache/spark/pull/39739#discussion_r1086507541
##########
python/pyspark/sql/connect/client.py:
##########
@@ -369,6 +370,22 @@ def register_udf(
) -> str:
Review Comment:
Since `register_udf` will be removed soon, I didn't make the workaround as a utility that can be reused or create a designated test file for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org