You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/03 22:17:36 UTC
[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
avijayanhwx opened a new pull request #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
URL: https://github.com/apache/hadoop-ozone/pull/631
…ting updated.
## What changes were proposed in this pull request?
Ozone Manager creates 2 instances of OzoneManagerDoubleMetrics, and the way Hadoop metrics2 works, the second one overwrites the first. In our case, it is the first instance that is on the Ratis write path. Fixed this issue by making sure there is only instance of OzoneManagerDoubleMetrics.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3119
## How was this patch tested?
Manually tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
URL: https://github.com/apache/hadoop-ozone/pull/631#issuecomment-594972531
There is already a Jira I have opened for the same test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
URL: https://github.com/apache/hadoop-ozone/pull/631
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
URL: https://github.com/apache/hadoop-ozone/pull/631#issuecomment-594945360
Unit test failure TestSCMPipelineBytesWrittenMetrics is not related to this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 removed a comment on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
Posted by GitBox <gi...@apache.org>.
bharatviswa504 removed a comment on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
URL: https://github.com/apache/hadoop-ozone/pull/631#issuecomment-594893169
Can we avoid double instantiation of doublebuffer which is not required in OM, that will resolve this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
URL: https://github.com/apache/hadoop-ozone/pull/631#issuecomment-594893169
Can we avoid double instantiation of doublebuffer which is not required in OM, that will resolve this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #631: HDDS-3119. When ratis is enabled in OM, double Buffer metrics not get…
URL: https://github.com/apache/hadoop-ozone/pull/631#issuecomment-595074581
> There is already a Jira I have opened for the same test.
Me too. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org