[jira] [Commented] (RANGER-1725) It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

["Madhan Neethiraj (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RANGER-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141124#comment-16141124 ] 

Madhan Neethiraj commented on RANGER-1725:
------------------------------------------

[~peng.jianhua] - this fix effectively doesn't change any behavior. Can you please add details on what use case triggered this JIRA and patch?

> It is incorrect to judge whether you need to create a RangerServiceDef object for a given service
> -------------------------------------------------------------------------------------------------
>
>                 Key: RANGER-1725
>                 URL: https://issues.apache.org/jira/browse/RANGER-1725
>             Project: Ranger
>          Issue Type: Bug
>          Components: Ranger
>            Reporter: peng.jianhua
>            Assignee: peng.jianhua
>              Labels: patch
>             Fix For: 1.0.0
>
>         Attachments: 0001-RANGER-1725-It-is-incorrect-to-judge-whether-you-nee.patch
>
>
> It is incorrect to judge whether you need to create a RangerServiceDef object for a given service.
> The current judgment condition is in the org.apache.ranger.plugin.store.EmbeddedServiceDefsUtil#getOrCreateServiceDef, as follows
> {code:java}
> boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || supportedServiceDefs.contains(serviceDefName));
> {code}
> It means When the supportedServiceDefs is empty, the RangerServiceDef object for the specified service will be created, but I think this judge is incorrect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)