You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by Garren Smith <ga...@apache.org> on 2014/01/20 16:44:15 UTC
[REVIEW] refactoring api.js to framework
Hi All,
For Fauxton, I've been working on separating out the JS framework we have built on top of Backbone from Fauxton the web UI for CouchDB. Its sitting in the branch fauxton-file-reorder. See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder). Could anyone interested review the changes I've made. The majority of the work was just moving things around and making the File layout and API more logical. So it is a large review. Two ways to test is to run grunt test and also to try out the Couchdb Fauxton.
Cheers
Garren
Re: [REVIEW] refactoring api.js to framework
Posted by Garren Smith <ga...@apache.org>.
Ok here is a PR https://github.com/apache/couchdb/pull/136
On 20 Jan 2014, at 6:04 PM, Alexander Shorin <kx...@gmail.com> wrote:
> On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith <ga...@apache.org> wrote:
>> See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder)
>
> This one much better:
> https://github.com/apache/couchdb/compare/fauxton-file-reorder (;
>
> May be send github PR to let people leave comments right to the code
> lines they'd like to discuss?
>
> --
> ,,,^..^,,,
Re: [REVIEW] refactoring api.js to framework
Posted by Garren Smith <ga...@apache.org>.
On 20 Jan 2014, at 6:06 PM, Alexander Shorin <kx...@gmail.com> wrote:
> On Mon, Jan 20, 2014 at 8:04 PM, Alexander Shorin <kx...@gmail.com> wrote:
>> On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith <ga...@apache.org> wrote:
>>> See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder)
>>
>> This one much better:
>> https://github.com/apache/couchdb/compare/fauxton-file-reorder (;
>>
>> May be send github PR to let people leave comments right to the code
>> lines they'd like to discuss?
>
> For instance, I couldn't reference router.js line 97 to say: what is the "aa"?
>
> setModuleRoutes: function() {
> _.each(LoadAddons.addons, function(module) {
> + console.log('aa', module);
> if (module){
> module.initialize();
> // This is pure routes the addon provides
Thats some debugging code that slipped through. Thanks for letting me know.
>
> --
> ,,,^..^,,,
Re: [REVIEW] refactoring api.js to framework
Posted by Alexander Shorin <kx...@gmail.com>.
On Mon, Jan 20, 2014 at 8:04 PM, Alexander Shorin <kx...@gmail.com> wrote:
> On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith <ga...@apache.org> wrote:
>> See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder)
>
> This one much better:
> https://github.com/apache/couchdb/compare/fauxton-file-reorder (;
>
> May be send github PR to let people leave comments right to the code
> lines they'd like to discuss?
For instance, I couldn't reference router.js line 97 to say: what is the "aa"?
setModuleRoutes: function() {
_.each(LoadAddons.addons, function(module) {
+ console.log('aa', module);
if (module){
module.initialize();
// This is pure routes the addon provides
--
,,,^..^,,,
Re: [REVIEW] refactoring api.js to framework
Posted by Alexander Shorin <kx...@gmail.com>.
On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith <ga...@apache.org> wrote:
> See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder)
This one much better:
https://github.com/apache/couchdb/compare/fauxton-file-reorder (;
May be send github PR to let people leave comments right to the code
lines they'd like to discuss?
--
,,,^..^,,,
Re: [REVIEW] refactoring api.js to framework
Posted by Garren Smith <ga...@apache.org>.
Hi Adam,
Sorry forgot to add jira ticket link. Here it is https://issues.apache.org/jira/browse/COUCHDB-2033
On 20 Jan 2014, at 5:57 PM, Adam Kocoloski <ko...@apache.org> wrote:
> Where do you want comments? Is there a JIRA for the refactor?
>
> Adam
>
> On Jan 20, 2014, at 10:44 AM, Garren Smith <ga...@apache.org> wrote:
>
>> Hi All,
>>
>> For Fauxton, I've been working on separating out the JS framework we have built on top of Backbone from Fauxton the web UI for CouchDB. Its sitting in the branch fauxton-file-reorder. See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder). Could anyone interested review the changes I've made. The majority of the work was just moving things around and making the File layout and API more logical. So it is a large review. Two ways to test is to run grunt test and also to try out the Couchdb Fauxton.
>>
>> Cheers
>> Garren
>>
>
Re: [REVIEW] refactoring api.js to framework
Posted by Simon Metson <si...@cloudant.com>.
Jira is COUCHDB-2033
On Monday, 20 January 2014 at 15:57, Adam Kocoloski wrote:
> Where do you want comments? Is there a JIRA for the refactor?
>
> Adam
>
> On Jan 20, 2014, at 10:44 AM, Garren Smith <ga...@apache.org> wrote:
>
> > Hi All,
> >
> > For Fauxton, I've been working on separating out the JS framework we have built on top of Backbone from Fauxton the web UI for CouchDB. Its sitting in the branch fauxton-file-reorder. See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder). Could anyone interested review the changes I've made. The majority of the work was just moving things around and making the File layout and API more logical. So it is a large review. Two ways to test is to run grunt test and also to try out the Couchdb Fauxton.
> >
> > Cheers
> > Garren
> >
>
>
>
Re: [REVIEW] refactoring api.js to framework
Posted by Adam Kocoloski <ko...@apache.org>.
Where do you want comments? Is there a JIRA for the refactor?
Adam
On Jan 20, 2014, at 10:44 AM, Garren Smith <ga...@apache.org> wrote:
> Hi All,
>
> For Fauxton, I've been working on separating out the JS framework we have built on top of Backbone from Fauxton the web UI for CouchDB. Its sitting in the branch fauxton-file-reorder. See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder). Could anyone interested review the changes I've made. The majority of the work was just moving things around and making the File layout and API more logical. So it is a large review. Two ways to test is to run grunt test and also to try out the Couchdb Fauxton.
>
> Cheers
> Garren
>