You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <ja...@takari.io> on 2014/12/12 22:54:39 UTC
[VOTE] Maven 3.2.4 Release
Hi,
Time to release Maven 3.2.4!
Here is a link to Jira with 20 issues resolved:
https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
Staging repo:
https://repository.apache.org/content/repositories/maven-1102/
The distributable binaries and sources for testing can be found here:
https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
Specifically the zip, tarball, and source archives can be found here:
https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
Source release checksum(s):
apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
Staging site:
http://takari.io/maven-3.2.4/
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
Thanks,
The Maven Team
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Jason van Zyl <ja...@takari.io>.
+1
Analyzing release validity...
stagingUrl: https://repository.apache.org/content/repositories/maven-1102
groupId: org.apache.maven
artifactId: apache-maven
version: 3.2.4
Source ZIP url exists.
https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
Source ZIP SHA1 url exists.
https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip.sha1
Binary ZIP url exists.
https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
Binary ZIP SHA1 url exists.
https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip.sha1
Calculated SHA1 of source ZIP matches published SHA1 of source ZIP.
db5fb9feda693f05fe7effaf096d6cd4dd5eff44
Calculated SHA1 of binary ZIP matches published SHA1 of binary ZIP.
d336f874bd29e7f39495217c887ee552b6636918
LICENSE file is present in the source distribution.
NOTICE file is present in the source distribution.
LICENSE file is present in the binary distribution.
NOTICE file is present in the binary distribution.
Git revision of release as determined from maven-core-3.2.4.jar:org/apache/maven/messages/build.properties(buildNumber):
ed0e6acb016d0863e6421932820cf269b618dc3f
All files in source distribution have been found in the release revision (taking into account acceptable exclusions).
On Dec 12, 2014, at 4:54 PM, Jason van Zyl <ja...@takari.io> wrote:
> Hi,
>
> Time to release Maven 3.2.4!
>
> Here is a link to Jira with 20 issues resolved:
> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1102/
>
> The distributable binaries and sources for testing can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>
> Specifically the zip, tarball, and source archives can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>
> Source release checksum(s):
> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>
> Staging site:
> http://takari.io/maven-3.2.4/
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Thanks,
>
> The Maven Team
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
Selfish deeds are the shortest path to self destruction.
-- The Seven Samuari, Akira Kurosawa
Re: [VOTE] Maven 3.2.4 Release
Posted by Hervé BOUTEMY <he...@free.fr>.
I finally had a second deeper look at the issue, and chose to close it as fixed
in Maven 3.2.4: details in the comments
then there is no problem now to re-cut the release
thanks
Hervé
Le samedi 13 décembre 2014 21:14:08 Hervé BOUTEMY a écrit :
> we need to choose what we do with http://jira.codehaus.org/browse/MNG-5724
>
> it is done, since we have Wagon 2.8, but it seems there is a debate if "we
> need to remove commons-io, commons-lang, and jsoup jars, and possibly wagon-
> http-shared from maven distribution"
>
> I don't have precise opinion about this: since plexus-classworlds protects
> plugins from these components, the issue is only about size of the
> distribution, or extensions?
>
> any opinion?
>
> Regards,
>
> Hervé
>
> Le samedi 13 décembre 2014 14:55:52 Jason van Zyl a écrit :
> > The fixes have been made, I'll recut the release.
> >
> > On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
> > > I've already reintroduced DefaultJavaToolChain and Tycho is happy now
> > > [1].
> > >
> > > Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to the
> > > best of my knowledge, is not available from any other API, is not
> > > available through ToolchainManager.
> > >
> > > I don't believe Tycho references JavaToolChain interface. As a side
> > > note, in the future we should avoid case-only renames like
> > > JavaToolChain->JavaToolchain, these cause problems on case-insensitive
> > > filesystems, like the ones used by Windows and OSX.
> > >
> > > We don't distinguish between public and internal classes in Maven, at
> > > least not generally. There are few classes that are explicitly marked as
> > > @provisional, like ArtifactDescriptorReaderDelegate for example, but
> > > this is not enforced and majority of classes are not marked in any way.
> > > I agree we need to have a mechanism to distinguish between public and
> > > internal classes and I have few ideas to do this, but I don't think we
> > > can do this retroactively. We have to keep most/all existing classes and
> > > treat them as public API, unfortunately. Maybe mark them as deprecated
> > > when we know we will likely change them in the future, but any real
> > > change has to wait Maven 4, and I am not sure we'll be able to afford
> > > massive breakage even then.
> > >
> > > [1]
> > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d5
> > > 6
> > > ab0facd36751ccee722db6a2006f50
> > >
> > > --
> > > Regards,
> > > Igor
> > >
> > > On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
> > >> ok, I had a look at Tycho sources:
> > >> this is something introduced recently (10/10/2014): IIUC, Tycho 0.22.0
> > >> was
> > >> released since then
> > >>
> > >> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a rewrite
> > >> of a part of maven-toochains-plugin, depending on
> > >> ToolchainManagerPrivate which is not part of public API
> > >> IIUC, the intent was to get the configured toolchain: since then, I
> > >> wrote
> > >> a
> > >> little doc for that [1] to show how to use ToolchainManager to do
> > >> exactly
> > >> that using normal Maven API
> > >>
> > >> Notice this won't fix everything, since:
> > >> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
> > >> ToolChain) 2. the interface doesn't offer expected getJavaHome() API
> > >>
> > >>
> > >> Then you'll need to cast to DefaultJavaToolChain, which will need to be
> > >> added back to maven-core: I'll do it immediately.
> > >>
> > >> I don't know the Tycho community, but using ToolchainManager would IMHO
> > >> be
> > >> more future-proof than writing ToolchainProvider
> > >>
> > >> Regards,
> > >>
> > >> Hervé
> > >>
> > >>
> > >> [1]
> > >> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/cust
> > >> o
> > >> m.html>>
> > >>
> > >> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
> > >>> DefaultJavaToolChain? you mean the implementation?
> > >>>
> > >>> Can you give me pointers to the Tycho sources that use this API?
> > >>> (that's clearly not expected)
> > >>>
> > >>> I'm in favor of introducing deprecated DefaultJavaToolChain
> > >>> that extends the new implementation, which is easy to do: just need to
> > >>> understand how it is used in Tycho, since the class is supposed to be
> > >>> used
> > >>> by JavaToolchainFactory (on only this one).
> > >>>
> > >>> Regards,
> > >>>
> > >>> Hervé
> > >>>
> > >>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> > >>>> Unfortunately, I have to take this back. The changes to toolchain
> > >>>> broke Tycho and, short of using reflection, I don't see how
> > >>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
> > >>>>
> > >>>> For better or worse,
> > >>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> > >>>> Maven API since 2.x and I don't think we can just remove the class.
> > >>>>
> > >>>> I see two ways to fix this. Either we rename the classes back, which
> > >>>> is
> > >>>> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
> > >>>> that extends the new implementation.
> > >>>>
> > >>>> Here is my -1 for releasing 3.2.4 in its current state.
> > >>>>
> > >>>> --
> > >>>> Regards,
> > >>>> Igor
> > >>>>
> > >>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> > >>>>> +1
> > >>>>>
> > >>>>> --
> > >>>>> Regards,
> > >>>>> Igor
> > >>>>>
> > >>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> > >>>>>> Hi,
> > >>>>>>
> > >>>>>> Time to release Maven 3.2.4!
> > >>>>>>
> > >>>>>> Here is a link to Jira with 20 issues resolved:
> > >>>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&v
> > >>>>>> er
> > >>>>>> si
> > >>>>>> on
> > >>>>>> =20574
> > >>>>>>
> > >>>>>>
> > >>>>>> Staging repo:
> > >>>>>> https://repository.apache.org/content/repositories/maven-1102/
> > >>>>>>
> > >>>>>> The distributable binaries and sources for testing can be found
> > >>>>>> here:
> > >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/a
> > >>>>>> pa
> > >>>>>> ch
> > >>>>>> e/
> > >>>>>> maven/apache-maven/3.2.4/
> > >>>>>>
> > >>>>>>
> > >>>>>> Specifically the zip, tarball, and source archives can be found
> > >>>>>> here:
> > >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/a
> > >>>>>> pa
> > >>>>>> ch
> > >>>>>> e/
> > >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> > >>>>>>
> > >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/a
> > >>>>>> pa
> > >>>>>> ch
> > >>>>>> e/
> > >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> > >>>>>>
> > >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/a
> > >>>>>> pa
> > >>>>>> ch
> > >>>>>> e/
> > >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> > >>>>>>
> > >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/a
> > >>>>>> pa
> > >>>>>> ch
> > >>>>>> e/
> > >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> > >>>>>>
> > >>>>>>
> > >>>>>> Source release checksum(s):
> > >>>>>> apache-maven-3.2.4-src.zip sha1:
> > >>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> > >>>>>>
> > >>>>>> Staging site:
> > >>>>>> http://takari.io/maven-3.2.4/
> > >>>>>>
> > >>>>>> Vote open for 72 hours.
> > >>>>>>
> > >>>>>> [ ] +1
> > >>>>>> [ ] +0
> > >>>>>> [ ] -1
> > >>>>>>
> > >>>>>> Thanks,
> > >>>>>>
> > >>>>>> The Maven Team
> > >>>>>> -------------------------------------------------------------------
> > >>>>>> --
> > >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>
> > >>>>> --------------------------------------------------------------------
> > >>>>> -
> > >>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>
> > >>>> ---------------------------------------------------------------------
> > >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>
> > >>> ---------------------------------------------------------------------
> > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> >
> > Thanks,
> >
> > Jason
> >
> > ----------------------------------------------------------
> > Jason van Zyl
> > Founder, Apache Maven
> > http://twitter.com/jvanzyl
> > http://twitter.com/takari_io
> > ---------------------------------------------------------
> >
> > The modern conservative is engaged in one of man's oldest exercises in
> > moral philosophy; that is, the search for a superior moral justification
> > for selfishness.
> >
> > -- John Kenneth Galbraith
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Hervé BOUTEMY <he...@free.fr>.
we need to choose what we do with http://jira.codehaus.org/browse/MNG-5724
it is done, since we have Wagon 2.8, but it seems there is a debate if "we
need to remove commons-io, commons-lang, and jsoup jars, and possibly wagon-
http-shared from maven distribution"
I don't have precise opinion about this: since plexus-classworlds protects
plugins from these components, the issue is only about size of the
distribution, or extensions?
any opinion?
Regards,
Hervé
Le samedi 13 décembre 2014 14:55:52 Jason van Zyl a écrit :
> The fixes have been made, I'll recut the release.
>
> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
> > I've already reintroduced DefaultJavaToolChain and Tycho is happy now [1].
> >
> > Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to the
> > best of my knowledge, is not available from any other API, is not
> > available through ToolchainManager.
> >
> > I don't believe Tycho references JavaToolChain interface. As a side
> > note, in the future we should avoid case-only renames like
> > JavaToolChain->JavaToolchain, these cause problems on case-insensitive
> > filesystems, like the ones used by Windows and OSX.
> >
> > We don't distinguish between public and internal classes in Maven, at
> > least not generally. There are few classes that are explicitly marked as
> > @provisional, like ArtifactDescriptorReaderDelegate for example, but
> > this is not enforced and majority of classes are not marked in any way.
> > I agree we need to have a mechanism to distinguish between public and
> > internal classes and I have few ideas to do this, but I don't think we
> > can do this retroactively. We have to keep most/all existing classes and
> > treat them as public API, unfortunately. Maybe mark them as deprecated
> > when we know we will likely change them in the future, but any real
> > change has to wait Maven 4, and I am not sure we'll be able to afford
> > massive breakage even then.
> >
> > [1]
> > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56
> > ab0facd36751ccee722db6a2006f50
> >
> > --
> > Regards,
> > Igor
> >
> > On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
> >> ok, I had a look at Tycho sources:
> >> this is something introduced recently (10/10/2014): IIUC, Tycho 0.22.0
> >> was
> >> released since then
> >>
> >> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a rewrite
> >> of a part of maven-toochains-plugin, depending on
> >> ToolchainManagerPrivate which is not part of public API
> >> IIUC, the intent was to get the configured toolchain: since then, I wrote
> >> a
> >> little doc for that [1] to show how to use ToolchainManager to do exactly
> >> that using normal Maven API
> >>
> >> Notice this won't fix everything, since:
> >> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
> >> ToolChain) 2. the interface doesn't offer expected getJavaHome() API
> >>
> >>
> >> Then you'll need to cast to DefaultJavaToolChain, which will need to be
> >> added back to maven-core: I'll do it immediately.
> >>
> >> I don't know the Tycho community, but using ToolchainManager would IMHO
> >> be
> >> more future-proof than writing ToolchainProvider
> >>
> >> Regards,
> >>
> >> Hervé
> >>
> >>
> >> [1]
> >> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custo
> >> m.html>>
> >> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
> >>> DefaultJavaToolChain? you mean the implementation?
> >>>
> >>> Can you give me pointers to the Tycho sources that use this API?
> >>> (that's clearly not expected)
> >>>
> >>> I'm in favor of introducing deprecated DefaultJavaToolChain
> >>> that extends the new implementation, which is easy to do: just need to
> >>> understand how it is used in Tycho, since the class is supposed to be
> >>> used
> >>> by JavaToolchainFactory (on only this one).
> >>>
> >>> Regards,
> >>>
> >>> Hervé
> >>>
> >>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> >>>> Unfortunately, I have to take this back. The changes to toolchain
> >>>> broke Tycho and, short of using reflection, I don't see how
> >>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
> >>>>
> >>>> For better or worse,
> >>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> >>>> Maven API since 2.x and I don't think we can just remove the class.
> >>>>
> >>>> I see two ways to fix this. Either we rename the classes back, which is
> >>>> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
> >>>> that extends the new implementation.
> >>>>
> >>>> Here is my -1 for releasing 3.2.4 in its current state.
> >>>>
> >>>> --
> >>>> Regards,
> >>>> Igor
> >>>>
> >>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> >>>>> +1
> >>>>>
> >>>>> --
> >>>>> Regards,
> >>>>> Igor
> >>>>>
> >>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>> Time to release Maven 3.2.4!
> >>>>>>
> >>>>>> Here is a link to Jira with 20 issues resolved:
> >>>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&ver
> >>>>>> si
> >>>>>> on
> >>>>>> =20574
> >>>>>>
> >>>>>>
> >>>>>> Staging repo:
> >>>>>> https://repository.apache.org/content/repositories/maven-1102/
> >>>>>>
> >>>>>> The distributable binaries and sources for testing can be found here:
> >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apa
> >>>>>> ch
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/
> >>>>>>
> >>>>>>
> >>>>>> Specifically the zip, tarball, and source archives can be found here:
> >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apa
> >>>>>> ch
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>>>>>
> >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apa
> >>>>>> ch
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>>>>>
> >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apa
> >>>>>> ch
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>>>>>
> >>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apa
> >>>>>> ch
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> >>>>>>
> >>>>>>
> >>>>>> Source release checksum(s):
> >>>>>> apache-maven-3.2.4-src.zip sha1:
> >>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>>>>>
> >>>>>> Staging site:
> >>>>>> http://takari.io/maven-3.2.4/
> >>>>>>
> >>>>>> Vote open for 72 hours.
> >>>>>>
> >>>>>> [ ] +1
> >>>>>> [ ] +0
> >>>>>> [ ] -1
> >>>>>>
> >>>>>> Thanks,
> >>>>>>
> >>>>>> The Maven Team
> >>>>>> ---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/takari_io
> ---------------------------------------------------------
>
> The modern conservative is engaged in one of man's oldest exercises in moral
> philosophy; that is, the search for a superior moral justification for
> selfishness.
>
> -- John Kenneth Galbraith
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Jason van Zyl <ja...@takari.io>.
Have the thread handy? I honestly forget having to agreed to that.
On Dec 13, 2014, at 5:05 PM, Paul Benedict <pb...@apache.org> wrote:
> We agreed that each new recut is a new point release.
>
>
> Cheers,
> Paul
>
> On Sat, Dec 13, 2014 at 3:42 PM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
>>
>> Why? How will we tell the original broken binaries from the new ones?
>>
>> On December 13, 2014 4:01:31 PM EST, Jason van Zyl <ja...@takari.io>
>> wrote:
>>> No, it will be 3.2.4.
>>>
>>> On Dec 13, 2014, at 3:52 PM, Stephen Connolly
>>> <st...@gmail.com> wrote:
>>>
>>>> Iirc we said not reusing version numbers after a .0 so this will be
>>> 3.2.5,
>>>> yes?
>>>>
>>>> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
>>> wrote:
>>>>
>>>>> The fixes have been made, I'll recut the release.
>>>>>
>>>>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
>>>>> <javascript:;>> wrote:
>>>>>
>>>>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy
>>> now
>>>>> [1].
>>>>>>
>>>>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to
>>> the
>>>>>> best of my knowledge, is not available from any other API, is not
>>>>>> available through ToolchainManager.
>>>>>>
>>>>>> I don't believe Tycho references JavaToolChain interface. As a side
>>>>>> note, in the future we should avoid case-only renames like
>>>>>> JavaToolChain->JavaToolchain, these cause problems on
>>> case-insensitive
>>>>>> filesystems, like the ones used by Windows and OSX.
>>>>>>
>>>>>> We don't distinguish between public and internal classes in Maven,
>>> at
>>>>>> least not generally. There are few classes that are explicitly
>>> marked as
>>>>>> @provisional, like ArtifactDescriptorReaderDelegate for example,
>>> but
>>>>>> this is not enforced and majority of classes are not marked in any
>>> way.
>>>>>> I agree we need to have a mechanism to distinguish between public
>>> and
>>>>>> internal classes and I have few ideas to do this, but I don't think
>>> we
>>>>>> can do this retroactively. We have to keep most/all existing
>>> classes and
>>>>>> treat them as public API, unfortunately. Maybe mark them as
>>> deprecated
>>>>>> when we know we will likely change them in the future, but any real
>>>>>> change has to wait Maven 4, and I am not sure we'll be able to
>>> afford
>>>>>> massive breakage even then.
>>>>>>
>>>>>> [1]
>>>>>
>>>
>> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Igor
>>>>>>
>>>>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
>>>>>>> ok, I had a look at Tycho sources:
>>>>>>> this is something introduced recently (10/10/2014): IIUC, Tycho
>>> 0.22.0
>>>>> was
>>>>>>> released since then
>>>>>>>
>>>>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a
>>> rewrite
>>>>> of a
>>>>>>> part of maven-toochains-plugin, depending on
>>> ToolchainManagerPrivate
>>>>> which is
>>>>>>> not part of public API
>>>>>>> IIUC, the intent was to get the configured toolchain: since then,
>>> I
>>>>> wrote a
>>>>>>> little doc for that [1] to show how to use ToolchainManager to do
>>>>> exactly that
>>>>>>> using normal Maven API
>>>>>>>
>>>>>>> Notice this won't fix everything, since:
>>>>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
>>>>> ToolChain)
>>>>>>> 2. the interface doesn't offer expected getJavaHome() API
>>>>>>>
>>>>>>>
>>>>>>> Then you'll need to cast to DefaultJavaToolChain, which will need
>>> to be
>>>>> added
>>>>>>> back to maven-core: I'll do it immediately.
>>>>>>>
>>>>>>> I don't know the Tycho community, but using ToolchainManager would
>>> IMHO
>>>>> be
>>>>>>> more future-proof than writing ToolchainProvider
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>> Hervé
>>>>>>>
>>>>>>>
>>>>>>> [1]
>>>>>
>>>
>> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
>>>>>>>
>>>>>>>
>>>>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
>>>>>>>> DefaultJavaToolChain? you mean the implementation?
>>>>>>>>
>>>>>>>> Can you give me pointers to the Tycho sources that use this API?
>>>>>>>> (that's clearly not expected)
>>>>>>>>
>>>>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
>>>>>>>> that extends the new implementation, which is easy to do: just
>>> need to
>>>>>>>> understand how it is used in Tycho, since the class is supposed
>>> to be
>>>>> used
>>>>>>>> by JavaToolchainFactory (on only this one).
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>>
>>>>>>>> Hervé
>>>>>>>>
>>>>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
>>>>>>>>> Unfortunately, I have to take this back. The changes to
>>> toolchain
>>>>>>>>> broke Tycho and, short of using reflection, I don't see how
>>>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
>>> Maven.
>>>>>>>>>
>>>>>>>>> For better or worse,
>>>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>>>>>>> Maven API since 2.x and I don't think we can just remove the
>>> class.
>>>>>>>>>
>>>>>>>>> I see two ways to fix this. Either we rename the classes back,
>>> which
>>>>> is
>>>>>>>>> probably the easiest. Or we introduce deprecated
>>> DefaultJavaToolChain
>>>>>>>>> that extends the new implementation.
>>>>>>>>>
>>>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Regards,
>>>>>>>>> Igor
>>>>>>>>>
>>>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>>>>>>> +1
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Regards,
>>>>>>>>>> Igor
>>>>>>>>>>
>>>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> Time to release Maven 3.2.4!
>>>>>>>>>>>
>>>>>>>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>>>>>>>
>>>>>
>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
>>>>>>>>>>> on
>>>>>>>>>>> =20574
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Staging repo:
>>>>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>>>>>>
>>>>>>>>>>> The distributable binaries and sources for testing can be
>>> found
>>>>> here:
>>>>>>>>>>>
>>>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>> e/
>>>>>>>>>>> maven/apache-maven/3.2.4/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Specifically the zip, tarball, and source archives can be
>>> found
>>>>> here:
>>>>>>>>>>>
>>>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>> e/
>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>> e/
>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>> e/
>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>> e/
>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Source release checksum(s):
>>>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
>>>>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>>>>>>>
>>>>>>>>>>> Staging site:
>>>>>>>>>>> http://takari.io/maven-3.2.4/
>>>>>>>>>>>
>>>>>>>>>>> Vote open for 72 hours.
>>>>>>>>>>>
>>>>>>>>>>> [ ] +1
>>>>>>>>>>> [ ] +0
>>>>>>>>>>> [ ] -1
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>>
>>>>>>>>>>> The Maven Team
>>>>>>>>>>>
>>>>>
>>> ---------------------------------------------------------------------
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> <javascript:;>
>>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>> <javascript:;>
>>>>>>>>>>
>>>>>>>>>>
>>> ---------------------------------------------------------------------
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> <javascript:;>
>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>> <javascript:;>
>>>>>>>>>
>>>>>>>>>
>>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> <javascript:;>
>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>> <javascript:;>
>>>>>>>>
>>>>>>>>
>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> <javascript:;>
>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>> <javascript:;>
>>>>>>>
>>>>>>>
>>>>>>>
>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> <javascript:;>
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>> <javascript:;>
>>>>>>>
>>>>>>
>>>>>>
>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> <javascript:;>
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>> <javascript:;>
>>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Jason
>>>>>
>>>>> ----------------------------------------------------------
>>>>> Jason van Zyl
>>>>> Founder, Apache Maven
>>>>> http://twitter.com/jvanzyl
>>>>> http://twitter.com/takari_io
>>>>> ---------------------------------------------------------
>>>>>
>>>>> The modern conservative is engaged in one of man's oldest exercises
>>> in
>>>>> moral philosophy; that is,
>>>>> the search for a superior moral justification for selfishness.
>>>>>
>>>>> -- John Kenneth Galbraith
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> --
>>>> Sent from my phone
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder, Apache Maven
>>> http://twitter.com/jvanzyl
>>> http://twitter.com/takari_io
>>> ---------------------------------------------------------
>>>
>>> To think is easy. To act is hard. But the hardest thing in the world is
>>> to act in accordance with your thinking.
>>>
>>> -- Johann von Goethe
>>
>> --
>> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
happiness is like a butterfly: the more you chase it, the more it will
elude you, but if you turn your attention to other things, it will come
and sit softly on your shoulder ...
-- Thoreau
Re: [VOTE] Maven 3.2.4 Release
Posted by Paul Benedict <pb...@apache.org>.
We agreed that each new recut is a new point release.
Cheers,
Paul
On Sat, Dec 13, 2014 at 3:42 PM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
>
> Why? How will we tell the original broken binaries from the new ones?
>
> On December 13, 2014 4:01:31 PM EST, Jason van Zyl <ja...@takari.io>
> wrote:
> >No, it will be 3.2.4.
> >
> >On Dec 13, 2014, at 3:52 PM, Stephen Connolly
> ><st...@gmail.com> wrote:
> >
> >> Iirc we said not reusing version numbers after a .0 so this will be
> >3.2.5,
> >> yes?
> >>
> >> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
> >wrote:
> >>
> >>> The fixes have been made, I'll recut the release.
> >>>
> >>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
> >>> <javascript:;>> wrote:
> >>>
> >>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy
> >now
> >>> [1].
> >>>>
> >>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to
> >the
> >>>> best of my knowledge, is not available from any other API, is not
> >>>> available through ToolchainManager.
> >>>>
> >>>> I don't believe Tycho references JavaToolChain interface. As a side
> >>>> note, in the future we should avoid case-only renames like
> >>>> JavaToolChain->JavaToolchain, these cause problems on
> >case-insensitive
> >>>> filesystems, like the ones used by Windows and OSX.
> >>>>
> >>>> We don't distinguish between public and internal classes in Maven,
> >at
> >>>> least not generally. There are few classes that are explicitly
> >marked as
> >>>> @provisional, like ArtifactDescriptorReaderDelegate for example,
> >but
> >>>> this is not enforced and majority of classes are not marked in any
> >way.
> >>>> I agree we need to have a mechanism to distinguish between public
> >and
> >>>> internal classes and I have few ideas to do this, but I don't think
> >we
> >>>> can do this retroactively. We have to keep most/all existing
> >classes and
> >>>> treat them as public API, unfortunately. Maybe mark them as
> >deprecated
> >>>> when we know we will likely change them in the future, but any real
> >>>> change has to wait Maven 4, and I am not sure we'll be able to
> >afford
> >>>> massive breakage even then.
> >>>>
> >>>> [1]
> >>>
> >
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
> >>>>
> >>>> --
> >>>> Regards,
> >>>> Igor
> >>>>
> >>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
> >>>>> ok, I had a look at Tycho sources:
> >>>>> this is something introduced recently (10/10/2014): IIUC, Tycho
> >0.22.0
> >>> was
> >>>>> released since then
> >>>>>
> >>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a
> >rewrite
> >>> of a
> >>>>> part of maven-toochains-plugin, depending on
> >ToolchainManagerPrivate
> >>> which is
> >>>>> not part of public API
> >>>>> IIUC, the intent was to get the configured toolchain: since then,
> >I
> >>> wrote a
> >>>>> little doc for that [1] to show how to use ToolchainManager to do
> >>> exactly that
> >>>>> using normal Maven API
> >>>>>
> >>>>> Notice this won't fix everything, since:
> >>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
> >>> ToolChain)
> >>>>> 2. the interface doesn't offer expected getJavaHome() API
> >>>>>
> >>>>>
> >>>>> Then you'll need to cast to DefaultJavaToolChain, which will need
> >to be
> >>> added
> >>>>> back to maven-core: I'll do it immediately.
> >>>>>
> >>>>> I don't know the Tycho community, but using ToolchainManager would
> >IMHO
> >>> be
> >>>>> more future-proof than writing ToolchainProvider
> >>>>>
> >>>>> Regards,
> >>>>>
> >>>>> Hervé
> >>>>>
> >>>>>
> >>>>> [1]
> >>>
> >
> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
> >>>>>
> >>>>>
> >>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
> >>>>>> DefaultJavaToolChain? you mean the implementation?
> >>>>>>
> >>>>>> Can you give me pointers to the Tycho sources that use this API?
> >>>>>> (that's clearly not expected)
> >>>>>>
> >>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
> >>>>>> that extends the new implementation, which is easy to do: just
> >need to
> >>>>>> understand how it is used in Tycho, since the class is supposed
> >to be
> >>> used
> >>>>>> by JavaToolchainFactory (on only this one).
> >>>>>>
> >>>>>> Regards,
> >>>>>>
> >>>>>> Hervé
> >>>>>>
> >>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> >>>>>>> Unfortunately, I have to take this back. The changes to
> >toolchain
> >>>>>>> broke Tycho and, short of using reflection, I don't see how
> >>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
> >Maven.
> >>>>>>>
> >>>>>>> For better or worse,
> >>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> >>>>>>> Maven API since 2.x and I don't think we can just remove the
> >class.
> >>>>>>>
> >>>>>>> I see two ways to fix this. Either we rename the classes back,
> >which
> >>> is
> >>>>>>> probably the easiest. Or we introduce deprecated
> >DefaultJavaToolChain
> >>>>>>> that extends the new implementation.
> >>>>>>>
> >>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
> >>>>>>>
> >>>>>>> --
> >>>>>>> Regards,
> >>>>>>> Igor
> >>>>>>>
> >>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> >>>>>>>> +1
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Regards,
> >>>>>>>> Igor
> >>>>>>>>
> >>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> >>>>>>>>> Hi,
> >>>>>>>>>
> >>>>>>>>> Time to release Maven 3.2.4!
> >>>>>>>>>
> >>>>>>>>> Here is a link to Jira with 20 issues resolved:
> >>>>>>>>>
> >>>
> >https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
> >>>>>>>>> on
> >>>>>>>>> =20574
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Staging repo:
> >>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
> >>>>>>>>>
> >>>>>>>>> The distributable binaries and sources for testing can be
> >found
> >>> here:
> >>>>>>>>>
> >>>
> >https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>> e/
> >>>>>>>>> maven/apache-maven/3.2.4/
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Specifically the zip, tarball, and source archives can be
> >found
> >>> here:
> >>>>>>>>>
> >>>
> >https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>> e/
> >>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>>>>>>>>
> >>>>>>>>>
> >>>
> >https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>> e/
> >>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>>>>>>>>
> >>>>>>>>>
> >>>
> >https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>> e/
> >>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>>>>>>>>
> >>>>>>>>>
> >>>
> >https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>> e/
> >>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Source release checksum(s):
> >>>>>>>>> apache-maven-3.2.4-src.zip sha1:
> >>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>>>>>>>>
> >>>>>>>>> Staging site:
> >>>>>>>>> http://takari.io/maven-3.2.4/
> >>>>>>>>>
> >>>>>>>>> Vote open for 72 hours.
> >>>>>>>>>
> >>>>>>>>> [ ] +1
> >>>>>>>>> [ ] +0
> >>>>>>>>> [ ] -1
> >>>>>>>>>
> >>>>>>>>> Thanks,
> >>>>>>>>>
> >>>>>>>>> The Maven Team
> >>>>>>>>>
> >>>
> >---------------------------------------------------------------------
> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>> <javascript:;>
> >>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>> <javascript:;>
> >>>>>>>>
> >>>>>>>>
> >---------------------------------------------------------------------
> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>> <javascript:;>
> >>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>> <javascript:;>
> >>>>>>>
> >>>>>>>
> >---------------------------------------------------------------------
> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>> <javascript:;>
> >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>> <javascript:;>
> >>>>>>
> >>>>>>
> >---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>> <javascript:;>
> >>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>> <javascript:;>
> >>>>>
> >>>>>
> >>>>>
> >---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> ><javascript:;>
> >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>> <javascript:;>
> >>>>>
> >>>>
> >>>>
> >---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> ><javascript:;>
> >>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>> <javascript:;>
> >>>>
> >>>
> >>> Thanks,
> >>>
> >>> Jason
> >>>
> >>> ----------------------------------------------------------
> >>> Jason van Zyl
> >>> Founder, Apache Maven
> >>> http://twitter.com/jvanzyl
> >>> http://twitter.com/takari_io
> >>> ---------------------------------------------------------
> >>>
> >>> The modern conservative is engaged in one of man's oldest exercises
> >in
> >>> moral philosophy; that is,
> >>> the search for a superior moral justification for selfishness.
> >>>
> >>> -- John Kenneth Galbraith
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>
> >> --
> >> Sent from my phone
> >
> >Thanks,
> >
> >Jason
> >
> >----------------------------------------------------------
> >Jason van Zyl
> >Founder, Apache Maven
> >http://twitter.com/jvanzyl
> >http://twitter.com/takari_io
> >---------------------------------------------------------
> >
> >To think is easy. To act is hard. But the hardest thing in the world is
> >to act in accordance with your thinking.
> >
> > -- Johann von Goethe
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [VOTE] Maven 3.2.4 Release
Posted by Benson Margulies <bi...@gmail.com>.
If people really don't want to end up skipping numbers, and also people
also don't want to recreate tags, there are solutions.
For example, Lucene recognizes that serious testing of snapshots just never
happens. So, the release manager starts by doing the full release process
for X.Y.Z-RC1. And puts it _up for a vote_. If if it fails, everyone fixes
what's wrong, and the RM tries again with RC2. And repeats, as necessary.
Once some RCn has gets voted OK, it is left out there for the larger
community to poke at a bit, and then the RM makes one more package, for
X.Y.Z, and puts _that_ up for a vote.
The result is that non-RC releases just about never fail, because the
community is diligent about testing the RC releases, and because the fully
voted status of RC releases makes them distributable to a broader
collection of potential testers.
This is just one approach. There's also the even-odd numbering scheme
(httpd, e.g., I think), where some release numbers are documented to just
solicit testing, and others are meant for serious use. Presumably, those
medical establishments are capable of understanding simple patterns. (And I
doubt the applicability of that whole issue to a development tool.)
I'm not advocating here, just offering options.
On Sat, Dec 13, 2014 at 7:28 PM, Jeff Jensen <
jeffjensen@upstairstechnology.com> wrote:
> While I agree with your assessment Paul, the problem with upgrading
> non-sequential release numbers that I encounter with some of my customers
> (the larger organizations or ones with regulated products [think medical])
> is it usually causes some confusion ("we're on version n.2 and I see n.8
> but nothing in between, anyone know what happened? Is this a large jump -
> will we have problems?") and extra work (digging into it multiple times by
> multiple people as each team approaches upgrading tools). The larger the
> gap, the more hassle it may cause for them.
>
> In a build pipeline, I'm very happy to burn through release numbers.
>
> In the Maven release case, since it was never released (only staged for
> review before release), I don't consider it a problem to re-stage/respin
> with the same number. And my favorite perspective to evaluate from is my
> customer's, and some of them would appreciate no version gaps!
>
>
> On Sat, Dec 13, 2014 at 4:46 PM, Paul Benedict <pb...@apache.org>
> wrote:
> >
> > I can see your point. However, I don't think it's all that unusual for
> > people to see skipped versions during upgrading anymore. For example,
> when
> > a security issue is found in a GA product, the affected version is
> > instantly pulled from distribution sites and a new version is published.
> > Whether a bum internal build or retroactively taking GA from a release,
> if
> > you aren't upgrading frequently, I think skipping versions is not
> shocking.
> > That's my experience anyway. I see you have a different experience but
> glad
> > you shared it.
> >
> >
> > Cheers,
> > Paul
> >
> > On Sat, Dec 13, 2014 at 4:32 PM, Jason van Zyl <ja...@takari.io> wrote:
> > >
> > > Sure, I never wanted to do it which is why I forgot and will likely
> > > continue to forget so I'll change the docs because I always have to
> look
> > at
> > > them to figure out how to publish the site. I still think it's a
> > > inconsistent practice for the few it would inconvenience in a minor
> way.
> > >
> > > On Dec 13, 2014, at 5:27 PM, Paul Benedict <pb...@apache.org>
> wrote:
> > >
> > > > When the 3.2.0 build had a regression, we jumped to 3.2.1:
> > > >
> > >
> >
> http://mail-archives.apache.org/mod_mbox/maven-dev/201402.mbox/%3CDF2F7F9E-9334-43D9-AA01-03733604BA6A@takari.io%3E
> > > >
> > > > Sorry I didn't provide this thread up front. It took a while to find
> > it.
> > > > However, I am pretty sure we did this again with 3.2.3, but I could
> be
> > > > wrong on that fact -- I just remember we did this twice so far.
> > > >
> > > >
> > > > Cheers,
> > > > Paul
> > > >
> > > > On Sat, Dec 13, 2014 at 4:24 PM, Jason van Zyl <ja...@takari.io>
> > wrote:
> > > >>
> > > >> I don't because it's inconsistent for external users who will be
> > > confused
> > > >> about where a release has gone. To date I have never skipped
> versions,
> > > for
> > > >> consistency I don't want to start now. I consider the staged
> releases
> > > not
> > > >> contributing to the public version pool.
> > > >>
> > > >> For your case I think you're probably the only person in the world
> who
> > > >> integrates a staged release of Maven. For normal testers, running
> > Maven
> > > >> 3.2.4 doesn't download Maven 3.2.4 related binaries in your local
> > repo.
> > > >>
> > > >> But even if you weren't the only person is it that hard to cleanup
> the
> > > >> punched release locally? I see the reuse of versions as being
> > > >> problematically negligible while the confusion for users being high.
> > > >>
> > > >> On Dec 13, 2014, at 4:42 PM, Igor Fedorenko <ig...@ifedorenko.com>
> > > wrote:
> > > >>
> > > >>> Why? How will we tell the original broken binaries from the new
> ones?
> > > >>>
> > > >>> On December 13, 2014 4:01:31 PM EST, Jason van Zyl <
> jason@takari.io>
> > > >> wrote:
> > > >>>> No, it will be 3.2.4.
> > > >>>>
> > > >>>> On Dec 13, 2014, at 3:52 PM, Stephen Connolly
> > > >>>> <st...@gmail.com> wrote:
> > > >>>>
> > > >>>>> Iirc we said not reusing version numbers after a .0 so this will
> be
> > > >>>> 3.2.5,
> > > >>>>> yes?
> > > >>>>>
> > > >>>>> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
> > > >>>> wrote:
> > > >>>>>
> > > >>>>>> The fixes have been made, I'll recut the release.
> > > >>>>>>
> > > >>>>>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <
> igor@ifedorenko.com
> > > >>>>>> <javascript:;>> wrote:
> > > >>>>>>
> > > >>>>>>> I've already reintroduced DefaultJavaToolChain and Tycho is
> happy
> > > >>>> now
> > > >>>>>> [1].
> > > >>>>>>>
> > > >>>>>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which,
> > to
> > > >>>> the
> > > >>>>>>> best of my knowledge, is not available from any other API, is
> not
> > > >>>>>>> available through ToolchainManager.
> > > >>>>>>>
> > > >>>>>>> I don't believe Tycho references JavaToolChain interface. As a
> > side
> > > >>>>>>> note, in the future we should avoid case-only renames like
> > > >>>>>>> JavaToolChain->JavaToolchain, these cause problems on
> > > >>>> case-insensitive
> > > >>>>>>> filesystems, like the ones used by Windows and OSX.
> > > >>>>>>>
> > > >>>>>>> We don't distinguish between public and internal classes in
> > Maven,
> > > >>>> at
> > > >>>>>>> least not generally. There are few classes that are explicitly
> > > >>>> marked as
> > > >>>>>>> @provisional, like ArtifactDescriptorReaderDelegate for
> example,
> > > >>>> but
> > > >>>>>>> this is not enforced and majority of classes are not marked in
> > any
> > > >>>> way.
> > > >>>>>>> I agree we need to have a mechanism to distinguish between
> public
> > > >>>> and
> > > >>>>>>> internal classes and I have few ideas to do this, but I don't
> > think
> > > >>>> we
> > > >>>>>>> can do this retroactively. We have to keep most/all existing
> > > >>>> classes and
> > > >>>>>>> treat them as public API, unfortunately. Maybe mark them as
> > > >>>> deprecated
> > > >>>>>>> when we know we will likely change them in the future, but any
> > real
> > > >>>>>>> change has to wait Maven 4, and I am not sure we'll be able to
> > > >>>> afford
> > > >>>>>>> massive breakage even then.
> > > >>>>>>>
> > > >>>>>>> [1]
> > > >>>>>>
> > > >>>>
> > > >>
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
> > > >>>>>>>
> > > >>>>>>> --
> > > >>>>>>> Regards,
> > > >>>>>>> Igor
> > > >>>>>>>
> > > >>>>>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
> > > >>>>>>>> ok, I had a look at Tycho sources:
> > > >>>>>>>> this is something introduced recently (10/10/2014): IIUC,
> Tycho
> > > >>>> 0.22.0
> > > >>>>>> was
> > > >>>>>>>> released since then
> > > >>>>>>>>
> > > >>>>>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's
> a
> > > >>>> rewrite
> > > >>>>>> of a
> > > >>>>>>>> part of maven-toochains-plugin, depending on
> > > >>>> ToolchainManagerPrivate
> > > >>>>>> which is
> > > >>>>>>>> not part of public API
> > > >>>>>>>> IIUC, the intent was to get the configured toolchain: since
> > then,
> > > >>>> I
> > > >>>>>> wrote a
> > > >>>>>>>> little doc for that [1] to show how to use ToolchainManager to
> > do
> > > >>>>>> exactly that
> > > >>>>>>>> using normal Maven API
> > > >>>>>>>>
> > > >>>>>>>> Notice this won't fix everything, since:
> > > >>>>>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain
> > vs
> > > >>>>>> ToolChain)
> > > >>>>>>>> 2. the interface doesn't offer expected getJavaHome() API
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>> Then you'll need to cast to DefaultJavaToolChain, which will
> > need
> > > >>>> to be
> > > >>>>>> added
> > > >>>>>>>> back to maven-core: I'll do it immediately.
> > > >>>>>>>>
> > > >>>>>>>> I don't know the Tycho community, but using ToolchainManager
> > would
> > > >>>> IMHO
> > > >>>>>> be
> > > >>>>>>>> more future-proof than writing ToolchainProvider
> > > >>>>>>>>
> > > >>>>>>>> Regards,
> > > >>>>>>>>
> > > >>>>>>>> Hervé
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>> [1]
> > > >>>>>>
> > > >>>>
> > > >>
> > >
> >
> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
> > > >>>>>>>>> DefaultJavaToolChain? you mean the implementation?
> > > >>>>>>>>>
> > > >>>>>>>>> Can you give me pointers to the Tycho sources that use this
> > API?
> > > >>>>>>>>> (that's clearly not expected)
> > > >>>>>>>>>
> > > >>>>>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
> > > >>>>>>>>> that extends the new implementation, which is easy to do:
> just
> > > >>>> need to
> > > >>>>>>>>> understand how it is used in Tycho, since the class is
> supposed
> > > >>>> to be
> > > >>>>>> used
> > > >>>>>>>>> by JavaToolchainFactory (on only this one).
> > > >>>>>>>>>
> > > >>>>>>>>> Regards,
> > > >>>>>>>>>
> > > >>>>>>>>> Hervé
> > > >>>>>>>>>
> > > >>>>>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit
> :
> > > >>>>>>>>>> Unfortunately, I have to take this back. The changes to
> > > >>>> toolchain
> > > >>>>>>>>>> broke Tycho and, short of using reflection, I don't see how
> > > >>>>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
> > > >>>> Maven.
> > > >>>>>>>>>>
> > > >>>>>>>>>> For better or worse,
> > > >>>>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was
> part
> > of
> > > >>>>>>>>>> Maven API since 2.x and I don't think we can just remove the
> > > >>>> class.
> > > >>>>>>>>>>
> > > >>>>>>>>>> I see two ways to fix this. Either we rename the classes
> back,
> > > >>>> which
> > > >>>>>> is
> > > >>>>>>>>>> probably the easiest. Or we introduce deprecated
> > > >>>> DefaultJavaToolChain
> > > >>>>>>>>>> that extends the new implementation.
> > > >>>>>>>>>>
> > > >>>>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
> > > >>>>>>>>>>
> > > >>>>>>>>>> --
> > > >>>>>>>>>> Regards,
> > > >>>>>>>>>> Igor
> > > >>>>>>>>>>
> > > >>>>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> > > >>>>>>>>>>> +1
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> --
> > > >>>>>>>>>>> Regards,
> > > >>>>>>>>>>> Igor
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> > > >>>>>>>>>>>> Hi,
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Time to release Maven 3.2.4!
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Here is a link to Jira with 20 issues resolved:
> > > >>>>>>>>>>>>
> > > >>>>>>
> > > >>>>
> > >
> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
> > > >>>>>>>>>>>> on
> > > >>>>>>>>>>>> =20574
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Staging repo:
> > > >>>>>>>>>>>>
> > > https://repository.apache.org/content/repositories/maven-1102/
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> The distributable binaries and sources for testing can be
> > > >>>> found
> > > >>>>>> here:
> > > >>>>>>>>>>>>
> > > >>>>>>
> > > >>>>
> > >
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > > >>>>>>>>>>>> e/
> > > >>>>>>>>>>>> maven/apache-maven/3.2.4/
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Specifically the zip, tarball, and source archives can be
> > > >>>> found
> > > >>>>>> here:
> > > >>>>>>>>>>>>
> > > >>>>>>
> > > >>>>
> > >
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > > >>>>>>>>>>>> e/
> > > >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>
> > > >>>>
> > >
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > > >>>>>>>>>>>> e/
> > > >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>
> > > >>>>
> > >
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > > >>>>>>>>>>>> e/
> > > >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>
> > > >>>>
> > >
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > > >>>>>>>>>>>> e/
> > > >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Source release checksum(s):
> > > >>>>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
> > > >>>>>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Staging site:
> > > >>>>>>>>>>>> http://takari.io/maven-3.2.4/
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Vote open for 72 hours.
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> [ ] +1
> > > >>>>>>>>>>>> [ ] +0
> > > >>>>>>>>>>>> [ ] -1
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Thanks,
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> The Maven Team
> > > >>>>>>>>>>>>
> > > >>>>>>
> > > >>>>
> > ---------------------------------------------------------------------
> > > >>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>>>>>> For additional commands, e-mail:
> dev-help@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>
> > > >>>>
> > ---------------------------------------------------------------------
> > > >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>>>>
> > > >>>>>>>>>>
> > > >>>>
> > ---------------------------------------------------------------------
> > > >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>
> > ---------------------------------------------------------------------
> > > >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>
> > ---------------------------------------------------------------------
> > > >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>> <javascript:;>
> > > >>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>>
> > > >>>>>>>
> > > >>>>>>>
> > > >>>>
> > ---------------------------------------------------------------------
> > > >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>> <javascript:;>
> > > >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>>>> <javascript:;>
> > > >>>>>>>
> > > >>>>>>
> > > >>>>>> Thanks,
> > > >>>>>>
> > > >>>>>> Jason
> > > >>>>>>
> > > >>>>>> ----------------------------------------------------------
> > > >>>>>> Jason van Zyl
> > > >>>>>> Founder, Apache Maven
> > > >>>>>> http://twitter.com/jvanzyl
> > > >>>>>> http://twitter.com/takari_io
> > > >>>>>> ---------------------------------------------------------
> > > >>>>>>
> > > >>>>>> The modern conservative is engaged in one of man's oldest
> > exercises
> > > >>>> in
> > > >>>>>> moral philosophy; that is,
> > > >>>>>> the search for a superior moral justification for selfishness.
> > > >>>>>>
> > > >>>>>> -- John Kenneth Galbraith
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>
> > > >>>>> --
> > > >>>>> Sent from my phone
> > > >>>>
> > > >>>> Thanks,
> > > >>>>
> > > >>>> Jason
> > > >>>>
> > > >>>> ----------------------------------------------------------
> > > >>>> Jason van Zyl
> > > >>>> Founder, Apache Maven
> > > >>>> http://twitter.com/jvanzyl
> > > >>>> http://twitter.com/takari_io
> > > >>>> ---------------------------------------------------------
> > > >>>>
> > > >>>> To think is easy. To act is hard. But the hardest thing in the
> world
> > > is
> > > >>>> to act in accordance with your thinking.
> > > >>>>
> > > >>>> -- Johann von Goethe
> > > >>>
> > > >>> --
> > > >>> Sent from my Android device with K-9 Mail. Please excuse my
> brevity.
> > > >>>
> > > >>>
> ---------------------------------------------------------------------
> > > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>
> > > >>
> > > >> Thanks,
> > > >>
> > > >> Jason
> > > >>
> > > >> ----------------------------------------------------------
> > > >> Jason van Zyl
> > > >> Founder, Apache Maven
> > > >> http://twitter.com/jvanzyl
> > > >> http://twitter.com/takari_io
> > > >> ---------------------------------------------------------
> > > >>
> > > >> Be not afraid of growing slowly, be only afraid of standing still.
> > > >>
> > > >> -- Chinese Proverb
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > >
> > > Thanks,
> > >
> > > Jason
> > >
> > > ----------------------------------------------------------
> > > Jason van Zyl
> > > Founder, Apache Maven
> > > http://twitter.com/jvanzyl
> > > http://twitter.com/takari_io
> > > ---------------------------------------------------------
> > >
> > > You are never dedicated to something you have complete confidence in.
> > > No one is fanatically shouting that the sun is going to rise tomorrow.
> > > They know it is going to rise tomorrow. When people are fanatically
> > > dedicated to political or religious faiths or any other kind of
> > > dogmas or goals, it's always because these dogmas or
> > > goals are in doubt.
> > >
> > > -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
>
Re: [VOTE] Maven 3.2.4 Release
Posted by Jeff Jensen <je...@upstairstechnology.com>.
While I agree with your assessment Paul, the problem with upgrading
non-sequential release numbers that I encounter with some of my customers
(the larger organizations or ones with regulated products [think medical])
is it usually causes some confusion ("we're on version n.2 and I see n.8
but nothing in between, anyone know what happened? Is this a large jump -
will we have problems?") and extra work (digging into it multiple times by
multiple people as each team approaches upgrading tools). The larger the
gap, the more hassle it may cause for them.
In a build pipeline, I'm very happy to burn through release numbers.
In the Maven release case, since it was never released (only staged for
review before release), I don't consider it a problem to re-stage/respin
with the same number. And my favorite perspective to evaluate from is my
customer's, and some of them would appreciate no version gaps!
On Sat, Dec 13, 2014 at 4:46 PM, Paul Benedict <pb...@apache.org> wrote:
>
> I can see your point. However, I don't think it's all that unusual for
> people to see skipped versions during upgrading anymore. For example, when
> a security issue is found in a GA product, the affected version is
> instantly pulled from distribution sites and a new version is published.
> Whether a bum internal build or retroactively taking GA from a release, if
> you aren't upgrading frequently, I think skipping versions is not shocking.
> That's my experience anyway. I see you have a different experience but glad
> you shared it.
>
>
> Cheers,
> Paul
>
> On Sat, Dec 13, 2014 at 4:32 PM, Jason van Zyl <ja...@takari.io> wrote:
> >
> > Sure, I never wanted to do it which is why I forgot and will likely
> > continue to forget so I'll change the docs because I always have to look
> at
> > them to figure out how to publish the site. I still think it's a
> > inconsistent practice for the few it would inconvenience in a minor way.
> >
> > On Dec 13, 2014, at 5:27 PM, Paul Benedict <pb...@apache.org> wrote:
> >
> > > When the 3.2.0 build had a regression, we jumped to 3.2.1:
> > >
> >
> http://mail-archives.apache.org/mod_mbox/maven-dev/201402.mbox/%3CDF2F7F9E-9334-43D9-AA01-03733604BA6A@takari.io%3E
> > >
> > > Sorry I didn't provide this thread up front. It took a while to find
> it.
> > > However, I am pretty sure we did this again with 3.2.3, but I could be
> > > wrong on that fact -- I just remember we did this twice so far.
> > >
> > >
> > > Cheers,
> > > Paul
> > >
> > > On Sat, Dec 13, 2014 at 4:24 PM, Jason van Zyl <ja...@takari.io>
> wrote:
> > >>
> > >> I don't because it's inconsistent for external users who will be
> > confused
> > >> about where a release has gone. To date I have never skipped versions,
> > for
> > >> consistency I don't want to start now. I consider the staged releases
> > not
> > >> contributing to the public version pool.
> > >>
> > >> For your case I think you're probably the only person in the world who
> > >> integrates a staged release of Maven. For normal testers, running
> Maven
> > >> 3.2.4 doesn't download Maven 3.2.4 related binaries in your local
> repo.
> > >>
> > >> But even if you weren't the only person is it that hard to cleanup the
> > >> punched release locally? I see the reuse of versions as being
> > >> problematically negligible while the confusion for users being high.
> > >>
> > >> On Dec 13, 2014, at 4:42 PM, Igor Fedorenko <ig...@ifedorenko.com>
> > wrote:
> > >>
> > >>> Why? How will we tell the original broken binaries from the new ones?
> > >>>
> > >>> On December 13, 2014 4:01:31 PM EST, Jason van Zyl <ja...@takari.io>
> > >> wrote:
> > >>>> No, it will be 3.2.4.
> > >>>>
> > >>>> On Dec 13, 2014, at 3:52 PM, Stephen Connolly
> > >>>> <st...@gmail.com> wrote:
> > >>>>
> > >>>>> Iirc we said not reusing version numbers after a .0 so this will be
> > >>>> 3.2.5,
> > >>>>> yes?
> > >>>>>
> > >>>>> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
> > >>>> wrote:
> > >>>>>
> > >>>>>> The fixes have been made, I'll recut the release.
> > >>>>>>
> > >>>>>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
> > >>>>>> <javascript:;>> wrote:
> > >>>>>>
> > >>>>>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy
> > >>>> now
> > >>>>>> [1].
> > >>>>>>>
> > >>>>>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which,
> to
> > >>>> the
> > >>>>>>> best of my knowledge, is not available from any other API, is not
> > >>>>>>> available through ToolchainManager.
> > >>>>>>>
> > >>>>>>> I don't believe Tycho references JavaToolChain interface. As a
> side
> > >>>>>>> note, in the future we should avoid case-only renames like
> > >>>>>>> JavaToolChain->JavaToolchain, these cause problems on
> > >>>> case-insensitive
> > >>>>>>> filesystems, like the ones used by Windows and OSX.
> > >>>>>>>
> > >>>>>>> We don't distinguish between public and internal classes in
> Maven,
> > >>>> at
> > >>>>>>> least not generally. There are few classes that are explicitly
> > >>>> marked as
> > >>>>>>> @provisional, like ArtifactDescriptorReaderDelegate for example,
> > >>>> but
> > >>>>>>> this is not enforced and majority of classes are not marked in
> any
> > >>>> way.
> > >>>>>>> I agree we need to have a mechanism to distinguish between public
> > >>>> and
> > >>>>>>> internal classes and I have few ideas to do this, but I don't
> think
> > >>>> we
> > >>>>>>> can do this retroactively. We have to keep most/all existing
> > >>>> classes and
> > >>>>>>> treat them as public API, unfortunately. Maybe mark them as
> > >>>> deprecated
> > >>>>>>> when we know we will likely change them in the future, but any
> real
> > >>>>>>> change has to wait Maven 4, and I am not sure we'll be able to
> > >>>> afford
> > >>>>>>> massive breakage even then.
> > >>>>>>>
> > >>>>>>> [1]
> > >>>>>>
> > >>>>
> > >>
> >
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
> > >>>>>>>
> > >>>>>>> --
> > >>>>>>> Regards,
> > >>>>>>> Igor
> > >>>>>>>
> > >>>>>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
> > >>>>>>>> ok, I had a look at Tycho sources:
> > >>>>>>>> this is something introduced recently (10/10/2014): IIUC, Tycho
> > >>>> 0.22.0
> > >>>>>> was
> > >>>>>>>> released since then
> > >>>>>>>>
> > >>>>>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a
> > >>>> rewrite
> > >>>>>> of a
> > >>>>>>>> part of maven-toochains-plugin, depending on
> > >>>> ToolchainManagerPrivate
> > >>>>>> which is
> > >>>>>>>> not part of public API
> > >>>>>>>> IIUC, the intent was to get the configured toolchain: since
> then,
> > >>>> I
> > >>>>>> wrote a
> > >>>>>>>> little doc for that [1] to show how to use ToolchainManager to
> do
> > >>>>>> exactly that
> > >>>>>>>> using normal Maven API
> > >>>>>>>>
> > >>>>>>>> Notice this won't fix everything, since:
> > >>>>>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain
> vs
> > >>>>>> ToolChain)
> > >>>>>>>> 2. the interface doesn't offer expected getJavaHome() API
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> Then you'll need to cast to DefaultJavaToolChain, which will
> need
> > >>>> to be
> > >>>>>> added
> > >>>>>>>> back to maven-core: I'll do it immediately.
> > >>>>>>>>
> > >>>>>>>> I don't know the Tycho community, but using ToolchainManager
> would
> > >>>> IMHO
> > >>>>>> be
> > >>>>>>>> more future-proof than writing ToolchainProvider
> > >>>>>>>>
> > >>>>>>>> Regards,
> > >>>>>>>>
> > >>>>>>>> Hervé
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> [1]
> > >>>>>>
> > >>>>
> > >>
> >
> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
> > >>>>>>>>> DefaultJavaToolChain? you mean the implementation?
> > >>>>>>>>>
> > >>>>>>>>> Can you give me pointers to the Tycho sources that use this
> API?
> > >>>>>>>>> (that's clearly not expected)
> > >>>>>>>>>
> > >>>>>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
> > >>>>>>>>> that extends the new implementation, which is easy to do: just
> > >>>> need to
> > >>>>>>>>> understand how it is used in Tycho, since the class is supposed
> > >>>> to be
> > >>>>>> used
> > >>>>>>>>> by JavaToolchainFactory (on only this one).
> > >>>>>>>>>
> > >>>>>>>>> Regards,
> > >>>>>>>>>
> > >>>>>>>>> Hervé
> > >>>>>>>>>
> > >>>>>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> > >>>>>>>>>> Unfortunately, I have to take this back. The changes to
> > >>>> toolchain
> > >>>>>>>>>> broke Tycho and, short of using reflection, I don't see how
> > >>>>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
> > >>>> Maven.
> > >>>>>>>>>>
> > >>>>>>>>>> For better or worse,
> > >>>>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part
> of
> > >>>>>>>>>> Maven API since 2.x and I don't think we can just remove the
> > >>>> class.
> > >>>>>>>>>>
> > >>>>>>>>>> I see two ways to fix this. Either we rename the classes back,
> > >>>> which
> > >>>>>> is
> > >>>>>>>>>> probably the easiest. Or we introduce deprecated
> > >>>> DefaultJavaToolChain
> > >>>>>>>>>> that extends the new implementation.
> > >>>>>>>>>>
> > >>>>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
> > >>>>>>>>>>
> > >>>>>>>>>> --
> > >>>>>>>>>> Regards,
> > >>>>>>>>>> Igor
> > >>>>>>>>>>
> > >>>>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> > >>>>>>>>>>> +1
> > >>>>>>>>>>>
> > >>>>>>>>>>> --
> > >>>>>>>>>>> Regards,
> > >>>>>>>>>>> Igor
> > >>>>>>>>>>>
> > >>>>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> > >>>>>>>>>>>> Hi,
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Time to release Maven 3.2.4!
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Here is a link to Jira with 20 issues resolved:
> > >>>>>>>>>>>>
> > >>>>>>
> > >>>>
> > https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
> > >>>>>>>>>>>> on
> > >>>>>>>>>>>> =20574
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Staging repo:
> > >>>>>>>>>>>>
> > https://repository.apache.org/content/repositories/maven-1102/
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> The distributable binaries and sources for testing can be
> > >>>> found
> > >>>>>> here:
> > >>>>>>>>>>>>
> > >>>>>>
> > >>>>
> > https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >>>>>>>>>>>> e/
> > >>>>>>>>>>>> maven/apache-maven/3.2.4/
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Specifically the zip, tarball, and source archives can be
> > >>>> found
> > >>>>>> here:
> > >>>>>>>>>>>>
> > >>>>>>
> > >>>>
> > https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >>>>>>>>>>>> e/
> > >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>
> > >>>>
> > https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >>>>>>>>>>>> e/
> > >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>
> > >>>>
> > https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >>>>>>>>>>>> e/
> > >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>
> > >>>>
> > https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >>>>>>>>>>>> e/
> > >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Source release checksum(s):
> > >>>>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
> > >>>>>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Staging site:
> > >>>>>>>>>>>> http://takari.io/maven-3.2.4/
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Vote open for 72 hours.
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> [ ] +1
> > >>>>>>>>>>>> [ ] +0
> > >>>>>>>>>>>> [ ] -1
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Thanks,
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> The Maven Team
> > >>>>>>>>>>>>
> > >>>>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>> <javascript:;>
> > >>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>> <javascript:;>
> > >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>> <javascript:;>
> > >>>>>>>
> > >>>>>>
> > >>>>>> Thanks,
> > >>>>>>
> > >>>>>> Jason
> > >>>>>>
> > >>>>>> ----------------------------------------------------------
> > >>>>>> Jason van Zyl
> > >>>>>> Founder, Apache Maven
> > >>>>>> http://twitter.com/jvanzyl
> > >>>>>> http://twitter.com/takari_io
> > >>>>>> ---------------------------------------------------------
> > >>>>>>
> > >>>>>> The modern conservative is engaged in one of man's oldest
> exercises
> > >>>> in
> > >>>>>> moral philosophy; that is,
> > >>>>>> the search for a superior moral justification for selfishness.
> > >>>>>>
> > >>>>>> -- John Kenneth Galbraith
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>
> > >>>>> --
> > >>>>> Sent from my phone
> > >>>>
> > >>>> Thanks,
> > >>>>
> > >>>> Jason
> > >>>>
> > >>>> ----------------------------------------------------------
> > >>>> Jason van Zyl
> > >>>> Founder, Apache Maven
> > >>>> http://twitter.com/jvanzyl
> > >>>> http://twitter.com/takari_io
> > >>>> ---------------------------------------------------------
> > >>>>
> > >>>> To think is easy. To act is hard. But the hardest thing in the world
> > is
> > >>>> to act in accordance with your thinking.
> > >>>>
> > >>>> -- Johann von Goethe
> > >>>
> > >>> --
> > >>> Sent from my Android device with K-9 Mail. Please excuse my brevity.
> > >>>
> > >>> ---------------------------------------------------------------------
> > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>
> > >>
> > >> Thanks,
> > >>
> > >> Jason
> > >>
> > >> ----------------------------------------------------------
> > >> Jason van Zyl
> > >> Founder, Apache Maven
> > >> http://twitter.com/jvanzyl
> > >> http://twitter.com/takari_io
> > >> ---------------------------------------------------------
> > >>
> > >> Be not afraid of growing slowly, be only afraid of standing still.
> > >>
> > >> -- Chinese Proverb
> > >>
> > >>
> > >>
> > >>
> > >>
> > >>
> > >>
> > >>
> > >>
> > >>
> >
> > Thanks,
> >
> > Jason
> >
> > ----------------------------------------------------------
> > Jason van Zyl
> > Founder, Apache Maven
> > http://twitter.com/jvanzyl
> > http://twitter.com/takari_io
> > ---------------------------------------------------------
> >
> > You are never dedicated to something you have complete confidence in.
> > No one is fanatically shouting that the sun is going to rise tomorrow.
> > They know it is going to rise tomorrow. When people are fanatically
> > dedicated to political or religious faiths or any other kind of
> > dogmas or goals, it's always because these dogmas or
> > goals are in doubt.
> >
> > -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
>
Re: [VOTE] Maven 3.2.4 Release
Posted by Paul Benedict <pb...@apache.org>.
Apache uses GA to mean a classification of a release; I don't mean it in
some sort of generalized sense. You can revoke the status of a release.
Whether you can erase it from everywhere it's been, that's another matter
(and not possible from Central, right).
Cheers,
Paul
On Sat, Dec 13, 2014 at 5:00 PM, Michael Osipov <mi...@apache.org> wrote:
>
> Am 2014-12-13 um 23:52 schrieb Paul Benedict:
>
>> Not Maven central, distribution (download) sites like Apache's.
>>
>
> I am aware of that but if something has gone GA, it is on Central.
> Otherwise the term 'GA' wouldn't hold true.
>
>
> Michael
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [VOTE] Maven 3.2.4 Release
Posted by Michael Osipov <mi...@apache.org>.
Am 2014-12-13 um 23:52 schrieb Paul Benedict:
> Not Maven central, distribution (download) sites like Apache's.
I am aware of that but if something has gone GA, it is on Central.
Otherwise the term 'GA' wouldn't hold true.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Paul Benedict <pb...@apache.org>.
Not Maven central, distribution (download) sites like Apache's.
Cheers,
Paul
On Sat, Dec 13, 2014 at 4:50 PM, Michael Osipov <mi...@apache.org> wrote:
>
> Am 2014-12-13 um 23:46 schrieb Paul Benedict:
>
>> I can see your point. However, I don't think it's all that unusual for
>> people to see skipped versions during upgrading anymore. For example, when
>> a security issue is found in a GA product, the affected version is
>> instantly pulled from distribution sites and a new version is published.
>>
>
> You cannot remove anything from Central, so even your broken GA will
> remain there for ever.
>
> How do you intend to avoid that?
>
> Michael
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [VOTE] Maven 3.2.4 Release
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi,
we are here in a complete different situation.
During the VOTE the artifacts are stored in a stage repository which can
simply being dropped (Which is the idea of those staged repository). The
only thing which is needed to be fixed is the SCM Tag (Git, SVN...).
This can be done....
If we would have found the problem after they have been cleared and
released than it would be impossible to remove them from Central.
Furthermore the release area is a Subversion repository which can be
changed and it's documented according to the nature of SVN itself.
On 12/13/14 11:50 PM, Michael Osipov wrote:
> Am 2014-12-13 um 23:46 schrieb Paul Benedict:
>> I can see your point. However, I don't think it's all that unusual for
>> people to see skipped versions during upgrading anymore. For example,
>> when
>> a security issue is found in a GA product, the affected version is
>> instantly pulled from distribution sites and a new version is published.
>
> You cannot remove anything from Central, so even your broken GA will
> remain there for ever.
>
> How do you intend to avoid that?
>
> Michael
>
>
Kind Regards
Karl Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Michael Osipov <mi...@apache.org>.
Am 2014-12-13 um 23:46 schrieb Paul Benedict:
> I can see your point. However, I don't think it's all that unusual for
> people to see skipped versions during upgrading anymore. For example, when
> a security issue is found in a GA product, the affected version is
> instantly pulled from distribution sites and a new version is published.
You cannot remove anything from Central, so even your broken GA will
remain there for ever.
How do you intend to avoid that?
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Paul Benedict <pb...@apache.org>.
I can see your point. However, I don't think it's all that unusual for
people to see skipped versions during upgrading anymore. For example, when
a security issue is found in a GA product, the affected version is
instantly pulled from distribution sites and a new version is published.
Whether a bum internal build or retroactively taking GA from a release, if
you aren't upgrading frequently, I think skipping versions is not shocking.
That's my experience anyway. I see you have a different experience but glad
you shared it.
Cheers,
Paul
On Sat, Dec 13, 2014 at 4:32 PM, Jason van Zyl <ja...@takari.io> wrote:
>
> Sure, I never wanted to do it which is why I forgot and will likely
> continue to forget so I'll change the docs because I always have to look at
> them to figure out how to publish the site. I still think it's a
> inconsistent practice for the few it would inconvenience in a minor way.
>
> On Dec 13, 2014, at 5:27 PM, Paul Benedict <pb...@apache.org> wrote:
>
> > When the 3.2.0 build had a regression, we jumped to 3.2.1:
> >
> http://mail-archives.apache.org/mod_mbox/maven-dev/201402.mbox/%3CDF2F7F9E-9334-43D9-AA01-03733604BA6A@takari.io%3E
> >
> > Sorry I didn't provide this thread up front. It took a while to find it.
> > However, I am pretty sure we did this again with 3.2.3, but I could be
> > wrong on that fact -- I just remember we did this twice so far.
> >
> >
> > Cheers,
> > Paul
> >
> > On Sat, Dec 13, 2014 at 4:24 PM, Jason van Zyl <ja...@takari.io> wrote:
> >>
> >> I don't because it's inconsistent for external users who will be
> confused
> >> about where a release has gone. To date I have never skipped versions,
> for
> >> consistency I don't want to start now. I consider the staged releases
> not
> >> contributing to the public version pool.
> >>
> >> For your case I think you're probably the only person in the world who
> >> integrates a staged release of Maven. For normal testers, running Maven
> >> 3.2.4 doesn't download Maven 3.2.4 related binaries in your local repo.
> >>
> >> But even if you weren't the only person is it that hard to cleanup the
> >> punched release locally? I see the reuse of versions as being
> >> problematically negligible while the confusion for users being high.
> >>
> >> On Dec 13, 2014, at 4:42 PM, Igor Fedorenko <ig...@ifedorenko.com>
> wrote:
> >>
> >>> Why? How will we tell the original broken binaries from the new ones?
> >>>
> >>> On December 13, 2014 4:01:31 PM EST, Jason van Zyl <ja...@takari.io>
> >> wrote:
> >>>> No, it will be 3.2.4.
> >>>>
> >>>> On Dec 13, 2014, at 3:52 PM, Stephen Connolly
> >>>> <st...@gmail.com> wrote:
> >>>>
> >>>>> Iirc we said not reusing version numbers after a .0 so this will be
> >>>> 3.2.5,
> >>>>> yes?
> >>>>>
> >>>>> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
> >>>> wrote:
> >>>>>
> >>>>>> The fixes have been made, I'll recut the release.
> >>>>>>
> >>>>>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
> >>>>>> <javascript:;>> wrote:
> >>>>>>
> >>>>>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy
> >>>> now
> >>>>>> [1].
> >>>>>>>
> >>>>>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to
> >>>> the
> >>>>>>> best of my knowledge, is not available from any other API, is not
> >>>>>>> available through ToolchainManager.
> >>>>>>>
> >>>>>>> I don't believe Tycho references JavaToolChain interface. As a side
> >>>>>>> note, in the future we should avoid case-only renames like
> >>>>>>> JavaToolChain->JavaToolchain, these cause problems on
> >>>> case-insensitive
> >>>>>>> filesystems, like the ones used by Windows and OSX.
> >>>>>>>
> >>>>>>> We don't distinguish between public and internal classes in Maven,
> >>>> at
> >>>>>>> least not generally. There are few classes that are explicitly
> >>>> marked as
> >>>>>>> @provisional, like ArtifactDescriptorReaderDelegate for example,
> >>>> but
> >>>>>>> this is not enforced and majority of classes are not marked in any
> >>>> way.
> >>>>>>> I agree we need to have a mechanism to distinguish between public
> >>>> and
> >>>>>>> internal classes and I have few ideas to do this, but I don't think
> >>>> we
> >>>>>>> can do this retroactively. We have to keep most/all existing
> >>>> classes and
> >>>>>>> treat them as public API, unfortunately. Maybe mark them as
> >>>> deprecated
> >>>>>>> when we know we will likely change them in the future, but any real
> >>>>>>> change has to wait Maven 4, and I am not sure we'll be able to
> >>>> afford
> >>>>>>> massive breakage even then.
> >>>>>>>
> >>>>>>> [1]
> >>>>>>
> >>>>
> >>
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
> >>>>>>>
> >>>>>>> --
> >>>>>>> Regards,
> >>>>>>> Igor
> >>>>>>>
> >>>>>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
> >>>>>>>> ok, I had a look at Tycho sources:
> >>>>>>>> this is something introduced recently (10/10/2014): IIUC, Tycho
> >>>> 0.22.0
> >>>>>> was
> >>>>>>>> released since then
> >>>>>>>>
> >>>>>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a
> >>>> rewrite
> >>>>>> of a
> >>>>>>>> part of maven-toochains-plugin, depending on
> >>>> ToolchainManagerPrivate
> >>>>>> which is
> >>>>>>>> not part of public API
> >>>>>>>> IIUC, the intent was to get the configured toolchain: since then,
> >>>> I
> >>>>>> wrote a
> >>>>>>>> little doc for that [1] to show how to use ToolchainManager to do
> >>>>>> exactly that
> >>>>>>>> using normal Maven API
> >>>>>>>>
> >>>>>>>> Notice this won't fix everything, since:
> >>>>>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
> >>>>>> ToolChain)
> >>>>>>>> 2. the interface doesn't offer expected getJavaHome() API
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Then you'll need to cast to DefaultJavaToolChain, which will need
> >>>> to be
> >>>>>> added
> >>>>>>>> back to maven-core: I'll do it immediately.
> >>>>>>>>
> >>>>>>>> I don't know the Tycho community, but using ToolchainManager would
> >>>> IMHO
> >>>>>> be
> >>>>>>>> more future-proof than writing ToolchainProvider
> >>>>>>>>
> >>>>>>>> Regards,
> >>>>>>>>
> >>>>>>>> Hervé
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> [1]
> >>>>>>
> >>>>
> >>
> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
> >>>>>>>>> DefaultJavaToolChain? you mean the implementation?
> >>>>>>>>>
> >>>>>>>>> Can you give me pointers to the Tycho sources that use this API?
> >>>>>>>>> (that's clearly not expected)
> >>>>>>>>>
> >>>>>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
> >>>>>>>>> that extends the new implementation, which is easy to do: just
> >>>> need to
> >>>>>>>>> understand how it is used in Tycho, since the class is supposed
> >>>> to be
> >>>>>> used
> >>>>>>>>> by JavaToolchainFactory (on only this one).
> >>>>>>>>>
> >>>>>>>>> Regards,
> >>>>>>>>>
> >>>>>>>>> Hervé
> >>>>>>>>>
> >>>>>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> >>>>>>>>>> Unfortunately, I have to take this back. The changes to
> >>>> toolchain
> >>>>>>>>>> broke Tycho and, short of using reflection, I don't see how
> >>>>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
> >>>> Maven.
> >>>>>>>>>>
> >>>>>>>>>> For better or worse,
> >>>>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> >>>>>>>>>> Maven API since 2.x and I don't think we can just remove the
> >>>> class.
> >>>>>>>>>>
> >>>>>>>>>> I see two ways to fix this. Either we rename the classes back,
> >>>> which
> >>>>>> is
> >>>>>>>>>> probably the easiest. Or we introduce deprecated
> >>>> DefaultJavaToolChain
> >>>>>>>>>> that extends the new implementation.
> >>>>>>>>>>
> >>>>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> Regards,
> >>>>>>>>>> Igor
> >>>>>>>>>>
> >>>>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> >>>>>>>>>>> +1
> >>>>>>>>>>>
> >>>>>>>>>>> --
> >>>>>>>>>>> Regards,
> >>>>>>>>>>> Igor
> >>>>>>>>>>>
> >>>>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> >>>>>>>>>>>> Hi,
> >>>>>>>>>>>>
> >>>>>>>>>>>> Time to release Maven 3.2.4!
> >>>>>>>>>>>>
> >>>>>>>>>>>> Here is a link to Jira with 20 issues resolved:
> >>>>>>>>>>>>
> >>>>>>
> >>>>
> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
> >>>>>>>>>>>> on
> >>>>>>>>>>>> =20574
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> Staging repo:
> >>>>>>>>>>>>
> https://repository.apache.org/content/repositories/maven-1102/
> >>>>>>>>>>>>
> >>>>>>>>>>>> The distributable binaries and sources for testing can be
> >>>> found
> >>>>>> here:
> >>>>>>>>>>>>
> >>>>>>
> >>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>>>> e/
> >>>>>>>>>>>> maven/apache-maven/3.2.4/
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> Specifically the zip, tarball, and source archives can be
> >>>> found
> >>>>>> here:
> >>>>>>>>>>>>
> >>>>>>
> >>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>>>> e/
> >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>
> >>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>>>> e/
> >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>
> >>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>>>> e/
> >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>
> >>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>>>> e/
> >>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> Source release checksum(s):
> >>>>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
> >>>>>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>>>>>>>>>>>
> >>>>>>>>>>>> Staging site:
> >>>>>>>>>>>> http://takari.io/maven-3.2.4/
> >>>>>>>>>>>>
> >>>>>>>>>>>> Vote open for 72 hours.
> >>>>>>>>>>>>
> >>>>>>>>>>>> [ ] +1
> >>>>>>>>>>>> [ ] +0
> >>>>>>>>>>>> [ ] -1
> >>>>>>>>>>>>
> >>>>>>>>>>>> Thanks,
> >>>>>>>>>>>>
> >>>>>>>>>>>> The Maven Team
> >>>>>>>>>>>>
> >>>>>>
> >>>> ---------------------------------------------------------------------
> >>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>> ---------------------------------------------------------------------
> >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>> ---------------------------------------------------------------------
> >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>>>
> >>>>>>>>>
> >>>> ---------------------------------------------------------------------
> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>> ---------------------------------------------------------------------
> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> <javascript:;>
> >>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>> ---------------------------------------------------------------------
> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> <javascript:;>
> >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>> <javascript:;>
> >>>>>>>
> >>>>>>
> >>>>>> Thanks,
> >>>>>>
> >>>>>> Jason
> >>>>>>
> >>>>>> ----------------------------------------------------------
> >>>>>> Jason van Zyl
> >>>>>> Founder, Apache Maven
> >>>>>> http://twitter.com/jvanzyl
> >>>>>> http://twitter.com/takari_io
> >>>>>> ---------------------------------------------------------
> >>>>>>
> >>>>>> The modern conservative is engaged in one of man's oldest exercises
> >>>> in
> >>>>>> moral philosophy; that is,
> >>>>>> the search for a superior moral justification for selfishness.
> >>>>>>
> >>>>>> -- John Kenneth Galbraith
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> >>>>> --
> >>>>> Sent from my phone
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Jason
> >>>>
> >>>> ----------------------------------------------------------
> >>>> Jason van Zyl
> >>>> Founder, Apache Maven
> >>>> http://twitter.com/jvanzyl
> >>>> http://twitter.com/takari_io
> >>>> ---------------------------------------------------------
> >>>>
> >>>> To think is easy. To act is hard. But the hardest thing in the world
> is
> >>>> to act in accordance with your thinking.
> >>>>
> >>>> -- Johann von Goethe
> >>>
> >>> --
> >>> Sent from my Android device with K-9 Mail. Please excuse my brevity.
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>
> >>
> >> Thanks,
> >>
> >> Jason
> >>
> >> ----------------------------------------------------------
> >> Jason van Zyl
> >> Founder, Apache Maven
> >> http://twitter.com/jvanzyl
> >> http://twitter.com/takari_io
> >> ---------------------------------------------------------
> >>
> >> Be not afraid of growing slowly, be only afraid of standing still.
> >>
> >> -- Chinese Proverb
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/takari_io
> ---------------------------------------------------------
>
> You are never dedicated to something you have complete confidence in.
> No one is fanatically shouting that the sun is going to rise tomorrow.
> They know it is going to rise tomorrow. When people are fanatically
> dedicated to political or religious faiths or any other kind of
> dogmas or goals, it's always because these dogmas or
> goals are in doubt.
>
> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
>
>
>
>
>
>
>
>
>
>
Re: [VOTE] Maven 3.2.4 Release
Posted by Jason van Zyl <ja...@takari.io>.
Documentation updated.
On Dec 13, 2014, at 5:32 PM, Jason van Zyl <ja...@takari.io> wrote:
> Sure, I never wanted to do it which is why I forgot and will likely continue to forget so I'll change the docs because I always have to look at them to figure out how to publish the site. I still think it's a inconsistent practice for the few it would inconvenience in a minor way.
>
> On Dec 13, 2014, at 5:27 PM, Paul Benedict <pb...@apache.org> wrote:
>
>> When the 3.2.0 build had a regression, we jumped to 3.2.1:
>> http://mail-archives.apache.org/mod_mbox/maven-dev/201402.mbox/%3CDF2F7F9E-9334-43D9-AA01-03733604BA6A@takari.io%3E
>>
>> Sorry I didn't provide this thread up front. It took a while to find it.
>> However, I am pretty sure we did this again with 3.2.3, but I could be
>> wrong on that fact -- I just remember we did this twice so far.
>>
>>
>> Cheers,
>> Paul
>>
>> On Sat, Dec 13, 2014 at 4:24 PM, Jason van Zyl <ja...@takari.io> wrote:
>>>
>>> I don't because it's inconsistent for external users who will be confused
>>> about where a release has gone. To date I have never skipped versions, for
>>> consistency I don't want to start now. I consider the staged releases not
>>> contributing to the public version pool.
>>>
>>> For your case I think you're probably the only person in the world who
>>> integrates a staged release of Maven. For normal testers, running Maven
>>> 3.2.4 doesn't download Maven 3.2.4 related binaries in your local repo.
>>>
>>> But even if you weren't the only person is it that hard to cleanup the
>>> punched release locally? I see the reuse of versions as being
>>> problematically negligible while the confusion for users being high.
>>>
>>> On Dec 13, 2014, at 4:42 PM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
>>>
>>>> Why? How will we tell the original broken binaries from the new ones?
>>>>
>>>> On December 13, 2014 4:01:31 PM EST, Jason van Zyl <ja...@takari.io>
>>> wrote:
>>>>> No, it will be 3.2.4.
>>>>>
>>>>> On Dec 13, 2014, at 3:52 PM, Stephen Connolly
>>>>> <st...@gmail.com> wrote:
>>>>>
>>>>>> Iirc we said not reusing version numbers after a .0 so this will be
>>>>> 3.2.5,
>>>>>> yes?
>>>>>>
>>>>>> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
>>>>> wrote:
>>>>>>
>>>>>>> The fixes have been made, I'll recut the release.
>>>>>>>
>>>>>>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
>>>>>>> <javascript:;>> wrote:
>>>>>>>
>>>>>>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy
>>>>> now
>>>>>>> [1].
>>>>>>>>
>>>>>>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to
>>>>> the
>>>>>>>> best of my knowledge, is not available from any other API, is not
>>>>>>>> available through ToolchainManager.
>>>>>>>>
>>>>>>>> I don't believe Tycho references JavaToolChain interface. As a side
>>>>>>>> note, in the future we should avoid case-only renames like
>>>>>>>> JavaToolChain->JavaToolchain, these cause problems on
>>>>> case-insensitive
>>>>>>>> filesystems, like the ones used by Windows and OSX.
>>>>>>>>
>>>>>>>> We don't distinguish between public and internal classes in Maven,
>>>>> at
>>>>>>>> least not generally. There are few classes that are explicitly
>>>>> marked as
>>>>>>>> @provisional, like ArtifactDescriptorReaderDelegate for example,
>>>>> but
>>>>>>>> this is not enforced and majority of classes are not marked in any
>>>>> way.
>>>>>>>> I agree we need to have a mechanism to distinguish between public
>>>>> and
>>>>>>>> internal classes and I have few ideas to do this, but I don't think
>>>>> we
>>>>>>>> can do this retroactively. We have to keep most/all existing
>>>>> classes and
>>>>>>>> treat them as public API, unfortunately. Maybe mark them as
>>>>> deprecated
>>>>>>>> when we know we will likely change them in the future, but any real
>>>>>>>> change has to wait Maven 4, and I am not sure we'll be able to
>>>>> afford
>>>>>>>> massive breakage even then.
>>>>>>>>
>>>>>>>> [1]
>>>>>>>
>>>>>
>>> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>> Igor
>>>>>>>>
>>>>>>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
>>>>>>>>> ok, I had a look at Tycho sources:
>>>>>>>>> this is something introduced recently (10/10/2014): IIUC, Tycho
>>>>> 0.22.0
>>>>>>> was
>>>>>>>>> released since then
>>>>>>>>>
>>>>>>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a
>>>>> rewrite
>>>>>>> of a
>>>>>>>>> part of maven-toochains-plugin, depending on
>>>>> ToolchainManagerPrivate
>>>>>>> which is
>>>>>>>>> not part of public API
>>>>>>>>> IIUC, the intent was to get the configured toolchain: since then,
>>>>> I
>>>>>>> wrote a
>>>>>>>>> little doc for that [1] to show how to use ToolchainManager to do
>>>>>>> exactly that
>>>>>>>>> using normal Maven API
>>>>>>>>>
>>>>>>>>> Notice this won't fix everything, since:
>>>>>>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
>>>>>>> ToolChain)
>>>>>>>>> 2. the interface doesn't offer expected getJavaHome() API
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Then you'll need to cast to DefaultJavaToolChain, which will need
>>>>> to be
>>>>>>> added
>>>>>>>>> back to maven-core: I'll do it immediately.
>>>>>>>>>
>>>>>>>>> I don't know the Tycho community, but using ToolchainManager would
>>>>> IMHO
>>>>>>> be
>>>>>>>>> more future-proof than writing ToolchainProvider
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>>
>>>>>>>>> Hervé
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> [1]
>>>>>>>
>>>>>
>>> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
>>>>>>>>>> DefaultJavaToolChain? you mean the implementation?
>>>>>>>>>>
>>>>>>>>>> Can you give me pointers to the Tycho sources that use this API?
>>>>>>>>>> (that's clearly not expected)
>>>>>>>>>>
>>>>>>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
>>>>>>>>>> that extends the new implementation, which is easy to do: just
>>>>> need to
>>>>>>>>>> understand how it is used in Tycho, since the class is supposed
>>>>> to be
>>>>>>> used
>>>>>>>>>> by JavaToolchainFactory (on only this one).
>>>>>>>>>>
>>>>>>>>>> Regards,
>>>>>>>>>>
>>>>>>>>>> Hervé
>>>>>>>>>>
>>>>>>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
>>>>>>>>>>> Unfortunately, I have to take this back. The changes to
>>>>> toolchain
>>>>>>>>>>> broke Tycho and, short of using reflection, I don't see how
>>>>>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
>>>>> Maven.
>>>>>>>>>>>
>>>>>>>>>>> For better or worse,
>>>>>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>>>>>>>>> Maven API since 2.x and I don't think we can just remove the
>>>>> class.
>>>>>>>>>>>
>>>>>>>>>>> I see two ways to fix this. Either we rename the classes back,
>>>>> which
>>>>>>> is
>>>>>>>>>>> probably the easiest. Or we introduce deprecated
>>>>> DefaultJavaToolChain
>>>>>>>>>>> that extends the new implementation.
>>>>>>>>>>>
>>>>>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Regards,
>>>>>>>>>>> Igor
>>>>>>>>>>>
>>>>>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>>>>>>>>> +1
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Regards,
>>>>>>>>>>>> Igor
>>>>>>>>>>>>
>>>>>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Time to release Maven 3.2.4!
>>>>>>>>>>>>>
>>>>>>>>>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>>>>>>>>>
>>>>>>>
>>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
>>>>>>>>>>>>> on
>>>>>>>>>>>>> =20574
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Staging repo:
>>>>>>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>>>>>>>>
>>>>>>>>>>>>> The distributable binaries and sources for testing can be
>>>>> found
>>>>>>> here:
>>>>>>>>>>>>>
>>>>>>>
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>>> e/
>>>>>>>>>>>>> maven/apache-maven/3.2.4/
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Specifically the zip, tarball, and source archives can be
>>>>> found
>>>>>>> here:
>>>>>>>>>>>>>
>>>>>>>
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>>> e/
>>>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>>> e/
>>>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>>> e/
>>>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>>> e/
>>>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Source release checksum(s):
>>>>>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
>>>>>>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>>>>>>>>>
>>>>>>>>>>>>> Staging site:
>>>>>>>>>>>>> http://takari.io/maven-3.2.4/
>>>>>>>>>>>>>
>>>>>>>>>>>>> Vote open for 72 hours.
>>>>>>>>>>>>>
>>>>>>>>>>>>> [ ] +1
>>>>>>>>>>>>> [ ] +0
>>>>>>>>>>>>> [ ] -1
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>
>>>>>>>>>>>>> The Maven Team
>>>>>>>>>>>>>
>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>>>
>>>>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> <javascript:;>
>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> <javascript:;>
>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>> <javascript:;>
>>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Jason
>>>>>>>
>>>>>>> ----------------------------------------------------------
>>>>>>> Jason van Zyl
>>>>>>> Founder, Apache Maven
>>>>>>> http://twitter.com/jvanzyl
>>>>>>> http://twitter.com/takari_io
>>>>>>> ---------------------------------------------------------
>>>>>>>
>>>>>>> The modern conservative is engaged in one of man's oldest exercises
>>>>> in
>>>>>>> moral philosophy; that is,
>>>>>>> the search for a superior moral justification for selfishness.
>>>>>>>
>>>>>>> -- John Kenneth Galbraith
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sent from my phone
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Jason
>>>>>
>>>>> ----------------------------------------------------------
>>>>> Jason van Zyl
>>>>> Founder, Apache Maven
>>>>> http://twitter.com/jvanzyl
>>>>> http://twitter.com/takari_io
>>>>> ---------------------------------------------------------
>>>>>
>>>>> To think is easy. To act is hard. But the hardest thing in the world is
>>>>> to act in accordance with your thinking.
>>>>>
>>>>> -- Johann von Goethe
>>>>
>>>> --
>>>> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder, Apache Maven
>>> http://twitter.com/jvanzyl
>>> http://twitter.com/takari_io
>>> ---------------------------------------------------------
>>>
>>> Be not afraid of growing slowly, be only afraid of standing still.
>>>
>>> -- Chinese Proverb
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/takari_io
> ---------------------------------------------------------
>
> You are never dedicated to something you have complete confidence in.
> No one is fanatically shouting that the sun is going to rise tomorrow.
> They know it is going to rise tomorrow. When people are fanatically
> dedicated to political or religious faiths or any other kind of
> dogmas or goals, it's always because these dogmas or
> goals are in doubt.
>
> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
>
>
>
>
>
>
>
>
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
To think is easy. To act is hard. But the hardest thing in the world is to act in accordance with your thinking.
-- Johann von Goethe
Re: [VOTE] Maven 3.2.4 Release
Posted by Jason van Zyl <ja...@takari.io>.
Sure, I never wanted to do it which is why I forgot and will likely continue to forget so I'll change the docs because I always have to look at them to figure out how to publish the site. I still think it's a inconsistent practice for the few it would inconvenience in a minor way.
On Dec 13, 2014, at 5:27 PM, Paul Benedict <pb...@apache.org> wrote:
> When the 3.2.0 build had a regression, we jumped to 3.2.1:
> http://mail-archives.apache.org/mod_mbox/maven-dev/201402.mbox/%3CDF2F7F9E-9334-43D9-AA01-03733604BA6A@takari.io%3E
>
> Sorry I didn't provide this thread up front. It took a while to find it.
> However, I am pretty sure we did this again with 3.2.3, but I could be
> wrong on that fact -- I just remember we did this twice so far.
>
>
> Cheers,
> Paul
>
> On Sat, Dec 13, 2014 at 4:24 PM, Jason van Zyl <ja...@takari.io> wrote:
>>
>> I don't because it's inconsistent for external users who will be confused
>> about where a release has gone. To date I have never skipped versions, for
>> consistency I don't want to start now. I consider the staged releases not
>> contributing to the public version pool.
>>
>> For your case I think you're probably the only person in the world who
>> integrates a staged release of Maven. For normal testers, running Maven
>> 3.2.4 doesn't download Maven 3.2.4 related binaries in your local repo.
>>
>> But even if you weren't the only person is it that hard to cleanup the
>> punched release locally? I see the reuse of versions as being
>> problematically negligible while the confusion for users being high.
>>
>> On Dec 13, 2014, at 4:42 PM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
>>
>>> Why? How will we tell the original broken binaries from the new ones?
>>>
>>> On December 13, 2014 4:01:31 PM EST, Jason van Zyl <ja...@takari.io>
>> wrote:
>>>> No, it will be 3.2.4.
>>>>
>>>> On Dec 13, 2014, at 3:52 PM, Stephen Connolly
>>>> <st...@gmail.com> wrote:
>>>>
>>>>> Iirc we said not reusing version numbers after a .0 so this will be
>>>> 3.2.5,
>>>>> yes?
>>>>>
>>>>> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
>>>> wrote:
>>>>>
>>>>>> The fixes have been made, I'll recut the release.
>>>>>>
>>>>>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
>>>>>> <javascript:;>> wrote:
>>>>>>
>>>>>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy
>>>> now
>>>>>> [1].
>>>>>>>
>>>>>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to
>>>> the
>>>>>>> best of my knowledge, is not available from any other API, is not
>>>>>>> available through ToolchainManager.
>>>>>>>
>>>>>>> I don't believe Tycho references JavaToolChain interface. As a side
>>>>>>> note, in the future we should avoid case-only renames like
>>>>>>> JavaToolChain->JavaToolchain, these cause problems on
>>>> case-insensitive
>>>>>>> filesystems, like the ones used by Windows and OSX.
>>>>>>>
>>>>>>> We don't distinguish between public and internal classes in Maven,
>>>> at
>>>>>>> least not generally. There are few classes that are explicitly
>>>> marked as
>>>>>>> @provisional, like ArtifactDescriptorReaderDelegate for example,
>>>> but
>>>>>>> this is not enforced and majority of classes are not marked in any
>>>> way.
>>>>>>> I agree we need to have a mechanism to distinguish between public
>>>> and
>>>>>>> internal classes and I have few ideas to do this, but I don't think
>>>> we
>>>>>>> can do this retroactively. We have to keep most/all existing
>>>> classes and
>>>>>>> treat them as public API, unfortunately. Maybe mark them as
>>>> deprecated
>>>>>>> when we know we will likely change them in the future, but any real
>>>>>>> change has to wait Maven 4, and I am not sure we'll be able to
>>>> afford
>>>>>>> massive breakage even then.
>>>>>>>
>>>>>>> [1]
>>>>>>
>>>>
>> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Igor
>>>>>>>
>>>>>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
>>>>>>>> ok, I had a look at Tycho sources:
>>>>>>>> this is something introduced recently (10/10/2014): IIUC, Tycho
>>>> 0.22.0
>>>>>> was
>>>>>>>> released since then
>>>>>>>>
>>>>>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a
>>>> rewrite
>>>>>> of a
>>>>>>>> part of maven-toochains-plugin, depending on
>>>> ToolchainManagerPrivate
>>>>>> which is
>>>>>>>> not part of public API
>>>>>>>> IIUC, the intent was to get the configured toolchain: since then,
>>>> I
>>>>>> wrote a
>>>>>>>> little doc for that [1] to show how to use ToolchainManager to do
>>>>>> exactly that
>>>>>>>> using normal Maven API
>>>>>>>>
>>>>>>>> Notice this won't fix everything, since:
>>>>>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
>>>>>> ToolChain)
>>>>>>>> 2. the interface doesn't offer expected getJavaHome() API
>>>>>>>>
>>>>>>>>
>>>>>>>> Then you'll need to cast to DefaultJavaToolChain, which will need
>>>> to be
>>>>>> added
>>>>>>>> back to maven-core: I'll do it immediately.
>>>>>>>>
>>>>>>>> I don't know the Tycho community, but using ToolchainManager would
>>>> IMHO
>>>>>> be
>>>>>>>> more future-proof than writing ToolchainProvider
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>>
>>>>>>>> Hervé
>>>>>>>>
>>>>>>>>
>>>>>>>> [1]
>>>>>>
>>>>
>> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
>>>>>>>>
>>>>>>>>
>>>>>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
>>>>>>>>> DefaultJavaToolChain? you mean the implementation?
>>>>>>>>>
>>>>>>>>> Can you give me pointers to the Tycho sources that use this API?
>>>>>>>>> (that's clearly not expected)
>>>>>>>>>
>>>>>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
>>>>>>>>> that extends the new implementation, which is easy to do: just
>>>> need to
>>>>>>>>> understand how it is used in Tycho, since the class is supposed
>>>> to be
>>>>>> used
>>>>>>>>> by JavaToolchainFactory (on only this one).
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>>
>>>>>>>>> Hervé
>>>>>>>>>
>>>>>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
>>>>>>>>>> Unfortunately, I have to take this back. The changes to
>>>> toolchain
>>>>>>>>>> broke Tycho and, short of using reflection, I don't see how
>>>>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
>>>> Maven.
>>>>>>>>>>
>>>>>>>>>> For better or worse,
>>>>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>>>>>>>> Maven API since 2.x and I don't think we can just remove the
>>>> class.
>>>>>>>>>>
>>>>>>>>>> I see two ways to fix this. Either we rename the classes back,
>>>> which
>>>>>> is
>>>>>>>>>> probably the easiest. Or we introduce deprecated
>>>> DefaultJavaToolChain
>>>>>>>>>> that extends the new implementation.
>>>>>>>>>>
>>>>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Regards,
>>>>>>>>>> Igor
>>>>>>>>>>
>>>>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>>>>>>>> +1
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Regards,
>>>>>>>>>>> Igor
>>>>>>>>>>>
>>>>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>> Time to release Maven 3.2.4!
>>>>>>>>>>>>
>>>>>>>>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>>>>>>>>
>>>>>>
>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
>>>>>>>>>>>> on
>>>>>>>>>>>> =20574
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Staging repo:
>>>>>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>>>>>>>
>>>>>>>>>>>> The distributable binaries and sources for testing can be
>>>> found
>>>>>> here:
>>>>>>>>>>>>
>>>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>> e/
>>>>>>>>>>>> maven/apache-maven/3.2.4/
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Specifically the zip, tarball, and source archives can be
>>>> found
>>>>>> here:
>>>>>>>>>>>>
>>>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>> e/
>>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>> e/
>>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>> e/
>>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>>>> e/
>>>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Source release checksum(s):
>>>>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
>>>>>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>>>>>>>>
>>>>>>>>>>>> Staging site:
>>>>>>>>>>>> http://takari.io/maven-3.2.4/
>>>>>>>>>>>>
>>>>>>>>>>>> Vote open for 72 hours.
>>>>>>>>>>>>
>>>>>>>>>>>> [ ] +1
>>>>>>>>>>>> [ ] +0
>>>>>>>>>>>> [ ] -1
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>
>>>>>>>>>>>> The Maven Team
>>>>>>>>>>>>
>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>>>>>
>>>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>>>>
>>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>>>
>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> <javascript:;>
>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> <javascript:;>
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>> <javascript:;>
>>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Jason
>>>>>>
>>>>>> ----------------------------------------------------------
>>>>>> Jason van Zyl
>>>>>> Founder, Apache Maven
>>>>>> http://twitter.com/jvanzyl
>>>>>> http://twitter.com/takari_io
>>>>>> ---------------------------------------------------------
>>>>>>
>>>>>> The modern conservative is engaged in one of man's oldest exercises
>>>> in
>>>>>> moral philosophy; that is,
>>>>>> the search for a superior moral justification for selfishness.
>>>>>>
>>>>>> -- John Kenneth Galbraith
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Sent from my phone
>>>>
>>>> Thanks,
>>>>
>>>> Jason
>>>>
>>>> ----------------------------------------------------------
>>>> Jason van Zyl
>>>> Founder, Apache Maven
>>>> http://twitter.com/jvanzyl
>>>> http://twitter.com/takari_io
>>>> ---------------------------------------------------------
>>>>
>>>> To think is easy. To act is hard. But the hardest thing in the world is
>>>> to act in accordance with your thinking.
>>>>
>>>> -- Johann von Goethe
>>>
>>> --
>>> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder, Apache Maven
>> http://twitter.com/jvanzyl
>> http://twitter.com/takari_io
>> ---------------------------------------------------------
>>
>> Be not afraid of growing slowly, be only afraid of standing still.
>>
>> -- Chinese Proverb
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
You are never dedicated to something you have complete confidence in.
No one is fanatically shouting that the sun is going to rise tomorrow.
They know it is going to rise tomorrow. When people are fanatically
dedicated to political or religious faiths or any other kind of
dogmas or goals, it's always because these dogmas or
goals are in doubt.
-- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
Re: [VOTE] Maven 3.2.4 Release
Posted by Paul Benedict <pb...@apache.org>.
When the 3.2.0 build had a regression, we jumped to 3.2.1:
http://mail-archives.apache.org/mod_mbox/maven-dev/201402.mbox/%3CDF2F7F9E-9334-43D9-AA01-03733604BA6A@takari.io%3E
Sorry I didn't provide this thread up front. It took a while to find it.
However, I am pretty sure we did this again with 3.2.3, but I could be
wrong on that fact -- I just remember we did this twice so far.
Cheers,
Paul
On Sat, Dec 13, 2014 at 4:24 PM, Jason van Zyl <ja...@takari.io> wrote:
>
> I don't because it's inconsistent for external users who will be confused
> about where a release has gone. To date I have never skipped versions, for
> consistency I don't want to start now. I consider the staged releases not
> contributing to the public version pool.
>
> For your case I think you're probably the only person in the world who
> integrates a staged release of Maven. For normal testers, running Maven
> 3.2.4 doesn't download Maven 3.2.4 related binaries in your local repo.
>
> But even if you weren't the only person is it that hard to cleanup the
> punched release locally? I see the reuse of versions as being
> problematically negligible while the confusion for users being high.
>
> On Dec 13, 2014, at 4:42 PM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
>
> > Why? How will we tell the original broken binaries from the new ones?
> >
> > On December 13, 2014 4:01:31 PM EST, Jason van Zyl <ja...@takari.io>
> wrote:
> >> No, it will be 3.2.4.
> >>
> >> On Dec 13, 2014, at 3:52 PM, Stephen Connolly
> >> <st...@gmail.com> wrote:
> >>
> >>> Iirc we said not reusing version numbers after a .0 so this will be
> >> 3.2.5,
> >>> yes?
> >>>
> >>> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
> >> wrote:
> >>>
> >>>> The fixes have been made, I'll recut the release.
> >>>>
> >>>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
> >>>> <javascript:;>> wrote:
> >>>>
> >>>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy
> >> now
> >>>> [1].
> >>>>>
> >>>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to
> >> the
> >>>>> best of my knowledge, is not available from any other API, is not
> >>>>> available through ToolchainManager.
> >>>>>
> >>>>> I don't believe Tycho references JavaToolChain interface. As a side
> >>>>> note, in the future we should avoid case-only renames like
> >>>>> JavaToolChain->JavaToolchain, these cause problems on
> >> case-insensitive
> >>>>> filesystems, like the ones used by Windows and OSX.
> >>>>>
> >>>>> We don't distinguish between public and internal classes in Maven,
> >> at
> >>>>> least not generally. There are few classes that are explicitly
> >> marked as
> >>>>> @provisional, like ArtifactDescriptorReaderDelegate for example,
> >> but
> >>>>> this is not enforced and majority of classes are not marked in any
> >> way.
> >>>>> I agree we need to have a mechanism to distinguish between public
> >> and
> >>>>> internal classes and I have few ideas to do this, but I don't think
> >> we
> >>>>> can do this retroactively. We have to keep most/all existing
> >> classes and
> >>>>> treat them as public API, unfortunately. Maybe mark them as
> >> deprecated
> >>>>> when we know we will likely change them in the future, but any real
> >>>>> change has to wait Maven 4, and I am not sure we'll be able to
> >> afford
> >>>>> massive breakage even then.
> >>>>>
> >>>>> [1]
> >>>>
> >>
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
> >>>>>
> >>>>> --
> >>>>> Regards,
> >>>>> Igor
> >>>>>
> >>>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
> >>>>>> ok, I had a look at Tycho sources:
> >>>>>> this is something introduced recently (10/10/2014): IIUC, Tycho
> >> 0.22.0
> >>>> was
> >>>>>> released since then
> >>>>>>
> >>>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a
> >> rewrite
> >>>> of a
> >>>>>> part of maven-toochains-plugin, depending on
> >> ToolchainManagerPrivate
> >>>> which is
> >>>>>> not part of public API
> >>>>>> IIUC, the intent was to get the configured toolchain: since then,
> >> I
> >>>> wrote a
> >>>>>> little doc for that [1] to show how to use ToolchainManager to do
> >>>> exactly that
> >>>>>> using normal Maven API
> >>>>>>
> >>>>>> Notice this won't fix everything, since:
> >>>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
> >>>> ToolChain)
> >>>>>> 2. the interface doesn't offer expected getJavaHome() API
> >>>>>>
> >>>>>>
> >>>>>> Then you'll need to cast to DefaultJavaToolChain, which will need
> >> to be
> >>>> added
> >>>>>> back to maven-core: I'll do it immediately.
> >>>>>>
> >>>>>> I don't know the Tycho community, but using ToolchainManager would
> >> IMHO
> >>>> be
> >>>>>> more future-proof than writing ToolchainProvider
> >>>>>>
> >>>>>> Regards,
> >>>>>>
> >>>>>> Hervé
> >>>>>>
> >>>>>>
> >>>>>> [1]
> >>>>
> >>
> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
> >>>>>>
> >>>>>>
> >>>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
> >>>>>>> DefaultJavaToolChain? you mean the implementation?
> >>>>>>>
> >>>>>>> Can you give me pointers to the Tycho sources that use this API?
> >>>>>>> (that's clearly not expected)
> >>>>>>>
> >>>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
> >>>>>>> that extends the new implementation, which is easy to do: just
> >> need to
> >>>>>>> understand how it is used in Tycho, since the class is supposed
> >> to be
> >>>> used
> >>>>>>> by JavaToolchainFactory (on only this one).
> >>>>>>>
> >>>>>>> Regards,
> >>>>>>>
> >>>>>>> Hervé
> >>>>>>>
> >>>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> >>>>>>>> Unfortunately, I have to take this back. The changes to
> >> toolchain
> >>>>>>>> broke Tycho and, short of using reflection, I don't see how
> >>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
> >> Maven.
> >>>>>>>>
> >>>>>>>> For better or worse,
> >>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> >>>>>>>> Maven API since 2.x and I don't think we can just remove the
> >> class.
> >>>>>>>>
> >>>>>>>> I see two ways to fix this. Either we rename the classes back,
> >> which
> >>>> is
> >>>>>>>> probably the easiest. Or we introduce deprecated
> >> DefaultJavaToolChain
> >>>>>>>> that extends the new implementation.
> >>>>>>>>
> >>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Regards,
> >>>>>>>> Igor
> >>>>>>>>
> >>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> >>>>>>>>> +1
> >>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>> Regards,
> >>>>>>>>> Igor
> >>>>>>>>>
> >>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> >>>>>>>>>> Hi,
> >>>>>>>>>>
> >>>>>>>>>> Time to release Maven 3.2.4!
> >>>>>>>>>>
> >>>>>>>>>> Here is a link to Jira with 20 issues resolved:
> >>>>>>>>>>
> >>>>
> >> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
> >>>>>>>>>> on
> >>>>>>>>>> =20574
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> Staging repo:
> >>>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
> >>>>>>>>>>
> >>>>>>>>>> The distributable binaries and sources for testing can be
> >> found
> >>>> here:
> >>>>>>>>>>
> >>>>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>> e/
> >>>>>>>>>> maven/apache-maven/3.2.4/
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> Specifically the zip, tarball, and source archives can be
> >> found
> >>>> here:
> >>>>>>>>>>
> >>>>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>> e/
> >>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>> e/
> >>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>> e/
> >>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>>>>>> e/
> >>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> Source release checksum(s):
> >>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
> >>>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>>>>>>>>>
> >>>>>>>>>> Staging site:
> >>>>>>>>>> http://takari.io/maven-3.2.4/
> >>>>>>>>>>
> >>>>>>>>>> Vote open for 72 hours.
> >>>>>>>>>>
> >>>>>>>>>> [ ] +1
> >>>>>>>>>> [ ] +0
> >>>>>>>>>> [ ] -1
> >>>>>>>>>>
> >>>>>>>>>> Thanks,
> >>>>>>>>>>
> >>>>>>>>>> The Maven Team
> >>>>>>>>>>
> >>>>
> >> ---------------------------------------------------------------------
> >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> <javascript:;>
> >>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>> <javascript:;>
> >>>>>>>>>
> >>>>>>>>>
> >> ---------------------------------------------------------------------
> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> <javascript:;>
> >>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>> <javascript:;>
> >>>>>>>>
> >>>>>>>>
> >> ---------------------------------------------------------------------
> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> <javascript:;>
> >>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>> <javascript:;>
> >>>>>>>
> >>>>>>>
> >> ---------------------------------------------------------------------
> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> <javascript:;>
> >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>> <javascript:;>
> >>>>>>
> >>>>>>
> >>>>>>
> >> ---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> <javascript:;>
> >>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>> <javascript:;>
> >>>>>>
> >>>>>
> >>>>>
> >> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> <javascript:;>
> >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>> <javascript:;>
> >>>>>
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Jason
> >>>>
> >>>> ----------------------------------------------------------
> >>>> Jason van Zyl
> >>>> Founder, Apache Maven
> >>>> http://twitter.com/jvanzyl
> >>>> http://twitter.com/takari_io
> >>>> ---------------------------------------------------------
> >>>>
> >>>> The modern conservative is engaged in one of man's oldest exercises
> >> in
> >>>> moral philosophy; that is,
> >>>> the search for a superior moral justification for selfishness.
> >>>>
> >>>> -- John Kenneth Galbraith
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>> --
> >>> Sent from my phone
> >>
> >> Thanks,
> >>
> >> Jason
> >>
> >> ----------------------------------------------------------
> >> Jason van Zyl
> >> Founder, Apache Maven
> >> http://twitter.com/jvanzyl
> >> http://twitter.com/takari_io
> >> ---------------------------------------------------------
> >>
> >> To think is easy. To act is hard. But the hardest thing in the world is
> >> to act in accordance with your thinking.
> >>
> >> -- Johann von Goethe
> >
> > --
> > Sent from my Android device with K-9 Mail. Please excuse my brevity.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/takari_io
> ---------------------------------------------------------
>
> Be not afraid of growing slowly, be only afraid of standing still.
>
> -- Chinese Proverb
>
>
>
>
>
>
>
>
>
>
Re: [VOTE] Maven 3.2.4 Release
Posted by Jason van Zyl <ja...@takari.io>.
I don't because it's inconsistent for external users who will be confused about where a release has gone. To date I have never skipped versions, for consistency I don't want to start now. I consider the staged releases not contributing to the public version pool.
For your case I think you're probably the only person in the world who integrates a staged release of Maven. For normal testers, running Maven 3.2.4 doesn't download Maven 3.2.4 related binaries in your local repo.
But even if you weren't the only person is it that hard to cleanup the punched release locally? I see the reuse of versions as being problematically negligible while the confusion for users being high.
On Dec 13, 2014, at 4:42 PM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
> Why? How will we tell the original broken binaries from the new ones?
>
> On December 13, 2014 4:01:31 PM EST, Jason van Zyl <ja...@takari.io> wrote:
>> No, it will be 3.2.4.
>>
>> On Dec 13, 2014, at 3:52 PM, Stephen Connolly
>> <st...@gmail.com> wrote:
>>
>>> Iirc we said not reusing version numbers after a .0 so this will be
>> 3.2.5,
>>> yes?
>>>
>>> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
>> wrote:
>>>
>>>> The fixes have been made, I'll recut the release.
>>>>
>>>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
>>>> <javascript:;>> wrote:
>>>>
>>>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy
>> now
>>>> [1].
>>>>>
>>>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to
>> the
>>>>> best of my knowledge, is not available from any other API, is not
>>>>> available through ToolchainManager.
>>>>>
>>>>> I don't believe Tycho references JavaToolChain interface. As a side
>>>>> note, in the future we should avoid case-only renames like
>>>>> JavaToolChain->JavaToolchain, these cause problems on
>> case-insensitive
>>>>> filesystems, like the ones used by Windows and OSX.
>>>>>
>>>>> We don't distinguish between public and internal classes in Maven,
>> at
>>>>> least not generally. There are few classes that are explicitly
>> marked as
>>>>> @provisional, like ArtifactDescriptorReaderDelegate for example,
>> but
>>>>> this is not enforced and majority of classes are not marked in any
>> way.
>>>>> I agree we need to have a mechanism to distinguish between public
>> and
>>>>> internal classes and I have few ideas to do this, but I don't think
>> we
>>>>> can do this retroactively. We have to keep most/all existing
>> classes and
>>>>> treat them as public API, unfortunately. Maybe mark them as
>> deprecated
>>>>> when we know we will likely change them in the future, but any real
>>>>> change has to wait Maven 4, and I am not sure we'll be able to
>> afford
>>>>> massive breakage even then.
>>>>>
>>>>> [1]
>>>>
>> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Igor
>>>>>
>>>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
>>>>>> ok, I had a look at Tycho sources:
>>>>>> this is something introduced recently (10/10/2014): IIUC, Tycho
>> 0.22.0
>>>> was
>>>>>> released since then
>>>>>>
>>>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a
>> rewrite
>>>> of a
>>>>>> part of maven-toochains-plugin, depending on
>> ToolchainManagerPrivate
>>>> which is
>>>>>> not part of public API
>>>>>> IIUC, the intent was to get the configured toolchain: since then,
>> I
>>>> wrote a
>>>>>> little doc for that [1] to show how to use ToolchainManager to do
>>>> exactly that
>>>>>> using normal Maven API
>>>>>>
>>>>>> Notice this won't fix everything, since:
>>>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
>>>> ToolChain)
>>>>>> 2. the interface doesn't offer expected getJavaHome() API
>>>>>>
>>>>>>
>>>>>> Then you'll need to cast to DefaultJavaToolChain, which will need
>> to be
>>>> added
>>>>>> back to maven-core: I'll do it immediately.
>>>>>>
>>>>>> I don't know the Tycho community, but using ToolchainManager would
>> IMHO
>>>> be
>>>>>> more future-proof than writing ToolchainProvider
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Hervé
>>>>>>
>>>>>>
>>>>>> [1]
>>>>
>> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
>>>>>>
>>>>>>
>>>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
>>>>>>> DefaultJavaToolChain? you mean the implementation?
>>>>>>>
>>>>>>> Can you give me pointers to the Tycho sources that use this API?
>>>>>>> (that's clearly not expected)
>>>>>>>
>>>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
>>>>>>> that extends the new implementation, which is easy to do: just
>> need to
>>>>>>> understand how it is used in Tycho, since the class is supposed
>> to be
>>>> used
>>>>>>> by JavaToolchainFactory (on only this one).
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>> Hervé
>>>>>>>
>>>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
>>>>>>>> Unfortunately, I have to take this back. The changes to
>> toolchain
>>>>>>>> broke Tycho and, short of using reflection, I don't see how
>>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
>> Maven.
>>>>>>>>
>>>>>>>> For better or worse,
>>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>>>>>> Maven API since 2.x and I don't think we can just remove the
>> class.
>>>>>>>>
>>>>>>>> I see two ways to fix this. Either we rename the classes back,
>> which
>>>> is
>>>>>>>> probably the easiest. Or we introduce deprecated
>> DefaultJavaToolChain
>>>>>>>> that extends the new implementation.
>>>>>>>>
>>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>> Igor
>>>>>>>>
>>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>>>>>> +1
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Regards,
>>>>>>>>> Igor
>>>>>>>>>
>>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> Time to release Maven 3.2.4!
>>>>>>>>>>
>>>>>>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>>>>>>
>>>>
>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
>>>>>>>>>> on
>>>>>>>>>> =20574
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Staging repo:
>>>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>>>>>
>>>>>>>>>> The distributable binaries and sources for testing can be
>> found
>>>> here:
>>>>>>>>>>
>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>> e/
>>>>>>>>>> maven/apache-maven/3.2.4/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Specifically the zip, tarball, and source archives can be
>> found
>>>> here:
>>>>>>>>>>
>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>> e/
>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>>>>>>
>>>>>>>>>>
>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>> e/
>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>>>>>>
>>>>>>>>>>
>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>> e/
>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>>>>>>
>>>>>>>>>>
>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>>> e/
>>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Source release checksum(s):
>>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
>>>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>>>>>>
>>>>>>>>>> Staging site:
>>>>>>>>>> http://takari.io/maven-3.2.4/
>>>>>>>>>>
>>>>>>>>>> Vote open for 72 hours.
>>>>>>>>>>
>>>>>>>>>> [ ] +1
>>>>>>>>>> [ ] +0
>>>>>>>>>> [ ] -1
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>>
>>>>>>>>>> The Maven Team
>>>>>>>>>>
>>>>
>> ---------------------------------------------------------------------
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> <javascript:;>
>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>> <javascript:;>
>>>>>>>>>
>>>>>>>>>
>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> <javascript:;>
>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>> <javascript:;>
>>>>>>>>
>>>>>>>>
>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> <javascript:;>
>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>> <javascript:;>
>>>>>>>
>>>>>>>
>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> <javascript:;>
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>> <javascript:;>
>>>>>>
>>>>>>
>>>>>>
>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> <javascript:;>
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>> <javascript:;>
>>>>>>
>>>>>
>>>>>
>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> <javascript:;>
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>> <javascript:;>
>>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Jason
>>>>
>>>> ----------------------------------------------------------
>>>> Jason van Zyl
>>>> Founder, Apache Maven
>>>> http://twitter.com/jvanzyl
>>>> http://twitter.com/takari_io
>>>> ---------------------------------------------------------
>>>>
>>>> The modern conservative is engaged in one of man's oldest exercises
>> in
>>>> moral philosophy; that is,
>>>> the search for a superior moral justification for selfishness.
>>>>
>>>> -- John Kenneth Galbraith
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> --
>>> Sent from my phone
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder, Apache Maven
>> http://twitter.com/jvanzyl
>> http://twitter.com/takari_io
>> ---------------------------------------------------------
>>
>> To think is easy. To act is hard. But the hardest thing in the world is
>> to act in accordance with your thinking.
>>
>> -- Johann von Goethe
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
Be not afraid of growing slowly, be only afraid of standing still.
-- Chinese Proverb
Re: [VOTE] Maven 3.2.4 Release
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
Why? How will we tell the original broken binaries from the new ones?
On December 13, 2014 4:01:31 PM EST, Jason van Zyl <ja...@takari.io> wrote:
>No, it will be 3.2.4.
>
>On Dec 13, 2014, at 3:52 PM, Stephen Connolly
><st...@gmail.com> wrote:
>
>> Iirc we said not reusing version numbers after a .0 so this will be
>3.2.5,
>> yes?
>>
>> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io>
>wrote:
>>
>>> The fixes have been made, I'll recut the release.
>>>
>>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
>>> <javascript:;>> wrote:
>>>
>>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy
>now
>>> [1].
>>>>
>>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to
>the
>>>> best of my knowledge, is not available from any other API, is not
>>>> available through ToolchainManager.
>>>>
>>>> I don't believe Tycho references JavaToolChain interface. As a side
>>>> note, in the future we should avoid case-only renames like
>>>> JavaToolChain->JavaToolchain, these cause problems on
>case-insensitive
>>>> filesystems, like the ones used by Windows and OSX.
>>>>
>>>> We don't distinguish between public and internal classes in Maven,
>at
>>>> least not generally. There are few classes that are explicitly
>marked as
>>>> @provisional, like ArtifactDescriptorReaderDelegate for example,
>but
>>>> this is not enforced and majority of classes are not marked in any
>way.
>>>> I agree we need to have a mechanism to distinguish between public
>and
>>>> internal classes and I have few ideas to do this, but I don't think
>we
>>>> can do this retroactively. We have to keep most/all existing
>classes and
>>>> treat them as public API, unfortunately. Maybe mark them as
>deprecated
>>>> when we know we will likely change them in the future, but any real
>>>> change has to wait Maven 4, and I am not sure we'll be able to
>afford
>>>> massive breakage even then.
>>>>
>>>> [1]
>>>
>https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
>>>>
>>>> --
>>>> Regards,
>>>> Igor
>>>>
>>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
>>>>> ok, I had a look at Tycho sources:
>>>>> this is something introduced recently (10/10/2014): IIUC, Tycho
>0.22.0
>>> was
>>>>> released since then
>>>>>
>>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a
>rewrite
>>> of a
>>>>> part of maven-toochains-plugin, depending on
>ToolchainManagerPrivate
>>> which is
>>>>> not part of public API
>>>>> IIUC, the intent was to get the configured toolchain: since then,
>I
>>> wrote a
>>>>> little doc for that [1] to show how to use ToolchainManager to do
>>> exactly that
>>>>> using normal Maven API
>>>>>
>>>>> Notice this won't fix everything, since:
>>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
>>> ToolChain)
>>>>> 2. the interface doesn't offer expected getJavaHome() API
>>>>>
>>>>>
>>>>> Then you'll need to cast to DefaultJavaToolChain, which will need
>to be
>>> added
>>>>> back to maven-core: I'll do it immediately.
>>>>>
>>>>> I don't know the Tycho community, but using ToolchainManager would
>IMHO
>>> be
>>>>> more future-proof than writing ToolchainProvider
>>>>>
>>>>> Regards,
>>>>>
>>>>> Hervé
>>>>>
>>>>>
>>>>> [1]
>>>
>http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
>>>>>
>>>>>
>>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
>>>>>> DefaultJavaToolChain? you mean the implementation?
>>>>>>
>>>>>> Can you give me pointers to the Tycho sources that use this API?
>>>>>> (that's clearly not expected)
>>>>>>
>>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
>>>>>> that extends the new implementation, which is easy to do: just
>need to
>>>>>> understand how it is used in Tycho, since the class is supposed
>to be
>>> used
>>>>>> by JavaToolchainFactory (on only this one).
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Hervé
>>>>>>
>>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
>>>>>>> Unfortunately, I have to take this back. The changes to
>toolchain
>>>>>>> broke Tycho and, short of using reflection, I don't see how
>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of
>Maven.
>>>>>>>
>>>>>>> For better or worse,
>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>>>>> Maven API since 2.x and I don't think we can just remove the
>class.
>>>>>>>
>>>>>>> I see two ways to fix this. Either we rename the classes back,
>which
>>> is
>>>>>>> probably the easiest. Or we introduce deprecated
>DefaultJavaToolChain
>>>>>>> that extends the new implementation.
>>>>>>>
>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Igor
>>>>>>>
>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>>>>> +1
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>> Igor
>>>>>>>>
>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Time to release Maven 3.2.4!
>>>>>>>>>
>>>>>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>>>>>
>>>
>https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
>>>>>>>>> on
>>>>>>>>> =20574
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Staging repo:
>>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>>>>
>>>>>>>>> The distributable binaries and sources for testing can be
>found
>>> here:
>>>>>>>>>
>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>> e/
>>>>>>>>> maven/apache-maven/3.2.4/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Specifically the zip, tarball, and source archives can be
>found
>>> here:
>>>>>>>>>
>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>> e/
>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>>>>>
>>>>>>>>>
>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>> e/
>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>>>>>
>>>>>>>>>
>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>> e/
>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>>>>>
>>>>>>>>>
>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>>> e/
>>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Source release checksum(s):
>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
>>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>>>>>
>>>>>>>>> Staging site:
>>>>>>>>> http://takari.io/maven-3.2.4/
>>>>>>>>>
>>>>>>>>> Vote open for 72 hours.
>>>>>>>>>
>>>>>>>>> [ ] +1
>>>>>>>>> [ ] +0
>>>>>>>>> [ ] -1
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>>
>>>>>>>>> The Maven Team
>>>>>>>>>
>>>
>---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> <javascript:;>
>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>> <javascript:;>
>>>>>>>>
>>>>>>>>
>---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> <javascript:;>
>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>> <javascript:;>
>>>>>>>
>>>>>>>
>---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> <javascript:;>
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>> <javascript:;>
>>>>>>
>>>>>>
>---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> <javascript:;>
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>> <javascript:;>
>>>>>
>>>>>
>>>>>
>---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
><javascript:;>
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>> <javascript:;>
>>>>>
>>>>
>>>>
>---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
><javascript:;>
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>> <javascript:;>
>>>>
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder, Apache Maven
>>> http://twitter.com/jvanzyl
>>> http://twitter.com/takari_io
>>> ---------------------------------------------------------
>>>
>>> The modern conservative is engaged in one of man's oldest exercises
>in
>>> moral philosophy; that is,
>>> the search for a superior moral justification for selfishness.
>>>
>>> -- John Kenneth Galbraith
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>> --
>> Sent from my phone
>
>Thanks,
>
>Jason
>
>----------------------------------------------------------
>Jason van Zyl
>Founder, Apache Maven
>http://twitter.com/jvanzyl
>http://twitter.com/takari_io
>---------------------------------------------------------
>
>To think is easy. To act is hard. But the hardest thing in the world is
>to act in accordance with your thinking.
>
> -- Johann von Goethe
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Jason van Zyl <ja...@takari.io>.
No, it will be 3.2.4.
On Dec 13, 2014, at 3:52 PM, Stephen Connolly <st...@gmail.com> wrote:
> Iirc we said not reusing version numbers after a .0 so this will be 3.2.5,
> yes?
>
> On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io> wrote:
>
>> The fixes have been made, I'll recut the release.
>>
>> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
>> <javascript:;>> wrote:
>>
>>> I've already reintroduced DefaultJavaToolChain and Tycho is happy now
>> [1].
>>>
>>> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to the
>>> best of my knowledge, is not available from any other API, is not
>>> available through ToolchainManager.
>>>
>>> I don't believe Tycho references JavaToolChain interface. As a side
>>> note, in the future we should avoid case-only renames like
>>> JavaToolChain->JavaToolchain, these cause problems on case-insensitive
>>> filesystems, like the ones used by Windows and OSX.
>>>
>>> We don't distinguish between public and internal classes in Maven, at
>>> least not generally. There are few classes that are explicitly marked as
>>> @provisional, like ArtifactDescriptorReaderDelegate for example, but
>>> this is not enforced and majority of classes are not marked in any way.
>>> I agree we need to have a mechanism to distinguish between public and
>>> internal classes and I have few ideas to do this, but I don't think we
>>> can do this retroactively. We have to keep most/all existing classes and
>>> treat them as public API, unfortunately. Maybe mark them as deprecated
>>> when we know we will likely change them in the future, but any real
>>> change has to wait Maven 4, and I am not sure we'll be able to afford
>>> massive breakage even then.
>>>
>>> [1]
>> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
>>>
>>> --
>>> Regards,
>>> Igor
>>>
>>> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
>>>> ok, I had a look at Tycho sources:
>>>> this is something introduced recently (10/10/2014): IIUC, Tycho 0.22.0
>> was
>>>> released since then
>>>>
>>>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a rewrite
>> of a
>>>> part of maven-toochains-plugin, depending on ToolchainManagerPrivate
>> which is
>>>> not part of public API
>>>> IIUC, the intent was to get the configured toolchain: since then, I
>> wrote a
>>>> little doc for that [1] to show how to use ToolchainManager to do
>> exactly that
>>>> using normal Maven API
>>>>
>>>> Notice this won't fix everything, since:
>>>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
>> ToolChain)
>>>> 2. the interface doesn't offer expected getJavaHome() API
>>>>
>>>>
>>>> Then you'll need to cast to DefaultJavaToolChain, which will need to be
>> added
>>>> back to maven-core: I'll do it immediately.
>>>>
>>>> I don't know the Tycho community, but using ToolchainManager would IMHO
>> be
>>>> more future-proof than writing ToolchainProvider
>>>>
>>>> Regards,
>>>>
>>>> Hervé
>>>>
>>>>
>>>> [1]
>> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
>>>>
>>>>
>>>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
>>>>> DefaultJavaToolChain? you mean the implementation?
>>>>>
>>>>> Can you give me pointers to the Tycho sources that use this API?
>>>>> (that's clearly not expected)
>>>>>
>>>>> I'm in favor of introducing deprecated DefaultJavaToolChain
>>>>> that extends the new implementation, which is easy to do: just need to
>>>>> understand how it is used in Tycho, since the class is supposed to be
>> used
>>>>> by JavaToolchainFactory (on only this one).
>>>>>
>>>>> Regards,
>>>>>
>>>>> Hervé
>>>>>
>>>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
>>>>>> Unfortunately, I have to take this back. The changes to toolchain
>>>>>> broke Tycho and, short of using reflection, I don't see how
>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>>>>>>
>>>>>> For better or worse,
>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>>>> Maven API since 2.x and I don't think we can just remove the class.
>>>>>>
>>>>>> I see two ways to fix this. Either we rename the classes back, which
>> is
>>>>>> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
>>>>>> that extends the new implementation.
>>>>>>
>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Igor
>>>>>>
>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>>>> +1
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Igor
>>>>>>>
>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Time to release Maven 3.2.4!
>>>>>>>>
>>>>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>>>>
>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
>>>>>>>> on
>>>>>>>> =20574
>>>>>>>>
>>>>>>>>
>>>>>>>> Staging repo:
>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>>>
>>>>>>>> The distributable binaries and sources for testing can be found
>> here:
>>>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>> e/
>>>>>>>> maven/apache-maven/3.2.4/
>>>>>>>>
>>>>>>>>
>>>>>>>> Specifically the zip, tarball, and source archives can be found
>> here:
>>>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>> e/
>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>>>>
>>>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>> e/
>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>>>>
>>>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>> e/
>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>>>>
>>>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>>>> e/
>>>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>>>>
>>>>>>>>
>>>>>>>> Source release checksum(s):
>>>>>>>> apache-maven-3.2.4-src.zip sha1:
>>>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>>>>
>>>>>>>> Staging site:
>>>>>>>> http://takari.io/maven-3.2.4/
>>>>>>>>
>>>>>>>> Vote open for 72 hours.
>>>>>>>>
>>>>>>>> [ ] +1
>>>>>>>> [ ] +0
>>>>>>>> [ ] -1
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> The Maven Team
>>>>>>>>
>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> <javascript:;>
>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>> <javascript:;>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> <javascript:;>
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>> <javascript:;>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> <javascript:;>
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>> <javascript:;>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> <javascript:;>
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>> <javascript:;>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org <javascript:;>
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>> <javascript:;>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org <javascript:;>
>>> For additional commands, e-mail: dev-help@maven.apache.org
>> <javascript:;>
>>>
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder, Apache Maven
>> http://twitter.com/jvanzyl
>> http://twitter.com/takari_io
>> ---------------------------------------------------------
>>
>> The modern conservative is engaged in one of man's oldest exercises in
>> moral philosophy; that is,
>> the search for a superior moral justification for selfishness.
>>
>> -- John Kenneth Galbraith
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
> --
> Sent from my phone
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
To think is easy. To act is hard. But the hardest thing in the world is to act in accordance with your thinking.
-- Johann von Goethe
Re: [VOTE] Maven 3.2.4 Release
Posted by Stephen Connolly <st...@gmail.com>.
Iirc we said not reusing version numbers after a .0 so this will be 3.2.5,
yes?
On Saturday, December 13, 2014, Jason van Zyl <ja...@takari.io> wrote:
> The fixes have been made, I'll recut the release.
>
> On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <igor@ifedorenko.com
> <javascript:;>> wrote:
>
> > I've already reintroduced DefaultJavaToolChain and Tycho is happy now
> [1].
> >
> > Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to the
> > best of my knowledge, is not available from any other API, is not
> > available through ToolchainManager.
> >
> > I don't believe Tycho references JavaToolChain interface. As a side
> > note, in the future we should avoid case-only renames like
> > JavaToolChain->JavaToolchain, these cause problems on case-insensitive
> > filesystems, like the ones used by Windows and OSX.
> >
> > We don't distinguish between public and internal classes in Maven, at
> > least not generally. There are few classes that are explicitly marked as
> > @provisional, like ArtifactDescriptorReaderDelegate for example, but
> > this is not enforced and majority of classes are not marked in any way.
> > I agree we need to have a mechanism to distinguish between public and
> > internal classes and I have few ideas to do this, but I don't think we
> > can do this retroactively. We have to keep most/all existing classes and
> > treat them as public API, unfortunately. Maybe mark them as deprecated
> > when we know we will likely change them in the future, but any real
> > change has to wait Maven 4, and I am not sure we'll be able to afford
> > massive breakage even then.
> >
> > [1]
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
> >
> > --
> > Regards,
> > Igor
> >
> > On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
> >> ok, I had a look at Tycho sources:
> >> this is something introduced recently (10/10/2014): IIUC, Tycho 0.22.0
> was
> >> released since then
> >>
> >> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a rewrite
> of a
> >> part of maven-toochains-plugin, depending on ToolchainManagerPrivate
> which is
> >> not part of public API
> >> IIUC, the intent was to get the configured toolchain: since then, I
> wrote a
> >> little doc for that [1] to show how to use ToolchainManager to do
> exactly that
> >> using normal Maven API
> >>
> >> Notice this won't fix everything, since:
> >> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs
> ToolChain)
> >> 2. the interface doesn't offer expected getJavaHome() API
> >>
> >>
> >> Then you'll need to cast to DefaultJavaToolChain, which will need to be
> added
> >> back to maven-core: I'll do it immediately.
> >>
> >> I don't know the Tycho community, but using ToolchainManager would IMHO
> be
> >> more future-proof than writing ToolchainProvider
> >>
> >> Regards,
> >>
> >> Hervé
> >>
> >>
> >> [1]
> http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
> >>
> >>
> >> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
> >>> DefaultJavaToolChain? you mean the implementation?
> >>>
> >>> Can you give me pointers to the Tycho sources that use this API?
> >>> (that's clearly not expected)
> >>>
> >>> I'm in favor of introducing deprecated DefaultJavaToolChain
> >>> that extends the new implementation, which is easy to do: just need to
> >>> understand how it is used in Tycho, since the class is supposed to be
> used
> >>> by JavaToolchainFactory (on only this one).
> >>>
> >>> Regards,
> >>>
> >>> Hervé
> >>>
> >>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> >>>> Unfortunately, I have to take this back. The changes to toolchain
> >>>> broke Tycho and, short of using reflection, I don't see how
> >>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
> >>>>
> >>>> For better or worse,
> >>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> >>>> Maven API since 2.x and I don't think we can just remove the class.
> >>>>
> >>>> I see two ways to fix this. Either we rename the classes back, which
> is
> >>>> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
> >>>> that extends the new implementation.
> >>>>
> >>>> Here is my -1 for releasing 3.2.4 in its current state.
> >>>>
> >>>> --
> >>>> Regards,
> >>>> Igor
> >>>>
> >>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> >>>>> +1
> >>>>>
> >>>>> --
> >>>>> Regards,
> >>>>> Igor
> >>>>>
> >>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>> Time to release Maven 3.2.4!
> >>>>>>
> >>>>>> Here is a link to Jira with 20 issues resolved:
> >>>>>>
> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
> >>>>>> on
> >>>>>> =20574
> >>>>>>
> >>>>>>
> >>>>>> Staging repo:
> >>>>>> https://repository.apache.org/content/repositories/maven-1102/
> >>>>>>
> >>>>>> The distributable binaries and sources for testing can be found
> here:
> >>>>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/
> >>>>>>
> >>>>>>
> >>>>>> Specifically the zip, tarball, and source archives can be found
> here:
> >>>>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>>>>>
> >>>>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>>>>>
> >>>>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>>>>>
> >>>>>>
> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>>>> e/
> >>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> >>>>>>
> >>>>>>
> >>>>>> Source release checksum(s):
> >>>>>> apache-maven-3.2.4-src.zip sha1:
> >>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>>>>>
> >>>>>> Staging site:
> >>>>>> http://takari.io/maven-3.2.4/
> >>>>>>
> >>>>>> Vote open for 72 hours.
> >>>>>>
> >>>>>> [ ] +1
> >>>>>> [ ] +0
> >>>>>> [ ] -1
> >>>>>>
> >>>>>> Thanks,
> >>>>>>
> >>>>>> The Maven Team
> >>>>>>
> ---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> <javascript:;>
> >>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> <javascript:;>
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> <javascript:;>
> >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> <javascript:;>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> <javascript:;>
> >>>> For additional commands, e-mail: dev-help@maven.apache.org
> <javascript:;>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> <javascript:;>
> >>> For additional commands, e-mail: dev-help@maven.apache.org
> <javascript:;>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org <javascript:;>
> >> For additional commands, e-mail: dev-help@maven.apache.org
> <javascript:;>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org <javascript:;>
> > For additional commands, e-mail: dev-help@maven.apache.org
> <javascript:;>
> >
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/takari_io
> ---------------------------------------------------------
>
> The modern conservative is engaged in one of man's oldest exercises in
> moral philosophy; that is,
> the search for a superior moral justification for selfishness.
>
> -- John Kenneth Galbraith
>
>
>
>
>
>
>
>
>
>
--
Sent from my phone
Re: [VOTE] Maven 3.2.4 Release
Posted by Jason van Zyl <ja...@takari.io>.
The fixes have been made, I'll recut the release.
On Dec 13, 2014, at 9:44 AM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
> I've already reintroduced DefaultJavaToolChain and Tycho is happy now [1].
>
> Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to the
> best of my knowledge, is not available from any other API, is not
> available through ToolchainManager.
>
> I don't believe Tycho references JavaToolChain interface. As a side
> note, in the future we should avoid case-only renames like
> JavaToolChain->JavaToolchain, these cause problems on case-insensitive
> filesystems, like the ones used by Windows and OSX.
>
> We don't distinguish between public and internal classes in Maven, at
> least not generally. There are few classes that are explicitly marked as
> @provisional, like ArtifactDescriptorReaderDelegate for example, but
> this is not enforced and majority of classes are not marked in any way.
> I agree we need to have a mechanism to distinguish between public and
> internal classes and I have few ideas to do this, but I don't think we
> can do this retroactively. We have to keep most/all existing classes and
> treat them as public API, unfortunately. Maybe mark them as deprecated
> when we know we will likely change them in the future, but any real
> change has to wait Maven 4, and I am not sure we'll be able to afford
> massive breakage even then.
>
> [1] https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
>
> --
> Regards,
> Igor
>
> On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
>> ok, I had a look at Tycho sources:
>> this is something introduced recently (10/10/2014): IIUC, Tycho 0.22.0 was
>> released since then
>>
>> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a rewrite of a
>> part of maven-toochains-plugin, depending on ToolchainManagerPrivate which is
>> not part of public API
>> IIUC, the intent was to get the configured toolchain: since then, I wrote a
>> little doc for that [1] to show how to use ToolchainManager to do exactly that
>> using normal Maven API
>>
>> Notice this won't fix everything, since:
>> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs ToolChain)
>> 2. the interface doesn't offer expected getJavaHome() API
>>
>>
>> Then you'll need to cast to DefaultJavaToolChain, which will need to be added
>> back to maven-core: I'll do it immediately.
>>
>> I don't know the Tycho community, but using ToolchainManager would IMHO be
>> more future-proof than writing ToolchainProvider
>>
>> Regards,
>>
>> Hervé
>>
>>
>> [1] http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
>>
>>
>> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
>>> DefaultJavaToolChain? you mean the implementation?
>>>
>>> Can you give me pointers to the Tycho sources that use this API?
>>> (that's clearly not expected)
>>>
>>> I'm in favor of introducing deprecated DefaultJavaToolChain
>>> that extends the new implementation, which is easy to do: just need to
>>> understand how it is used in Tycho, since the class is supposed to be used
>>> by JavaToolchainFactory (on only this one).
>>>
>>> Regards,
>>>
>>> Hervé
>>>
>>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
>>>> Unfortunately, I have to take this back. The changes to toolchain
>>>> broke Tycho and, short of using reflection, I don't see how
>>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>>>>
>>>> For better or worse,
>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>> Maven API since 2.x and I don't think we can just remove the class.
>>>>
>>>> I see two ways to fix this. Either we rename the classes back, which is
>>>> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
>>>> that extends the new implementation.
>>>>
>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>
>>>> --
>>>> Regards,
>>>> Igor
>>>>
>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>> +1
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Igor
>>>>>
>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Time to release Maven 3.2.4!
>>>>>>
>>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
>>>>>> on
>>>>>> =20574
>>>>>>
>>>>>>
>>>>>> Staging repo:
>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>
>>>>>> The distributable binaries and sources for testing can be found here:
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/
>>>>>>
>>>>>>
>>>>>> Specifically the zip, tarball, and source archives can be found here:
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>>
>>>>>>
>>>>>> Source release checksum(s):
>>>>>> apache-maven-3.2.4-src.zip sha1:
>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>>
>>>>>> Staging site:
>>>>>> http://takari.io/maven-3.2.4/
>>>>>>
>>>>>> Vote open for 72 hours.
>>>>>>
>>>>>> [ ] +1
>>>>>> [ ] +0
>>>>>> [ ] -1
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> The Maven Team
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
The modern conservative is engaged in one of man's oldest exercises in moral philosophy; that is,
the search for a superior moral justification for selfishness.
-- John Kenneth Galbraith
Re: [VOTE] Maven 3.2.4 Release
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
I've already reintroduced DefaultJavaToolChain and Tycho is happy now [1].
Tycho needs access to DefaultJavaToolChain#getJavaHome() which, to the
best of my knowledge, is not available from any other API, is not
available through ToolchainManager.
I don't believe Tycho references JavaToolChain interface. As a side
note, in the future we should avoid case-only renames like
JavaToolChain->JavaToolchain, these cause problems on case-insensitive
filesystems, like the ones used by Windows and OSX.
We don't distinguish between public and internal classes in Maven, at
least not generally. There are few classes that are explicitly marked as
@provisional, like ArtifactDescriptorReaderDelegate for example, but
this is not enforced and majority of classes are not marked in any way.
I agree we need to have a mechanism to distinguish between public and
internal classes and I have few ideas to do this, but I don't think we
can do this retroactively. We have to keep most/all existing classes and
treat them as public API, unfortunately. Maybe mark them as deprecated
when we know we will likely change them in the future, but any real
change has to wait Maven 4, and I am not sure we'll be able to afford
massive breakage even then.
[1]
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=d6e45a5d56ab0facd36751ccee722db6a2006f50
--
Regards,
Igor
On 2014-12-13, 9:04, Hervé BOUTEMY wrote:
> ok, I had a look at Tycho sources:
> this is something introduced recently (10/10/2014): IIUC, Tycho 0.22.0 was
> released since then
>
> I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a rewrite of a
> part of maven-toochains-plugin, depending on ToolchainManagerPrivate which is
> not part of public API
> IIUC, the intent was to get the configured toolchain: since then, I wrote a
> little doc for that [1] to show how to use ToolchainManager to do exactly that
> using normal Maven API
>
> Notice this won't fix everything, since:
> 1. Tycho needs JavaToochain, which has been renamed (Toolchain vs ToolChain)
> 2. the interface doesn't offer expected getJavaHome() API
>
>
> Then you'll need to cast to DefaultJavaToolChain, which will need to be added
> back to maven-core: I'll do it immediately.
>
> I don't know the Tycho community, but using ToolchainManager would IMHO be
> more future-proof than writing ToolchainProvider
>
> Regards,
>
> Hervé
>
>
> [1] http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
>
>
> Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
>> DefaultJavaToolChain? you mean the implementation?
>>
>> Can you give me pointers to the Tycho sources that use this API?
>> (that's clearly not expected)
>>
>> I'm in favor of introducing deprecated DefaultJavaToolChain
>> that extends the new implementation, which is easy to do: just need to
>> understand how it is used in Tycho, since the class is supposed to be used
>> by JavaToolchainFactory (on only this one).
>>
>> Regards,
>>
>> Hervé
>>
>> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
>>> Unfortunately, I have to take this back. The changes to toolchain
>>> broke Tycho and, short of using reflection, I don't see how
>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>>>
>>> For better or worse,
>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>> Maven API since 2.x and I don't think we can just remove the class.
>>>
>>> I see two ways to fix this. Either we rename the classes back, which is
>>> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
>>> that extends the new implementation.
>>>
>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>
>>> --
>>> Regards,
>>> Igor
>>>
>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>> +1
>>>>
>>>> --
>>>> Regards,
>>>> Igor
>>>>
>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>> Hi,
>>>>>
>>>>> Time to release Maven 3.2.4!
>>>>>
>>>>> Here is a link to Jira with 20 issues resolved:
>>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
>>>>> on
>>>>> =20574
>>>>>
>>>>>
>>>>> Staging repo:
>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>
>>>>> The distributable binaries and sources for testing can be found here:
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>> e/
>>>>> maven/apache-maven/3.2.4/
>>>>>
>>>>>
>>>>> Specifically the zip, tarball, and source archives can be found here:
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>> e/
>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>> e/
>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>> e/
>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>
>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>> e/
>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>
>>>>>
>>>>> Source release checksum(s):
>>>>> apache-maven-3.2.4-src.zip sha1:
>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>
>>>>> Staging site:
>>>>> http://takari.io/maven-3.2.4/
>>>>>
>>>>> Vote open for 72 hours.
>>>>>
>>>>> [ ] +1
>>>>> [ ] +0
>>>>> [ ] -1
>>>>>
>>>>> Thanks,
>>>>>
>>>>> The Maven Team
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Hervé BOUTEMY <he...@free.fr>.
ok, I had a look at Tycho sources:
this is something introduced recently (10/10/2014): IIUC, Tycho 0.22.0 was
released since then
I'm surprised of tycho-core's ToolchainProvider: IIUC, that's a rewrite of a
part of maven-toochains-plugin, depending on ToolchainManagerPrivate which is
not part of public API
IIUC, the intent was to get the configured toolchain: since then, I wrote a
little doc for that [1] to show how to use ToolchainManager to do exactly that
using normal Maven API
Notice this won't fix everything, since:
1. Tycho needs JavaToochain, which has been renamed (Toolchain vs ToolChain)
2. the interface doesn't offer expected getJavaHome() API
Then you'll need to cast to DefaultJavaToolChain, which will need to be added
back to maven-core: I'll do it immediately.
I don't know the Tycho community, but using ToolchainManager would IMHO be
more future-proof than writing ToolchainProvider
Regards,
Hervé
[1] http://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/custom.html
Le samedi 13 décembre 2014 09:13:50 Hervé BOUTEMY a écrit :
> DefaultJavaToolChain? you mean the implementation?
>
> Can you give me pointers to the Tycho sources that use this API?
> (that's clearly not expected)
>
> I'm in favor of introducing deprecated DefaultJavaToolChain
> that extends the new implementation, which is easy to do: just need to
> understand how it is used in Tycho, since the class is supposed to be used
> by JavaToolchainFactory (on only this one).
>
> Regards,
>
> Hervé
>
> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> > Unfortunately, I have to take this back. The changes to toolchain
> > broke Tycho and, short of using reflection, I don't see how
> > to make Tycho work with maven 3.2.4 and earlier versions of Maven.
> >
> > For better or worse,
> > org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> > Maven API since 2.x and I don't think we can just remove the class.
> >
> > I see two ways to fix this. Either we rename the classes back, which is
> > probably the easiest. Or we introduce deprecated DefaultJavaToolChain
> > that extends the new implementation.
> >
> > Here is my -1 for releasing 3.2.4 in its current state.
> >
> > --
> > Regards,
> > Igor
> >
> > On 2014-12-12, 18:01, Igor Fedorenko wrote:
> > > +1
> > >
> > > --
> > > Regards,
> > > Igor
> > >
> > > On 2014-12-12, 16:54, Jason van Zyl wrote:
> > >> Hi,
> > >>
> > >> Time to release Maven 3.2.4!
> > >>
> > >> Here is a link to Jira with 20 issues resolved:
> > >> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
> > >> on
> > >> =20574
> > >>
> > >>
> > >> Staging repo:
> > >> https://repository.apache.org/content/repositories/maven-1102/
> > >>
> > >> The distributable binaries and sources for testing can be found here:
> > >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >> e/
> > >> maven/apache-maven/3.2.4/
> > >>
> > >>
> > >> Specifically the zip, tarball, and source archives can be found here:
> > >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >> e/
> > >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> > >>
> > >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >> e/
> > >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> > >>
> > >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >> e/
> > >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> > >>
> > >> https://repository.apache.org/content/repositories/maven-1102/org/apach
> > >> e/
> > >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> > >>
> > >>
> > >> Source release checksum(s):
> > >> apache-maven-3.2.4-src.zip sha1:
> > >> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> > >>
> > >> Staging site:
> > >> http://takari.io/maven-3.2.4/
> > >>
> > >> Vote open for 72 hours.
> > >>
> > >> [ ] +1
> > >> [ ] +0
> > >> [ ] -1
> > >>
> > >> Thanks,
> > >>
> > >> The Maven Team
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
I've reintroduced DefaultJavaToolChain as deprecated extension of
JavaToolchainImpl. All Tycho ITs pass now and I am not aware of any
other regressions in maven 3.2.4.
--
Regards,
Igor
On 2014-12-13, 3:13, Hervé BOUTEMY wrote:
> DefaultJavaToolChain? you mean the implementation?
>
> Can you give me pointers to the Tycho sources that use this API?
> (that's clearly not expected)
>
> I'm in favor of introducing deprecated DefaultJavaToolChain
> that extends the new implementation, which is easy to do: just need to
> understand how it is used in Tycho, since the class is supposed to be used by
> JavaToolchainFactory (on only this one).
>
> Regards,
>
> Hervé
>
> Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
>> Unfortunately, I have to take this back. The changes to toolchain
>> broke Tycho and, short of using reflection, I don't see how
>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>>
>> For better or worse,
>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>> Maven API since 2.x and I don't think we can just remove the class.
>>
>> I see two ways to fix this. Either we rename the classes back, which is
>> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
>> that extends the new implementation.
>>
>> Here is my -1 for releasing 3.2.4 in its current state.
>>
>> --
>> Regards,
>> Igor
>>
>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>> +1
>>>
>>> --
>>> Regards,
>>> Igor
>>>
>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>> Hi,
>>>>
>>>> Time to release Maven 3.2.4!
>>>>
>>>> Here is a link to Jira with 20 issues resolved:
>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version
>>>> =20574
>>>>
>>>>
>>>> Staging repo:
>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>
>>>> The distributable binaries and sources for testing can be found here:
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/
>>>>
>>>>
>>>> Specifically the zip, tarball, and source archives can be found here:
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>
>>>>
>>>> Source release checksum(s):
>>>> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>
>>>> Staging site:
>>>> http://takari.io/maven-3.2.4/
>>>>
>>>> Vote open for 72 hours.
>>>>
>>>> [ ] +1
>>>> [ ] +0
>>>> [ ] -1
>>>>
>>>> Thanks,
>>>>
>>>> The Maven Team
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Hervé BOUTEMY <he...@free.fr>.
DefaultJavaToolChain? you mean the implementation?
Can you give me pointers to the Tycho sources that use this API?
(that's clearly not expected)
I'm in favor of introducing deprecated DefaultJavaToolChain
that extends the new implementation, which is easy to do: just need to
understand how it is used in Tycho, since the class is supposed to be used by
JavaToolchainFactory (on only this one).
Regards,
Hervé
Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> Unfortunately, I have to take this back. The changes to toolchain
> broke Tycho and, short of using reflection, I don't see how
> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>
> For better or worse,
> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> Maven API since 2.x and I don't think we can just remove the class.
>
> I see two ways to fix this. Either we rename the classes back, which is
> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
> that extends the new implementation.
>
> Here is my -1 for releasing 3.2.4 in its current state.
>
> --
> Regards,
> Igor
>
> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> > +1
> >
> > --
> > Regards,
> > Igor
> >
> > On 2014-12-12, 16:54, Jason van Zyl wrote:
> >> Hi,
> >>
> >> Time to release Maven 3.2.4!
> >>
> >> Here is a link to Jira with 20 issues resolved:
> >> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version
> >> =20574
> >>
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1102/
> >>
> >> The distributable binaries and sources for testing can be found here:
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/
> >>
> >>
> >> Specifically the zip, tarball, and source archives can be found here:
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> >>
> >>
> >> Source release checksum(s):
> >> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>
> >> Staging site:
> >> http://takari.io/maven-3.2.4/
> >>
> >> Vote open for 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Thanks,
> >>
> >> The Maven Team
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [CANCELED] [VOTE] Maven 3.2.4 Release
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
I just wanted to point out there was a change in behaviour between 3.2.3
and 3.2.4. If you this was expected/desired, I have no objections.
--
Regards,
Igor
On 2014-12-13, 8:33, Hervé BOUTEMY wrote:
> uh, stupid me, I answered too early in the morning ;)
>
> The problem is in pom.xml: the config is wrong
> <configuration>
> <toolchains>
> <vendor>fake</vendor>
> </toolchains>
> </configuration>
> the result can be seen in the INFO message
> [INFO] Type:vendor
>
> With previous version, this (surprisingly) could work
> But with MNG-5716 fixed, this does not work any more: there is no "vendor"
> toolchain, but you're looking for a "jdk" toolchain with "vendor" requirement
>
> the configuration has to be:
> <configuration>
> <toolchains>
> <jdk>
> <vendor>fake</vendor>
> </jdk>
> </toolchains>
> </configuration>
>
> Regards,
>
> Hervé
>
> Le samedi 13 décembre 2014 07:22:03 Igor Fedorenko a écrit :
>> Are you able to run "mvn validate" on the attached project with staged
>> maven 3.2.4 or current master? The log you attached is from maven 3.2.3.
>> I've attached log from current master.
>>
>> --
>> Regards,
>> Igor
>>
>> On 2014-12-13, 3:32, Hervé BOUTEMY wrote:
>>> I can't reproduce the problem: see the logs in attachment
>>>
>>> can you give me more details?
>>>
>>>
>>> notice that from every changes we did on toolchains, the only expected
>>> visible change was on MNG-5718: custom toolchains need to be enhanced.
>>> MNG-5719 wasn't supposed to have any impact on Tycho or any other project.
>>> But perhaps you're using custom compoennt more tied to core than expected.
>>>
>>> Regards,
>>>
>>> Hervé
>>>
>>> Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :
>>>> Providing backwards compatibility shim seems to be quite
>>>> straightforward, but there appears to be another problem. From what I
>>>> can tell, current maven master breaks maven-toolchains-plugin 1.0, at
>>>> least for some projects that work with maven 3.2.3.
>>>>
>>>> I've attached a trivial example that shows the problem with
>>>> maven-toolchains-plugin plugin and will appreciate if somebody familiar
>>>> toolchains had a look.
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Igor
>>>>
>>>> On 2014-12-12, 20:26, Igor Fedorenko wrote:
>>>>> I'll prepare a fix later today or tomorrow morning (eastern time).
>>>>> Unless
>>>>> somebody else wants to do this, of course.>
>>>>> On December 12, 2014 7:27:14 PM EST, Jason van Zyl <ja...@takari.io>
>>>
>>> wrote:
>>>>>> Tycho is a very important consumer of Maven and we can't break them.
>>>>>>
>>>>>> This is the second time that the removal of signatures has broken Tycho
>>>>>> and I restored them previously. I think we need to do the same here.
>>>>>>
>>>>>> On Dec 12, 2014, at 7:22 PM, Jason van Zyl <ja...@takari.io> wrote:
>>>>>>> I will cancel the release, we can't break Tycho.
>>>>>>>
>>>>>>> Are there no ITs for toolchains? How did they not break?
>>>>>>>
>>>>>>> On Dec 12, 2014, at 6:38 PM, Igor Fedorenko <ig...@ifedorenko.com>
>>>>>>
>>>>>> wrote:
>>>>>>>> Unfortunately, I have to take this back. The changes to toolchain
>>>>>>>> broke Tycho and, short of using reflection, I don't see how
>>>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>>>>>>>>
>>>>>>>> For better or worse,
>>>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>>>>>> Maven API since 2.x and I don't think we can just remove the class.
>>>>>>>>
>>>>>>>> I see two ways to fix this. Either we rename the classes back, which
>>>>>>
>>>>>> is
>>>>>>
>>>>>>>> probably the easiest. Or we introduce deprecated
>>>>>>
>>>>>> DefaultJavaToolChain
>>>>>>
>>>>>>>> that extends the new implementation.
>>>>>>>>
>>>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>> Igor
>>>>>>>>
>>>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>>>>>> +1
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Regards,
>>>>>>>>> Igor
>>>>>>>>>
>>>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> Time to release Maven 3.2.4!
>>>>>>
>>>>>>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
>>>>>> on
>>>>>> =20574>>
>>>>>>
>>>>>>>>>> Staging repo:
>>>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>>>>>
>>>>>>>>>> The distributable binaries and sources for testing can be found
>>>>>>
>>>>>> here:
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/>>
>>>>>>
>>>>>>>>>> Specifically the zip, tarball, and source archives can be found
>>>>>>
>>>>>> here:
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>>
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>>
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>>
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
>>>>>> e/
>>>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz>>
>>>>>>
>>>>>>>>>> Source release checksum(s):
>>>>>>
>>>>>>>>>> apache-maven-3.2.4-src.zip sha1:
>>>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>>
>>>>>>>>>> Staging site:
>>>>>>>>>> http://takari.io/maven-3.2.4/
>>>>>>>>>>
>>>>>>>>>> Vote open for 72 hours.
>>>>>>>>>>
>>>>>>>>>> [ ] +1
>>>>>>>>>> [ ] +0
>>>>>>>>>> [ ] -1
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>>
>>>>>>>>>> The Maven Team
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Jason
>>>>>>>
>>>>>>> ----------------------------------------------------------
>>>>>>> Jason van Zyl
>>>>>>> Founder, Apache Maven
>>>>>>> http://twitter.com/jvanzyl
>>>>>>> http://twitter.com/takari_io
>>>>>>> ---------------------------------------------------------
>>>>>>>
>>>>>>> You are never dedicated to something you have complete confidence in.
>>>>>>> No one is fanatically shouting that the sun is going to rise
>>>>>>
>>>>>> tomorrow.
>>>>>>
>>>>>>> They know it is going to rise tomorrow. When people are fanatically
>>>>>>> dedicated to political or religious faiths or any other kind of
>>>>>>> dogmas or goals, it's always because these dogmas or
>>>>>>> goals are in doubt.
>>>>>>>
>>>>>>> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Jason
>>>>>>
>>>>>> ----------------------------------------------------------
>>>>>> Jason van Zyl
>>>>>> Founder, Apache Maven
>>>>>> http://twitter.com/jvanzyl
>>>>>> http://twitter.com/takari_io
>>>>>> ---------------------------------------------------------
>>>>>>
>>>>>> What matters is not ideas, but the people who have them. Good people
>>>>>> can fix bad ideas, but good ideas can't save bad people.
>>>>>>
>>>>>> -- Paul Graham
>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [CANCELED] [VOTE] Maven 3.2.4 Release
Posted by Hervé BOUTEMY <he...@free.fr>.
uh, stupid me, I answered too early in the morning ;)
The problem is in pom.xml: the config is wrong
<configuration>
<toolchains>
<vendor>fake</vendor>
</toolchains>
</configuration>
the result can be seen in the INFO message
[INFO] Type:vendor
With previous version, this (surprisingly) could work
But with MNG-5716 fixed, this does not work any more: there is no "vendor"
toolchain, but you're looking for a "jdk" toolchain with "vendor" requirement
the configuration has to be:
<configuration>
<toolchains>
<jdk>
<vendor>fake</vendor>
</jdk>
</toolchains>
</configuration>
Regards,
Hervé
Le samedi 13 décembre 2014 07:22:03 Igor Fedorenko a écrit :
> Are you able to run "mvn validate" on the attached project with staged
> maven 3.2.4 or current master? The log you attached is from maven 3.2.3.
> I've attached log from current master.
>
> --
> Regards,
> Igor
>
> On 2014-12-13, 3:32, Hervé BOUTEMY wrote:
> > I can't reproduce the problem: see the logs in attachment
> >
> > can you give me more details?
> >
> >
> > notice that from every changes we did on toolchains, the only expected
> > visible change was on MNG-5718: custom toolchains need to be enhanced.
> > MNG-5719 wasn't supposed to have any impact on Tycho or any other project.
> > But perhaps you're using custom compoennt more tied to core than expected.
> >
> > Regards,
> >
> > Hervé
> >
> > Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :
> >> Providing backwards compatibility shim seems to be quite
> >> straightforward, but there appears to be another problem. From what I
> >> can tell, current maven master breaks maven-toolchains-plugin 1.0, at
> >> least for some projects that work with maven 3.2.3.
> >>
> >> I've attached a trivial example that shows the problem with
> >> maven-toolchains-plugin plugin and will appreciate if somebody familiar
> >> toolchains had a look.
> >>
> >>
> >> --
> >> Regards,
> >> Igor
> >>
> >> On 2014-12-12, 20:26, Igor Fedorenko wrote:
> >>> I'll prepare a fix later today or tomorrow morning (eastern time).
> >>> Unless
> >>> somebody else wants to do this, of course.>
> >>> On December 12, 2014 7:27:14 PM EST, Jason van Zyl <ja...@takari.io>
> >
> > wrote:
> >>>> Tycho is a very important consumer of Maven and we can't break them.
> >>>>
> >>>> This is the second time that the removal of signatures has broken Tycho
> >>>> and I restored them previously. I think we need to do the same here.
> >>>>
> >>>> On Dec 12, 2014, at 7:22 PM, Jason van Zyl <ja...@takari.io> wrote:
> >>>>> I will cancel the release, we can't break Tycho.
> >>>>>
> >>>>> Are there no ITs for toolchains? How did they not break?
> >>>>>
> >>>>> On Dec 12, 2014, at 6:38 PM, Igor Fedorenko <ig...@ifedorenko.com>
> >>>>
> >>>> wrote:
> >>>>>> Unfortunately, I have to take this back. The changes to toolchain
> >>>>>> broke Tycho and, short of using reflection, I don't see how
> >>>>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
> >>>>>>
> >>>>>> For better or worse,
> >>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> >>>>>> Maven API since 2.x and I don't think we can just remove the class.
> >>>>>>
> >>>>>> I see two ways to fix this. Either we rename the classes back, which
> >>>>
> >>>> is
> >>>>
> >>>>>> probably the easiest. Or we introduce deprecated
> >>>>
> >>>> DefaultJavaToolChain
> >>>>
> >>>>>> that extends the new implementation.
> >>>>>>
> >>>>>> Here is my -1 for releasing 3.2.4 in its current state.
> >>>>>>
> >>>>>> --
> >>>>>> Regards,
> >>>>>> Igor
> >>>>>>
> >>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> >>>>>>> +1
> >>>>>>>
> >>>>>>> --
> >>>>>>> Regards,
> >>>>>>> Igor
> >>>>>>>
> >>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> >>>>>>>> Hi,
> >>>>>>>>
> >>>>>>>> Time to release Maven 3.2.4!
> >>>>
> >>>>>>>> Here is a link to Jira with 20 issues resolved:
> >>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&versi
> >>>> on
> >>>> =20574>>
> >>>>
> >>>>>>>> Staging repo:
> >>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
> >>>>>>>>
> >>>>>>>> The distributable binaries and sources for testing can be found
> >>>>
> >>>> here:
> >>>>
> >>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>> e/
> >>>> maven/apache-maven/3.2.4/>>
> >>>>
> >>>>>>>> Specifically the zip, tarball, and source archives can be found
> >>>>
> >>>> here:
> >>>>
> >>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>> e/
> >>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>>>
> >>>>
> >>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>> e/
> >>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>>>
> >>>>
> >>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>> e/
> >>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>>>
> >>>>
> >>>> https://repository.apache.org/content/repositories/maven-1102/org/apach
> >>>> e/
> >>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz>>
> >>>>
> >>>>>>>> Source release checksum(s):
> >>>>
> >>>>>>>> apache-maven-3.2.4-src.zip sha1:
> >>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>>>
> >>>>>>>> Staging site:
> >>>>>>>> http://takari.io/maven-3.2.4/
> >>>>>>>>
> >>>>>>>> Vote open for 72 hours.
> >>>>>>>>
> >>>>>>>> [ ] +1
> >>>>>>>> [ ] +0
> >>>>>>>> [ ] -1
> >>>>>>>>
> >>>>>>>> Thanks,
> >>>>>>>>
> >>>>>>>> The Maven Team
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>>
> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>>
> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>>
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>
> >>>>> Thanks,
> >>>>>
> >>>>> Jason
> >>>>>
> >>>>> ----------------------------------------------------------
> >>>>> Jason van Zyl
> >>>>> Founder, Apache Maven
> >>>>> http://twitter.com/jvanzyl
> >>>>> http://twitter.com/takari_io
> >>>>> ---------------------------------------------------------
> >>>>>
> >>>>> You are never dedicated to something you have complete confidence in.
> >>>>> No one is fanatically shouting that the sun is going to rise
> >>>>
> >>>> tomorrow.
> >>>>
> >>>>> They know it is going to rise tomorrow. When people are fanatically
> >>>>> dedicated to political or religious faiths or any other kind of
> >>>>> dogmas or goals, it's always because these dogmas or
> >>>>> goals are in doubt.
> >>>>>
> >>>>> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Jason
> >>>>
> >>>> ----------------------------------------------------------
> >>>> Jason van Zyl
> >>>> Founder, Apache Maven
> >>>> http://twitter.com/jvanzyl
> >>>> http://twitter.com/takari_io
> >>>> ---------------------------------------------------------
> >>>>
> >>>> What matters is not ideas, but the people who have them. Good people
> >>>> can fix bad ideas, but good ideas can't save bad people.
> >>>>
> >>>> -- Paul Graham
> >>>>
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [CANCELED] [VOTE] Maven 3.2.4 Release
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
Are you able to run "mvn validate" on the attached project with staged
maven 3.2.4 or current master? The log you attached is from maven 3.2.3.
I've attached log from current master.
--
Regards,
Igor
On 2014-12-13, 3:32, Hervé BOUTEMY wrote:
> I can't reproduce the problem: see the logs in attachment
>
> can you give me more details?
>
>
> notice that from every changes we did on toolchains, the only expected visible
> change was on MNG-5718: custom toolchains need to be enhanced.
> MNG-5719 wasn't supposed to have any impact on Tycho or any other project.
> But perhaps you're using custom compoennt more tied to core than expected.
>
> Regards,
>
> Hervé
>
> Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :
>> Providing backwards compatibility shim seems to be quite
>> straightforward, but there appears to be another problem. From what I
>> can tell, current maven master breaks maven-toolchains-plugin 1.0, at
>> least for some projects that work with maven 3.2.3.
>>
>> I've attached a trivial example that shows the problem with
>> maven-toolchains-plugin plugin and will appreciate if somebody familiar
>> toolchains had a look.
>>
>>
>> --
>> Regards,
>> Igor
>>
>> On 2014-12-12, 20:26, Igor Fedorenko wrote:
>>> I'll prepare a fix later today or tomorrow morning (eastern time). Unless
>>> somebody else wants to do this, of course.>
>>> On December 12, 2014 7:27:14 PM EST, Jason van Zyl <ja...@takari.io>
> wrote:
>>>> Tycho is a very important consumer of Maven and we can't break them.
>>>>
>>>> This is the second time that the removal of signatures has broken Tycho
>>>> and I restored them previously. I think we need to do the same here.
>>>>
>>>> On Dec 12, 2014, at 7:22 PM, Jason van Zyl <ja...@takari.io> wrote:
>>>>> I will cancel the release, we can't break Tycho.
>>>>>
>>>>> Are there no ITs for toolchains? How did they not break?
>>>>>
>>>>> On Dec 12, 2014, at 6:38 PM, Igor Fedorenko <ig...@ifedorenko.com>
>>>>
>>>> wrote:
>>>>>> Unfortunately, I have to take this back. The changes to toolchain
>>>>>> broke Tycho and, short of using reflection, I don't see how
>>>>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>>>>>>
>>>>>> For better or worse,
>>>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>>>> Maven API since 2.x and I don't think we can just remove the class.
>>>>>>
>>>>>> I see two ways to fix this. Either we rename the classes back, which
>>>>
>>>> is
>>>>
>>>>>> probably the easiest. Or we introduce deprecated
>>>>
>>>> DefaultJavaToolChain
>>>>
>>>>>> that extends the new implementation.
>>>>>>
>>>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Igor
>>>>>>
>>>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>>>> +1
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Igor
>>>>>>>
>>>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Time to release Maven 3.2.4!
>>>>
>>>>>>>> Here is a link to Jira with 20 issues resolved:
>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version
>>>> =20574>>
>>>>>>>> Staging repo:
>>>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>>>
>>>>>>>> The distributable binaries and sources for testing can be found
>>>>
>>>> here:
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/>>
>>>>>>>> Specifically the zip, tarball, and source archives can be found
>>>>
>>>> here:
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/
>>>> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz>>
>>>>>>>> Source release checksum(s):
>>>>
>>>>>>>> apache-maven-3.2.4-src.zip sha1:
>>>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>
>>>>>>>> Staging site:
>>>>>>>> http://takari.io/maven-3.2.4/
>>>>>>>>
>>>>>>>> Vote open for 72 hours.
>>>>>>>>
>>>>>>>> [ ] +1
>>>>>>>> [ ] +0
>>>>>>>> [ ] -1
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> The Maven Team
>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Jason
>>>>>
>>>>> ----------------------------------------------------------
>>>>> Jason van Zyl
>>>>> Founder, Apache Maven
>>>>> http://twitter.com/jvanzyl
>>>>> http://twitter.com/takari_io
>>>>> ---------------------------------------------------------
>>>>>
>>>>> You are never dedicated to something you have complete confidence in.
>>>>> No one is fanatically shouting that the sun is going to rise
>>>>
>>>> tomorrow.
>>>>
>>>>> They know it is going to rise tomorrow. When people are fanatically
>>>>> dedicated to political or religious faiths or any other kind of
>>>>> dogmas or goals, it's always because these dogmas or
>>>>> goals are in doubt.
>>>>>
>>>>> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
>>>>
>>>> Thanks,
>>>>
>>>> Jason
>>>>
>>>> ----------------------------------------------------------
>>>> Jason van Zyl
>>>> Founder, Apache Maven
>>>> http://twitter.com/jvanzyl
>>>> http://twitter.com/takari_io
>>>> ---------------------------------------------------------
>>>>
>>>> What matters is not ideas, but the people who have them. Good people
>>>> can fix bad ideas, but good ideas can't save bad people.
>>>>
>>>> -- Paul Graham
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
Re: [CANCELED] [VOTE] Maven 3.2.4 Release
Posted by Hervé BOUTEMY <he...@free.fr>.
I can't reproduce the problem: see the logs in attachment
can you give me more details?
notice that from every changes we did on toolchains, the only expected visible
change was on MNG-5718: custom toolchains need to be enhanced.
MNG-5719 wasn't supposed to have any impact on Tycho or any other project.
But perhaps you're using custom compoennt more tied to core than expected.
Regards,
Hervé
Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :
> Providing backwards compatibility shim seems to be quite
> straightforward, but there appears to be another problem. From what I
> can tell, current maven master breaks maven-toolchains-plugin 1.0, at
> least for some projects that work with maven 3.2.3.
>
> I've attached a trivial example that shows the problem with
> maven-toolchains-plugin plugin and will appreciate if somebody familiar
> toolchains had a look.
>
>
> --
> Regards,
> Igor
>
> On 2014-12-12, 20:26, Igor Fedorenko wrote:
> > I'll prepare a fix later today or tomorrow morning (eastern time). Unless
> > somebody else wants to do this, of course.>
> > On December 12, 2014 7:27:14 PM EST, Jason van Zyl <ja...@takari.io>
wrote:
> >> Tycho is a very important consumer of Maven and we can't break them.
> >>
> >> This is the second time that the removal of signatures has broken Tycho
> >> and I restored them previously. I think we need to do the same here.
> >>
> >> On Dec 12, 2014, at 7:22 PM, Jason van Zyl <ja...@takari.io> wrote:
> >>> I will cancel the release, we can't break Tycho.
> >>>
> >>> Are there no ITs for toolchains? How did they not break?
> >>>
> >>> On Dec 12, 2014, at 6:38 PM, Igor Fedorenko <ig...@ifedorenko.com>
> >>
> >> wrote:
> >>>> Unfortunately, I have to take this back. The changes to toolchain
> >>>> broke Tycho and, short of using reflection, I don't see how
> >>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
> >>>>
> >>>> For better or worse,
> >>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> >>>> Maven API since 2.x and I don't think we can just remove the class.
> >>>>
> >>>> I see two ways to fix this. Either we rename the classes back, which
> >>
> >> is
> >>
> >>>> probably the easiest. Or we introduce deprecated
> >>
> >> DefaultJavaToolChain
> >>
> >>>> that extends the new implementation.
> >>>>
> >>>> Here is my -1 for releasing 3.2.4 in its current state.
> >>>>
> >>>> --
> >>>> Regards,
> >>>> Igor
> >>>>
> >>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> >>>>> +1
> >>>>>
> >>>>> --
> >>>>> Regards,
> >>>>> Igor
> >>>>>
> >>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>> Time to release Maven 3.2.4!
> >>
> >>>>>> Here is a link to Jira with 20 issues resolved:
> >> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version
> >> =20574>>
> >>>>>> Staging repo:
> >>>>>> https://repository.apache.org/content/repositories/maven-1102/
> >>>>>>
> >>>>>> The distributable binaries and sources for testing can be found
> >>
> >> here:
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/>>
> >>>>>> Specifically the zip, tarball, and source archives can be found
> >>
> >> here:
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz>>
> >>>>>> Source release checksum(s):
> >>
> >>>>>> apache-maven-3.2.4-src.zip sha1:
> >> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>
> >>>>>> Staging site:
> >>>>>> http://takari.io/maven-3.2.4/
> >>>>>>
> >>>>>> Vote open for 72 hours.
> >>>>>>
> >>>>>> [ ] +1
> >>>>>> [ ] +0
> >>>>>> [ ] -1
> >>>>>>
> >>>>>> Thanks,
> >>>>>>
> >>>>>> The Maven Team
> >>
> >> ---------------------------------------------------------------------
> >>
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> ---------------------------------------------------------------------
> >>
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> ---------------------------------------------------------------------
> >>
> >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>
> >>> Thanks,
> >>>
> >>> Jason
> >>>
> >>> ----------------------------------------------------------
> >>> Jason van Zyl
> >>> Founder, Apache Maven
> >>> http://twitter.com/jvanzyl
> >>> http://twitter.com/takari_io
> >>> ---------------------------------------------------------
> >>>
> >>> You are never dedicated to something you have complete confidence in.
> >>> No one is fanatically shouting that the sun is going to rise
> >>
> >> tomorrow.
> >>
> >>> They know it is going to rise tomorrow. When people are fanatically
> >>> dedicated to political or religious faiths or any other kind of
> >>> dogmas or goals, it's always because these dogmas or
> >>> goals are in doubt.
> >>>
> >>> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
> >>
> >> Thanks,
> >>
> >> Jason
> >>
> >> ----------------------------------------------------------
> >> Jason van Zyl
> >> Founder, Apache Maven
> >> http://twitter.com/jvanzyl
> >> http://twitter.com/takari_io
> >> ---------------------------------------------------------
> >>
> >> What matters is not ideas, but the people who have them. Good people
> >> can fix bad ideas, but good ideas can't save bad people.
> >>
> >> -- Paul Graham
Re: [CANCELED] [VOTE] Maven 3.2.4 Release
Posted by Hervé BOUTEMY <he...@free.fr>.
I did the work on this: I'll have a look
Sorry for the breaks: if tycho is a good regression test and can be automated,
we should add it to our CI server to detect such problems earlier
Regards,
Hervé
Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :
> Providing backwards compatibility shim seems to be quite
> straightforward, but there appears to be another problem. From what I
> can tell, current maven master breaks maven-toolchains-plugin 1.0, at
> least for some projects that work with maven 3.2.3.
>
> I've attached a trivial example that shows the problem with
> maven-toolchains-plugin plugin and will appreciate if somebody familiar
> toolchains had a look.
>
>
> --
> Regards,
> Igor
>
> On 2014-12-12, 20:26, Igor Fedorenko wrote:
> > I'll prepare a fix later today or tomorrow morning (eastern time). Unless
> > somebody else wants to do this, of course.>
> > On December 12, 2014 7:27:14 PM EST, Jason van Zyl <ja...@takari.io>
wrote:
> >> Tycho is a very important consumer of Maven and we can't break them.
> >>
> >> This is the second time that the removal of signatures has broken Tycho
> >> and I restored them previously. I think we need to do the same here.
> >>
> >> On Dec 12, 2014, at 7:22 PM, Jason van Zyl <ja...@takari.io> wrote:
> >>> I will cancel the release, we can't break Tycho.
> >>>
> >>> Are there no ITs for toolchains? How did they not break?
> >>>
> >>> On Dec 12, 2014, at 6:38 PM, Igor Fedorenko <ig...@ifedorenko.com>
> >>
> >> wrote:
> >>>> Unfortunately, I have to take this back. The changes to toolchain
> >>>> broke Tycho and, short of using reflection, I don't see how
> >>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
> >>>>
> >>>> For better or worse,
> >>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> >>>> Maven API since 2.x and I don't think we can just remove the class.
> >>>>
> >>>> I see two ways to fix this. Either we rename the classes back, which
> >>
> >> is
> >>
> >>>> probably the easiest. Or we introduce deprecated
> >>
> >> DefaultJavaToolChain
> >>
> >>>> that extends the new implementation.
> >>>>
> >>>> Here is my -1 for releasing 3.2.4 in its current state.
> >>>>
> >>>> --
> >>>> Regards,
> >>>> Igor
> >>>>
> >>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> >>>>> +1
> >>>>>
> >>>>> --
> >>>>> Regards,
> >>>>> Igor
> >>>>>
> >>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>> Time to release Maven 3.2.4!
> >>
> >>>>>> Here is a link to Jira with 20 issues resolved:
> >> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version
> >> =20574>>
> >>>>>> Staging repo:
> >>>>>> https://repository.apache.org/content/repositories/maven-1102/
> >>>>>>
> >>>>>> The distributable binaries and sources for testing can be found
> >>
> >> here:
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/>>
> >>>>>> Specifically the zip, tarball, and source archives can be found
> >>
> >> here:
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>
> >>
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz>>
> >>>>>> Source release checksum(s):
> >>
> >>>>>> apache-maven-3.2.4-src.zip sha1:
> >> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>
> >>>>>> Staging site:
> >>>>>> http://takari.io/maven-3.2.4/
> >>>>>>
> >>>>>> Vote open for 72 hours.
> >>>>>>
> >>>>>> [ ] +1
> >>>>>> [ ] +0
> >>>>>> [ ] -1
> >>>>>>
> >>>>>> Thanks,
> >>>>>>
> >>>>>> The Maven Team
> >>
> >> ---------------------------------------------------------------------
> >>
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> ---------------------------------------------------------------------
> >>
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> ---------------------------------------------------------------------
> >>
> >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>
> >>> Thanks,
> >>>
> >>> Jason
> >>>
> >>> ----------------------------------------------------------
> >>> Jason van Zyl
> >>> Founder, Apache Maven
> >>> http://twitter.com/jvanzyl
> >>> http://twitter.com/takari_io
> >>> ---------------------------------------------------------
> >>>
> >>> You are never dedicated to something you have complete confidence in.
> >>> No one is fanatically shouting that the sun is going to rise
> >>
> >> tomorrow.
> >>
> >>> They know it is going to rise tomorrow. When people are fanatically
> >>> dedicated to political or religious faiths or any other kind of
> >>> dogmas or goals, it's always because these dogmas or
> >>> goals are in doubt.
> >>>
> >>> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
> >>
> >> Thanks,
> >>
> >> Jason
> >>
> >> ----------------------------------------------------------
> >> Jason van Zyl
> >> Founder, Apache Maven
> >> http://twitter.com/jvanzyl
> >> http://twitter.com/takari_io
> >> ---------------------------------------------------------
> >>
> >> What matters is not ideas, but the people who have them. Good people
> >> can fix bad ideas, but good ideas can't save bad people.
> >>
> >> -- Paul Graham
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [CANCELED] [VOTE] Maven 3.2.4 Release
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
Providing backwards compatibility shim seems to be quite
straightforward, but there appears to be another problem. From what I
can tell, current maven master breaks maven-toolchains-plugin 1.0, at
least for some projects that work with maven 3.2.3.
I've attached a trivial example that shows the problem with
maven-toolchains-plugin plugin and will appreciate if somebody familiar
toolchains had a look.
--
Regards,
Igor
On 2014-12-12, 20:26, Igor Fedorenko wrote:
> I'll prepare a fix later today or tomorrow morning (eastern time). Unless somebody else wants to do this, of course.
>
> On December 12, 2014 7:27:14 PM EST, Jason van Zyl <ja...@takari.io> wrote:
>> Tycho is a very important consumer of Maven and we can't break them.
>>
>> This is the second time that the removal of signatures has broken Tycho
>> and I restored them previously. I think we need to do the same here.
>>
>> On Dec 12, 2014, at 7:22 PM, Jason van Zyl <ja...@takari.io> wrote:
>>
>>> I will cancel the release, we can't break Tycho.
>>>
>>> Are there no ITs for toolchains? How did they not break?
>>>
>>> On Dec 12, 2014, at 6:38 PM, Igor Fedorenko <ig...@ifedorenko.com>
>> wrote:
>>>
>>>> Unfortunately, I have to take this back. The changes to toolchain
>>>> broke Tycho and, short of using reflection, I don't see how
>>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>>>>
>>>> For better or worse,
>>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>>> Maven API since 2.x and I don't think we can just remove the class.
>>>>
>>>> I see two ways to fix this. Either we rename the classes back, which
>> is
>>>> probably the easiest. Or we introduce deprecated
>> DefaultJavaToolChain
>>>> that extends the new implementation.
>>>>
>>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>>
>>>> --
>>>> Regards,
>>>> Igor
>>>>
>>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>>> +1
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Igor
>>>>>
>>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Time to release Maven 3.2.4!
>>>>>>
>>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>>
>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>>>>>>
>>>>>>
>>>>>> Staging repo:
>>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>>
>>>>>> The distributable binaries and sources for testing can be found
>> here:
>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>>>>>>
>>>>>>
>>>>>> Specifically the zip, tarball, and source archives can be found
>> here:
>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>>
>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>>
>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>>
>>>>>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>>
>>>>>>
>>>>>> Source release checksum(s):
>>>>>> apache-maven-3.2.4-src.zip sha1:
>> db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>>
>>>>>> Staging site:
>>>>>> http://takari.io/maven-3.2.4/
>>>>>>
>>>>>> Vote open for 72 hours.
>>>>>>
>>>>>> [ ] +1
>>>>>> [ ] +0
>>>>>> [ ] -1
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> The Maven Team
>>>>>>
>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>
>>>>>
>>>>>
>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>
>>>>
>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder, Apache Maven
>>> http://twitter.com/jvanzyl
>>> http://twitter.com/takari_io
>>> ---------------------------------------------------------
>>>
>>> You are never dedicated to something you have complete confidence in.
>>> No one is fanatically shouting that the sun is going to rise
>> tomorrow.
>>> They know it is going to rise tomorrow. When people are fanatically
>>> dedicated to political or religious faiths or any other kind of
>>> dogmas or goals, it's always because these dogmas or
>>> goals are in doubt.
>>>
>>> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder, Apache Maven
>> http://twitter.com/jvanzyl
>> http://twitter.com/takari_io
>> ---------------------------------------------------------
>>
>> What matters is not ideas, but the people who have them. Good people
>> can fix bad ideas, but good ideas can't save bad people.
>>
>> -- Paul Graham
>
Re: [CANCELED] [VOTE] Maven 3.2.4 Release
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
I'll prepare a fix later today or tomorrow morning (eastern time). Unless somebody else wants to do this, of course.
On December 12, 2014 7:27:14 PM EST, Jason van Zyl <ja...@takari.io> wrote:
>Tycho is a very important consumer of Maven and we can't break them.
>
>This is the second time that the removal of signatures has broken Tycho
>and I restored them previously. I think we need to do the same here.
>
>On Dec 12, 2014, at 7:22 PM, Jason van Zyl <ja...@takari.io> wrote:
>
>> I will cancel the release, we can't break Tycho.
>>
>> Are there no ITs for toolchains? How did they not break?
>>
>> On Dec 12, 2014, at 6:38 PM, Igor Fedorenko <ig...@ifedorenko.com>
>wrote:
>>
>>> Unfortunately, I have to take this back. The changes to toolchain
>>> broke Tycho and, short of using reflection, I don't see how
>>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>>>
>>> For better or worse,
>>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>>> Maven API since 2.x and I don't think we can just remove the class.
>>>
>>> I see two ways to fix this. Either we rename the classes back, which
>is
>>> probably the easiest. Or we introduce deprecated
>DefaultJavaToolChain
>>> that extends the new implementation.
>>>
>>> Here is my -1 for releasing 3.2.4 in its current state.
>>>
>>> --
>>> Regards,
>>> Igor
>>>
>>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>>> +1
>>>>
>>>> --
>>>> Regards,
>>>> Igor
>>>>
>>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>>> Hi,
>>>>>
>>>>> Time to release Maven 3.2.4!
>>>>>
>>>>> Here is a link to Jira with 20 issues resolved:
>>>>>
>https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>>>>>
>>>>>
>>>>> Staging repo:
>>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>>
>>>>> The distributable binaries and sources for testing can be found
>here:
>>>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>>>>>
>>>>>
>>>>> Specifically the zip, tarball, and source archives can be found
>here:
>>>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>>
>>>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>>
>>>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>>
>>>>>
>https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>>
>>>>>
>>>>> Source release checksum(s):
>>>>> apache-maven-3.2.4-src.zip sha1:
>db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>>
>>>>> Staging site:
>>>>> http://takari.io/maven-3.2.4/
>>>>>
>>>>> Vote open for 72 hours.
>>>>>
>>>>> [ ] +1
>>>>> [ ] +0
>>>>> [ ] -1
>>>>>
>>>>> Thanks,
>>>>>
>>>>> The Maven Team
>>>>>
>---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>
>>>>
>---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>
>>>
>---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder, Apache Maven
>> http://twitter.com/jvanzyl
>> http://twitter.com/takari_io
>> ---------------------------------------------------------
>>
>> You are never dedicated to something you have complete confidence in.
>> No one is fanatically shouting that the sun is going to rise
>tomorrow.
>> They know it is going to rise tomorrow. When people are fanatically
>> dedicated to political or religious faiths or any other kind of
>> dogmas or goals, it's always because these dogmas or
>> goals are in doubt.
>>
>> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
>Thanks,
>
>Jason
>
>----------------------------------------------------------
>Jason van Zyl
>Founder, Apache Maven
>http://twitter.com/jvanzyl
>http://twitter.com/takari_io
>---------------------------------------------------------
>
>What matters is not ideas, but the people who have them. Good people
>can fix bad ideas, but good ideas can't save bad people.
>
> -- Paul Graham
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[CANCELED] [VOTE] Maven 3.2.4 Release
Posted by Jason van Zyl <ja...@takari.io>.
Tycho is a very important consumer of Maven and we can't break them.
This is the second time that the removal of signatures has broken Tycho and I restored them previously. I think we need to do the same here.
On Dec 12, 2014, at 7:22 PM, Jason van Zyl <ja...@takari.io> wrote:
> I will cancel the release, we can't break Tycho.
>
> Are there no ITs for toolchains? How did they not break?
>
> On Dec 12, 2014, at 6:38 PM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
>
>> Unfortunately, I have to take this back. The changes to toolchain
>> broke Tycho and, short of using reflection, I don't see how
>> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>>
>> For better or worse,
>> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
>> Maven API since 2.x and I don't think we can just remove the class.
>>
>> I see two ways to fix this. Either we rename the classes back, which is
>> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
>> that extends the new implementation.
>>
>> Here is my -1 for releasing 3.2.4 in its current state.
>>
>> --
>> Regards,
>> Igor
>>
>> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>>> +1
>>>
>>> --
>>> Regards,
>>> Igor
>>>
>>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>>> Hi,
>>>>
>>>> Time to release Maven 3.2.4!
>>>>
>>>> Here is a link to Jira with 20 issues resolved:
>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>>>>
>>>>
>>>> Staging repo:
>>>> https://repository.apache.org/content/repositories/maven-1102/
>>>>
>>>> The distributable binaries and sources for testing can be found here:
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>>>>
>>>>
>>>> Specifically the zip, tarball, and source archives can be found here:
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>>
>>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>>
>>>>
>>>> Source release checksum(s):
>>>> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>>
>>>> Staging site:
>>>> http://takari.io/maven-3.2.4/
>>>>
>>>> Vote open for 72 hours.
>>>>
>>>> [ ] +1
>>>> [ ] +0
>>>> [ ] -1
>>>>
>>>> Thanks,
>>>>
>>>> The Maven Team
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/takari_io
> ---------------------------------------------------------
>
> You are never dedicated to something you have complete confidence in.
> No one is fanatically shouting that the sun is going to rise tomorrow.
> They know it is going to rise tomorrow. When people are fanatically
> dedicated to political or religious faiths or any other kind of
> dogmas or goals, it's always because these dogmas or
> goals are in doubt.
>
> -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
>
>
>
>
>
>
>
>
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
What matters is not ideas, but the people who have them. Good people can fix bad ideas, but good ideas can't save bad people.
-- Paul Graham
Re: [VOTE] Maven 3.2.4 Release
Posted by Jason van Zyl <ja...@takari.io>.
I will cancel the release, we can't break Tycho.
Are there no ITs for toolchains? How did they not break?
On Dec 12, 2014, at 6:38 PM, Igor Fedorenko <ig...@ifedorenko.com> wrote:
> Unfortunately, I have to take this back. The changes to toolchain
> broke Tycho and, short of using reflection, I don't see how
> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>
> For better or worse,
> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> Maven API since 2.x and I don't think we can just remove the class.
>
> I see two ways to fix this. Either we rename the classes back, which is
> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
> that extends the new implementation.
>
> Here is my -1 for releasing 3.2.4 in its current state.
>
> --
> Regards,
> Igor
>
> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>> +1
>>
>> --
>> Regards,
>> Igor
>>
>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>> Hi,
>>>
>>> Time to release Maven 3.2.4!
>>>
>>> Here is a link to Jira with 20 issues resolved:
>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>>>
>>>
>>> Staging repo:
>>> https://repository.apache.org/content/repositories/maven-1102/
>>>
>>> The distributable binaries and sources for testing can be found here:
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>>>
>>>
>>> Specifically the zip, tarball, and source archives can be found here:
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>
>>>
>>> Source release checksum(s):
>>> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>
>>> Staging site:
>>> http://takari.io/maven-3.2.4/
>>>
>>> Vote open for 72 hours.
>>>
>>> [ ] +1
>>> [ ] +0
>>> [ ] -1
>>>
>>> Thanks,
>>>
>>> The Maven Team
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
You are never dedicated to something you have complete confidence in.
No one is fanatically shouting that the sun is going to rise tomorrow.
They know it is going to rise tomorrow. When people are fanatically
dedicated to political or religious faiths or any other kind of
dogmas or goals, it's always because these dogmas or
goals are in doubt.
-- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
Re: [VOTE] Maven 3.2.4 Release
Posted by Christian Schulte <cs...@schulte.it>.
Maybe consider upgrading to Aether '1.0.1.v20141111' ?
Am 12/13/14 um 00:38 schrieb Igor Fedorenko:
> Unfortunately, I have to take this back. The changes to toolchain
> broke Tycho and, short of using reflection, I don't see how
> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
>
> For better or worse,
> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> Maven API since 2.x and I don't think we can just remove the class.
>
> I see two ways to fix this. Either we rename the classes back, which is
> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
> that extends the new implementation.
>
> Here is my -1 for releasing 3.2.4 in its current state.
>
> --
> Regards,
> Igor
>
> On 2014-12-12, 18:01, Igor Fedorenko wrote:
>> +1
>>
>> --
>> Regards,
>> Igor
>>
>> On 2014-12-12, 16:54, Jason van Zyl wrote:
>>> Hi,
>>>
>>> Time to release Maven 3.2.4!
>>>
>>> Here is a link to Jira with 20 issues resolved:
>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>>>
>>>
>>> Staging repo:
>>> https://repository.apache.org/content/repositories/maven-1102/
>>>
>>> The distributable binaries and sources for testing can be found here:
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>>>
>>>
>>> Specifically the zip, tarball, and source archives can be found here:
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>>
>>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>>
>>>
>>> Source release checksum(s):
>>> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>>
>>> Staging site:
>>> http://takari.io/maven-3.2.4/
>>>
>>> Vote open for 72 hours.
>>>
>>> [ ] +1
>>> [ ] +0
>>> [ ] -1
>>>
>>> Thanks,
>>>
>>> The Maven Team
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
Unfortunately, I have to take this back. The changes to toolchain
broke Tycho and, short of using reflection, I don't see how
to make Tycho work with maven 3.2.4 and earlier versions of Maven.
For better or worse,
org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
Maven API since 2.x and I don't think we can just remove the class.
I see two ways to fix this. Either we rename the classes back, which is
probably the easiest. Or we introduce deprecated DefaultJavaToolChain
that extends the new implementation.
Here is my -1 for releasing 3.2.4 in its current state.
--
Regards,
Igor
On 2014-12-12, 18:01, Igor Fedorenko wrote:
> +1
>
> --
> Regards,
> Igor
>
> On 2014-12-12, 16:54, Jason van Zyl wrote:
>> Hi,
>>
>> Time to release Maven 3.2.4!
>>
>> Here is a link to Jira with 20 issues resolved:
>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>>
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1102/
>>
>> The distributable binaries and sources for testing can be found here:
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>>
>>
>> Specifically the zip, tarball, and source archives can be found here:
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
>>
>> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>>
>>
>> Source release checksum(s):
>> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>>
>> Staging site:
>> http://takari.io/maven-3.2.4/
>>
>> Vote open for 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Thanks,
>>
>> The Maven Team
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
+1
--
Regards,
Igor
On 2014-12-12, 16:54, Jason van Zyl wrote:
> Hi,
>
> Time to release Maven 3.2.4!
>
> Here is a link to Jira with 20 issues resolved:
> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1102/
>
> The distributable binaries and sources for testing can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>
> Specifically the zip, tarball, and source archives can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>
> Source release checksum(s):
> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>
> Staging site:
> http://takari.io/maven-3.2.4/
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Thanks,
>
> The Maven Team
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Jason,
just a question the staging site
http://takari.io/maven-3.2.4/
for example the link to JavaDoc produces 404,
the link to http://takari.io/maven-3.2.4/maven-core/lifecycles.html 404...
http://takari.io/maven-3.2.4/maven-model/maven.html 404 also ...
intentionally or just missed ?
Kind regards
Karl Heinz Marbaise
On 12/12/14 10:54 PM, Jason van Zyl wrote:
> Hi,
>
> Time to release Maven 3.2.4!
>
> Here is a link to Jira with 20 issues resolved:
> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1102/
>
> The distributable binaries and sources for testing can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>
> Specifically the zip, tarball, and source archives can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>
> Source release checksum(s):
> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>
> Staging site:
> http://takari.io/maven-3.2.4/
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Thanks,
>
> The Maven Team
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Hervé BOUTEMY <he...@free.fr>.
MNG-5724 was pushed to 3.2.5 in Jira, but it was already modified in the code:
either the Jira issue is copmpletely fixed, or code reverted, but the issue
can't be postponed like this
Regards,
Hervé
Le vendredi 12 décembre 2014 16:54:39 Jason van Zyl a écrit :
> Hi,
>
> Time to release Maven 3.2.4!
>
> Here is a link to Jira with 20 issues resolved:
> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20
> 574
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1102/
>
> The distributable binaries and sources for testing can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/mav
> en/apache-maven/3.2.4/
>
> Specifically the zip, tarball, and source archives can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/mav
> en/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/ma
> ven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> https://repository.apache.org/content/repositories/maven-1102/org/apache/ma
> ven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/ma
> ven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>
> Source release checksum(s):
> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>
> Staging site:
> http://takari.io/maven-3.2.4/
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Thanks,
>
> The Maven Team
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Maven 3.2.4 Release
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Jason,
tested with several of my own project, plugins,
Appassembler-maven-plugin, templating-maven-plugin,
taglist-maven-plugin, jdepend-maven-plugin, flatten-maven-plugin,
Maven-Assembly-Plugin, Maven RAR Plugin,
Maven EAR Plugin, Maven WAR Plugin to build with 3.2.4 (-Prun-its clean
verify) without any issue...
so +1 from me.
Kind regards
Karl Heinz Marbaise
On 12/12/14 10:54 PM, Jason van Zyl wrote:
> Hi,
>
> Time to release Maven 3.2.4!
>
> Here is a link to Jira with 20 issues resolved:
> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=20574
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1102/
>
> The distributable binaries and sources for testing can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
>
> Specifically the zip, tarball, and source archives can be found here:
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
>
> Source release checksum(s):
> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
>
> Staging site:
> http://takari.io/maven-3.2.4/
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Thanks,
>
> The Maven Team
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org