[GitHub] jaydoane opened a new pull request #1463: Clean up replication dbs on exit

[GitBox <gi...@apache.org>]

jaydoane opened a new pull request #1463: Clean up replication dbs on exit
URL: https://github.com/apache/couchdb/pull/1463
 
 
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   Implement `delete_on_exit/1` and use it to delete replication dbs for tests which currently lack clean up. Replace existing on_exit calls with new function.
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   Before this PR, run `mix test --trace test/replication_test.exs` and then look at `/all_dbs` and notice all the dbs like `random-test-db--576460750833332000--576460752303423488_src` etc.
   
   After deleting those test dbs, apply this PR and run the tests again: all replication dbs should have been cleaned up.
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services