You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2011/10/08 19:42:40 UTC
svn commit: r1180423 - in
/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor:
./ fetch/
Author: norman
Date: Sat Oct 8 17:42:39 2011
New Revision: 1180423
URL: http://svn.apache.org/viewvc?rev=1180423&view=rev
Log:
Log "fatal" MailboxExceptions via info level. See IMAP-343
Modified:
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java Sat Oct 8 17:42:39 2011
@@ -90,7 +90,7 @@ public abstract class AbstractAuthProces
}
}
} catch (MailboxException e) {
- session.getLog().debug("Login failed", e);
+ session.getLog().info("Login failed", e);
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java Sat Oct 8 17:42:39 2011
@@ -212,10 +212,10 @@ abstract public class AbstractMailboxPro
final Collection<Long> flagUpdateUids = selected.flagUpdateUids();
if (!flagUpdateUids.isEmpty()) {
- Iterator<MessageRange> ranges = MessageRange.toRanges(flagUpdateUids).iterator();
- while(ranges.hasNext()) {
- addFlagsResponses(session, selected, responder, useUid, ranges.next(), mailbox, mailboxSession);
- }
+ Iterator<MessageRange> ranges = MessageRange.toRanges(flagUpdateUids).iterator();
+ while(ranges.hasNext()) {
+ addFlagsResponses(session, selected, responder, useUid, ranges.next(), mailbox, mailboxSession);
+ }
}
} catch (MailboxException e) {
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java Sat Oct 8 17:42:39 2011
@@ -25,8 +25,6 @@ import java.util.Collections;
import java.util.Iterator;
import java.util.List;
-import javax.mail.Flags;
-
import org.apache.james.imap.api.ImapCommand;
import org.apache.james.imap.api.ImapConstants;
import org.apache.james.imap.api.ImapMessage;
@@ -43,7 +41,6 @@ import org.apache.james.imap.api.process
import org.apache.james.imap.message.request.AbstractMailboxSelectionRequest;
import org.apache.james.imap.message.response.ExistsResponse;
import org.apache.james.imap.message.response.RecentResponse;
-import org.apache.james.imap.processor.base.FetchGroupImpl;
import org.apache.james.imap.processor.base.SelectedMailboxImpl;
import org.apache.james.mailbox.MailboxException;
import org.apache.james.mailbox.MailboxManager;
@@ -51,13 +48,11 @@ import org.apache.james.mailbox.MailboxN
import org.apache.james.mailbox.MailboxPath;
import org.apache.james.mailbox.MailboxSession;
import org.apache.james.mailbox.MessageManager;
+import org.apache.james.mailbox.MessageManager.MetaData;
import org.apache.james.mailbox.MessageManager.MetaData.FetchGroup;
+import org.apache.james.mailbox.MessageRange;
import org.apache.james.mailbox.MessageRangeException;
-import org.apache.james.mailbox.MessageResultIterator;
import org.apache.james.mailbox.SearchQuery;
-import org.apache.james.mailbox.MessageManager.MetaData;
-import org.apache.james.mailbox.MessageRange;
-import org.apache.james.mailbox.MessageResult;
abstract class AbstractSelectionProcessor<M extends AbstractMailboxSelectionRequest> extends AbstractMailboxProcessor<M> implements PermitEnableCapabilityProcessor {
@@ -93,10 +88,10 @@ abstract class AbstractSelectionProcesso
} catch (MailboxNotFoundException e) {
- session.getLog().debug("Select failed", e);
+ session.getLog().debug("Select failed as mailbox does not exist " + mailboxName, e);
responder.respond(statusResponseFactory.taggedNo(tag, command, HumanReadableText.FAILURE_NO_SUCH_MAILBOX));
} catch (MailboxException e) {
- session.getLog().debug("Select failed", e);
+ session.getLog().info("Select failed for mailbox " + mailboxName , e);
no(command, tag, responder, HumanReadableText.SELECT);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java Sat Oct 8 17:42:39 2011
@@ -66,9 +66,10 @@ public class AppendProcessor extends Abs
final InputStream messageIn = request.getMessage();
final Date datetime = request.getDatetime();
final Flags flags = request.getFlags();
+ final MailboxPath mailboxPath = buildFullPath(session, mailboxName);
+
try {
- final MailboxPath mailboxPath = buildFullPath(session, mailboxName);
final MailboxManager mailboxManager = getMailboxManager();
final MessageManager mailbox = mailboxManager.getMailbox(mailboxPath, ImapSessionUtils.getMailboxSession(session));
appendToMailbox(messageIn, datetime, flags, session, tag, command, mailbox, responder, mailboxPath);
@@ -76,7 +77,7 @@ public class AppendProcessor extends Abs
// consume message on exception
consume(messageIn);
- session.getLog().debug("Append failed", e);
+ session.getLog().debug("Append failed for mailbox " + mailboxPath, e);
// Indicates that the mailbox does not exist
// So TRY CREATE
@@ -86,7 +87,7 @@ public class AppendProcessor extends Abs
// consume message on exception
consume(messageIn);
- session.getLog().debug("Append failed", e);
+ session.getLog().info("Append failed for mailbox " + mailboxPath, e);
// Some other issue
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
@@ -156,7 +157,7 @@ public class AppendProcessor extends Abs
* e.getKey());
*/
} catch (MailboxException e) {
- session.getLog().debug("Unable to append message", e);
+ session.getLog().info("Unable to append message to mailbox " + mailboxPath, e);
// Some other issue
no(command, tag, responder, HumanReadableText.SAVE_FAILED);
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java Sat Oct 8 17:42:39 2011
@@ -55,7 +55,7 @@ public class CloseProcessor extends Abst
}
} catch (MailboxException e) {
- session.getLog().debug("Close failed", e);
+ session.getLog().info("Close failed for mailbox " + session.getSelected().getPath() , e);
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java Sat Oct 8 17:42:39 2011
@@ -100,10 +100,10 @@ public class CopyProcessor extends Abstr
okComplete(command, tag, ResponseCode.copyUid(uidValidity, idSet, resultUids), responder);
}
} catch (MessageRangeException e) {
- session.getLog().debug("Copy failed", e);
+ session.getLog().debug("Copy failed from mailbox " + currentMailbox.getPath() + " to " + targetMailbox + " for invalid sequence-set " + idSet.toString(), e);
taggedBad(command, tag, responder, HumanReadableText.INVALID_MESSAGESET);
} catch (MailboxException e) {
- session.getLog().debug("Copy failed", e);
+ session.getLog().info("Copy failed from mailbox " + currentMailbox.getPath() + " to " + targetMailbox + " for sequence-set " + idSet.toString(), e);
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java Sat Oct 8 17:42:39 2011
@@ -55,10 +55,10 @@ public class CreateProcessor extends Abs
unsolicitedResponses(session, responder, false);
okComplete(command, tag, responder);
} catch (MailboxExistsException e) {
- session.getLog().debug("Create failed", e);
+ session.getLog().debug("Create failed for mailbox " + mailboxPath + " as it already exists", e);
no(command, tag, responder, HumanReadableText.MAILBOX_EXISTS);
} catch (MailboxException e) {
- session.getLog().debug("Create failed", e);
+ session.getLog().info("Create failed for mailbox " + mailboxPath, e);
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java Sat Oct 8 17:42:39 2011
@@ -60,10 +60,10 @@ public class DeleteProcessor extends Abs
unsolicitedResponses(session, responder, false);
okComplete(command, tag, responder);
} catch (MailboxNotFoundException e) {
- session.getLog().debug("Delete failed", e);
+ session.getLog().debug("Delete failed for mailbox " + mailboxPath + " as it not exist", e);
no(command, tag, responder, HumanReadableText.FAILURE_NO_SUCH_MAILBOX);
} catch (MailboxException e) {
- session.getLog().debug("Delete failed", e);
+ session.getLog().info("Delete failed for mailbox " + mailboxPath, e);
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java Sat Oct 8 17:42:39 2011
@@ -71,6 +71,7 @@ public class EnableProcessor extends Abs
unsolicitedResponses(session, responder, false);
okComplete(command, tag, responder);
} catch (EnableException e) {
+ session.getLog().info("Unable to enable extension", e);
taggedBad(command, tag, responder, HumanReadableText.FAILED);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java Sat Oct 8 17:42:39 2011
@@ -94,7 +94,7 @@ public class ExpungeProcessor extends Ab
session.getLog().debug("Expunge failed", e);
taggedBad(command, tag, responder, HumanReadableText.INVALID_MESSAGESET);
} catch (MailboxException e) {
- session.getLog().debug("Expunge failed", e);
+ session.getLog().info("Expunge failed for mailbox " + session.getSelected().getPath(), e);
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java Sat Oct 8 17:42:39 2011
@@ -154,7 +154,7 @@ public class IdleProcessor extends Abstr
} catch (MailboxException e) {
- session.getLog().debug("Idle failed", e);
+ session.getLog().info("Enable idle for " + session.getSelected().getPath() + " failed", e);
// TODO: What should we do here?
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java Sat Oct 8 17:42:39 2011
@@ -124,12 +124,8 @@ public class LSubProcessor extends Abstr
}
okComplete(command, tag, responder);
-
- } catch (SubscriptionException e) {
- session.getLog().debug("LSub failed", e);
- no(command, tag, responder, HumanReadableText.GENERIC_LSUB_FAILURE);
} catch (MailboxException e) {
- session.getLog().debug("LSub failed", e);
+ session.getLog().info("LSub failed for reference " + referenceName + " and pattern " + mailboxPattern, e);
final HumanReadableText displayTextKey = HumanReadableText.GENERIC_LSUB_FAILURE;
no(command, tag, responder, displayTextKey);
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java Sat Oct 8 17:42:39 2011
@@ -174,7 +174,7 @@ public class ListProcessor extends Abstr
okComplete(command, tag, responder);
} catch (MailboxException e) {
- session.getLog().debug("List failed", e);
+ session.getLog().info("List failed", e);
no(command, tag, responder, HumanReadableText.SEARCH_FAILED);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java Sat Oct 8 17:42:39 2011
@@ -44,7 +44,7 @@ public class LogoutProcessor extends Abs
bye(responder);
okComplete(command, tag, responder);
} catch (MailboxException e) {
- session.getLog().debug("Logout failed", e);
+ session.getLog().info("Logout failed", e);
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java Sat Oct 8 17:42:39 2011
@@ -64,13 +64,13 @@ public class RenameProcessor extends Abs
okComplete(command, tag, responder);
unsolicitedResponses(session, responder, false);
} catch (MailboxExistsException e) {
- session.getLog().debug("Rename failed", e);
+ session.getLog().debug("Rename from " + existingPath + " to " + newPath + " failed because the target mailbox exists", e);
no(command, tag, responder, HumanReadableText.FAILURE_MAILBOX_EXISTS);
} catch (MailboxNotFoundException e) {
- session.getLog().debug("Rename failed", e);
+ session.getLog().debug("Rename from " + existingPath + " to " + newPath + " failed because the source mailbox not exists", e);
no(command, tag, responder, HumanReadableText.MAILBOX_NOT_FOUND);
} catch (MailboxException e) {
- session.getLog().debug("Rename failed", e);
+ session.getLog().info("Rename from " + existingPath + " to " + newPath + " failed", e);
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java Sat Oct 8 17:42:39 2011
@@ -197,10 +197,10 @@ public class SearchProcessor extends Abs
unsolicitedResponses(session, responder, omitExpunged, useUids);
okComplete(command, tag, responder);
} catch (MessageRangeException e) {
- session.getLog().debug("Search failed", e);
+ session.getLog().debug("Search failed in mailbox " + session.getSelected().getPath() + " because of an invalid sequence-set ", e);
taggedBad(command, tag, responder, HumanReadableText.INVALID_MESSAGESET);
} catch (MailboxException e) {
- session.getLog().debug("Search failed", e);
+ session.getLog().info("Search failed in mailbox " + session.getSelected().getPath(), e);
no(command, tag, responder, HumanReadableText.SEARCH_FAILED);
if (resultOptions.contains(SearchResultOption.SAVE)) {
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java Sat Oct 8 17:42:39 2011
@@ -89,7 +89,7 @@ public class StatusProcessor extends Abs
okComplete(command, tag, responder);
} catch (MailboxException e) {
- session.getLog().debug("Status failed", e);
+ session.getLog().info("Status failed for mailbox " + mailboxPath, e);
no(command, tag, responder, HumanReadableText.SEARCH_FAILED);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java Sat Oct 8 17:42:39 2011
@@ -193,10 +193,10 @@ public class StoreProcessor extends Abst
}
} catch (MessageRangeException e) {
- session.getLog().debug("Store failed", e);
+ session.getLog().debug("Store failed for mailbox " + session.getSelected().getPath() + " because of an invalid sequence-set " + idSet.toString(), e);
taggedBad(imapCommand, tag, responder, HumanReadableText.INVALID_MESSAGESET);
} catch (MailboxException e) {
- session.getLog().debug("Store failed", e);
+ session.getLog().info("Store failed for mailbox " + session.getSelected().getPath(), e);
no(imapCommand, tag, responder, HumanReadableText.SAVE_FAILED);
}
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java Sat Oct 8 17:42:39 2011
@@ -56,7 +56,7 @@ public class SubscribeProcessor extends
okComplete(command, tag, responder);
} catch (SubscriptionException e) {
- session.getLog().debug("Subscribe failed", e);
+ session.getLog().info("Subscribe failed for mailbox " + mailboxName, e);
unsolicitedResponses(session, responder, false);
no(command, tag, responder, HumanReadableText.GENERIC_SUBSCRIPTION_FAILURE);
}
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java Sat Oct 8 17:42:39 2011
@@ -56,7 +56,7 @@ public class UnsubscribeProcessor extend
okComplete(command, tag, responder);
} catch (SubscriptionException e) {
- session.getLog().debug("Unsubscribe failed", e);
+ session.getLog().info("Unsubscribe failed for mailbox " + mailboxName, e);
unsolicitedResponses(session, responder, false);
no(command, tag, responder, HumanReadableText.GENERIC_SUBSCRIPTION_FAILURE);
Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java Sat Oct 8 17:42:39 2011
@@ -128,11 +128,11 @@ public class FetchProcessor extends Abst
unsolicitedResponses(session, responder, omitExpunged, useUids);
okComplete(command, tag, responder);
} catch (MessageRangeException e) {
- session.getLog().debug("Fetch failed", e);
+ session.getLog().debug("Fetch failed for mailbox " + session.getSelected().getPath() + " because of invalid sequence-set " + idSet.toString(), e);
taggedBad(command, tag, responder, HumanReadableText.INVALID_MESSAGESET);
} catch (MailboxException e) {
- session.getLog().debug("Fetch failed", e);
+ session.getLog().info("Fetch failed for mailbox " + session.getSelected().getPath() + " and sequence-set " + idSet.toString(), e);
no(command, tag, responder, HumanReadableText.SEARCH_FAILED);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: svn commit: r1180423 - in /james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor:
./ fetch/
Posted by Norman Maurer <no...@googlemail.com>.
true enough....
feel free to adjust....
bye
norman
Am Sonntag, 9. Oktober 2011 schrieb Eric Charles <er...@apache.org>:
> What about logging with error (getLog().error(...)).
> error will also be shown with INFO level.
>
> The HumanReadableText relate to FAILURE, so that sounds more like an
error...
>
> WDYT?
>
> Eric
>
>
> On 08/10/11 19:42, norman@apache.org wrote:
>
> Author: norman
> Date: Sat Oct 8 17:42:39 2011
> New Revision: 1180423
>
> URL: http://svn.apache.org/viewvc?rev=1180423&view=rev
> Log:
> Log "fatal" MailboxExceptions via info level. See IMAP-343
>
> Modified:
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java
>
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java
>
> Modified:
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java
> URL:
http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
>
==============================================================================
> ---
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java
(original)
> +++
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java
Sat Oct 8 17:42:39 2011
> @@ -90,7 +90,7 @@ public abstract class AbstractAuthProces
> }
> }
> } catch (MailboxException e) {
> - session.getLog().debug("Login failed", e);
> + session.getLog().info("Login failed", e);
> no(command, tag, responder,
HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
> }
>
> Modified:
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java
>
> --
> Eric
> http://about.echarles.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
Re: svn commit: r1180423 - in /james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor:
./ fetch/
Posted by Eric Charles <er...@apache.org>.
What about logging with error (getLog().error(...)).
error will also be shown with INFO level.
The HumanReadableText relate to FAILURE, so that sounds more like an
error...
WDYT?
Eric
On 08/10/11 19:42, norman@apache.org wrote:
> Author: norman
> Date: Sat Oct 8 17:42:39 2011
> New Revision: 1180423
>
> URL: http://svn.apache.org/viewvc?rev=1180423&view=rev
> Log:
> Log "fatal" MailboxExceptions via info level. See IMAP-343
>
> Modified:
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java
> james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java Sat Oct 8 17:42:39 2011
> @@ -90,7 +90,7 @@ public abstract class AbstractAuthProces
> }
> }
> } catch (MailboxException e) {
> - session.getLog().debug("Login failed", e);
> + session.getLog().info("Login failed", e);
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java Sat Oct 8 17:42:39 2011
> @@ -212,10 +212,10 @@ abstract public class AbstractMailboxPro
>
> final Collection<Long> flagUpdateUids = selected.flagUpdateUids();
> if (!flagUpdateUids.isEmpty()) {
> - Iterator<MessageRange> ranges = MessageRange.toRanges(flagUpdateUids).iterator();
> - while(ranges.hasNext()) {
> - addFlagsResponses(session, selected, responder, useUid, ranges.next(), mailbox, mailboxSession);
> - }
> + Iterator<MessageRange> ranges = MessageRange.toRanges(flagUpdateUids).iterator();
> + while(ranges.hasNext()) {
> + addFlagsResponses(session, selected, responder, useUid, ranges.next(), mailbox, mailboxSession);
> + }
>
> }
> } catch (MailboxException e) {
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java Sat Oct 8 17:42:39 2011
> @@ -25,8 +25,6 @@ import java.util.Collections;
> import java.util.Iterator;
> import java.util.List;
>
> -import javax.mail.Flags;
> -
> import org.apache.james.imap.api.ImapCommand;
> import org.apache.james.imap.api.ImapConstants;
> import org.apache.james.imap.api.ImapMessage;
> @@ -43,7 +41,6 @@ import org.apache.james.imap.api.process
> import org.apache.james.imap.message.request.AbstractMailboxSelectionRequest;
> import org.apache.james.imap.message.response.ExistsResponse;
> import org.apache.james.imap.message.response.RecentResponse;
> -import org.apache.james.imap.processor.base.FetchGroupImpl;
> import org.apache.james.imap.processor.base.SelectedMailboxImpl;
> import org.apache.james.mailbox.MailboxException;
> import org.apache.james.mailbox.MailboxManager;
> @@ -51,13 +48,11 @@ import org.apache.james.mailbox.MailboxN
> import org.apache.james.mailbox.MailboxPath;
> import org.apache.james.mailbox.MailboxSession;
> import org.apache.james.mailbox.MessageManager;
> +import org.apache.james.mailbox.MessageManager.MetaData;
> import org.apache.james.mailbox.MessageManager.MetaData.FetchGroup;
> +import org.apache.james.mailbox.MessageRange;
> import org.apache.james.mailbox.MessageRangeException;
> -import org.apache.james.mailbox.MessageResultIterator;
> import org.apache.james.mailbox.SearchQuery;
> -import org.apache.james.mailbox.MessageManager.MetaData;
> -import org.apache.james.mailbox.MessageRange;
> -import org.apache.james.mailbox.MessageResult;
>
> abstract class AbstractSelectionProcessor<M extends AbstractMailboxSelectionRequest> extends AbstractMailboxProcessor<M> implements PermitEnableCapabilityProcessor {
>
> @@ -93,10 +88,10 @@ abstract class AbstractSelectionProcesso
>
>
> } catch (MailboxNotFoundException e) {
> - session.getLog().debug("Select failed", e);
> + session.getLog().debug("Select failed as mailbox does not exist " + mailboxName, e);
> responder.respond(statusResponseFactory.taggedNo(tag, command, HumanReadableText.FAILURE_NO_SUCH_MAILBOX));
> } catch (MailboxException e) {
> - session.getLog().debug("Select failed", e);
> + session.getLog().info("Select failed for mailbox " + mailboxName , e);
> no(command, tag, responder, HumanReadableText.SELECT);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/AppendProcessor.java Sat Oct 8 17:42:39 2011
> @@ -66,9 +66,10 @@ public class AppendProcessor extends Abs
> final InputStream messageIn = request.getMessage();
> final Date datetime = request.getDatetime();
> final Flags flags = request.getFlags();
> + final MailboxPath mailboxPath = buildFullPath(session, mailboxName);
> +
> try {
>
> - final MailboxPath mailboxPath = buildFullPath(session, mailboxName);
> final MailboxManager mailboxManager = getMailboxManager();
> final MessageManager mailbox = mailboxManager.getMailbox(mailboxPath, ImapSessionUtils.getMailboxSession(session));
> appendToMailbox(messageIn, datetime, flags, session, tag, command, mailbox, responder, mailboxPath);
> @@ -76,7 +77,7 @@ public class AppendProcessor extends Abs
> // consume message on exception
> consume(messageIn);
>
> - session.getLog().debug("Append failed", e);
> + session.getLog().debug("Append failed for mailbox " + mailboxPath, e);
>
> // Indicates that the mailbox does not exist
> // So TRY CREATE
> @@ -86,7 +87,7 @@ public class AppendProcessor extends Abs
> // consume message on exception
> consume(messageIn);
>
> - session.getLog().debug("Append failed", e);
> + session.getLog().info("Append failed for mailbox " + mailboxPath, e);
>
> // Some other issue
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> @@ -156,7 +157,7 @@ public class AppendProcessor extends Abs
> * e.getKey());
> */
> } catch (MailboxException e) {
> - session.getLog().debug("Unable to append message", e);
> + session.getLog().info("Unable to append message to mailbox " + mailboxPath, e);
>
> // Some other issue
> no(command, tag, responder, HumanReadableText.SAVE_FAILED);
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CloseProcessor.java Sat Oct 8 17:42:39 2011
> @@ -55,7 +55,7 @@ public class CloseProcessor extends Abst
> }
>
> } catch (MailboxException e) {
> - session.getLog().debug("Close failed", e);
> + session.getLog().info("Close failed for mailbox " + session.getSelected().getPath() , e);
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java Sat Oct 8 17:42:39 2011
> @@ -100,10 +100,10 @@ public class CopyProcessor extends Abstr
> okComplete(command, tag, ResponseCode.copyUid(uidValidity, idSet, resultUids), responder);
> }
> } catch (MessageRangeException e) {
> - session.getLog().debug("Copy failed", e);
> + session.getLog().debug("Copy failed from mailbox " + currentMailbox.getPath() + " to " + targetMailbox + " for invalid sequence-set " + idSet.toString(), e);
> taggedBad(command, tag, responder, HumanReadableText.INVALID_MESSAGESET);
> } catch (MailboxException e) {
> - session.getLog().debug("Copy failed", e);
> + session.getLog().info("Copy failed from mailbox " + currentMailbox.getPath() + " to " + targetMailbox + " for sequence-set " + idSet.toString(), e);
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CreateProcessor.java Sat Oct 8 17:42:39 2011
> @@ -55,10 +55,10 @@ public class CreateProcessor extends Abs
> unsolicitedResponses(session, responder, false);
> okComplete(command, tag, responder);
> } catch (MailboxExistsException e) {
> - session.getLog().debug("Create failed", e);
> + session.getLog().debug("Create failed for mailbox " + mailboxPath + " as it already exists", e);
> no(command, tag, responder, HumanReadableText.MAILBOX_EXISTS);
> } catch (MailboxException e) {
> - session.getLog().debug("Create failed", e);
> + session.getLog().info("Create failed for mailbox " + mailboxPath, e);
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java Sat Oct 8 17:42:39 2011
> @@ -60,10 +60,10 @@ public class DeleteProcessor extends Abs
> unsolicitedResponses(session, responder, false);
> okComplete(command, tag, responder);
> } catch (MailboxNotFoundException e) {
> - session.getLog().debug("Delete failed", e);
> + session.getLog().debug("Delete failed for mailbox " + mailboxPath + " as it not exist", e);
> no(command, tag, responder, HumanReadableText.FAILURE_NO_SUCH_MAILBOX);
> } catch (MailboxException e) {
> - session.getLog().debug("Delete failed", e);
> + session.getLog().info("Delete failed for mailbox " + mailboxPath, e);
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/EnableProcessor.java Sat Oct 8 17:42:39 2011
> @@ -71,6 +71,7 @@ public class EnableProcessor extends Abs
> unsolicitedResponses(session, responder, false);
> okComplete(command, tag, responder);
> } catch (EnableException e) {
> + session.getLog().info("Unable to enable extension", e);
> taggedBad(command, tag, responder, HumanReadableText.FAILED);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ExpungeProcessor.java Sat Oct 8 17:42:39 2011
> @@ -94,7 +94,7 @@ public class ExpungeProcessor extends Ab
> session.getLog().debug("Expunge failed", e);
> taggedBad(command, tag, responder, HumanReadableText.INVALID_MESSAGESET);
> } catch (MailboxException e) {
> - session.getLog().debug("Expunge failed", e);
> + session.getLog().info("Expunge failed for mailbox " + session.getSelected().getPath(), e);
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/IdleProcessor.java Sat Oct 8 17:42:39 2011
> @@ -154,7 +154,7 @@ public class IdleProcessor extends Abstr
>
>
> } catch (MailboxException e) {
> - session.getLog().debug("Idle failed", e);
> + session.getLog().info("Enable idle for " + session.getSelected().getPath() + " failed", e);
> // TODO: What should we do here?
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LSubProcessor.java Sat Oct 8 17:42:39 2011
> @@ -124,12 +124,8 @@ public class LSubProcessor extends Abstr
> }
>
> okComplete(command, tag, responder);
> -
> - } catch (SubscriptionException e) {
> - session.getLog().debug("LSub failed", e);
> - no(command, tag, responder, HumanReadableText.GENERIC_LSUB_FAILURE);
> } catch (MailboxException e) {
> - session.getLog().debug("LSub failed", e);
> + session.getLog().info("LSub failed for reference " + referenceName + " and pattern " + mailboxPattern, e);
> final HumanReadableText displayTextKey = HumanReadableText.GENERIC_LSUB_FAILURE;
> no(command, tag, responder, displayTextKey);
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/ListProcessor.java Sat Oct 8 17:42:39 2011
> @@ -174,7 +174,7 @@ public class ListProcessor extends Abstr
>
> okComplete(command, tag, responder);
> } catch (MailboxException e) {
> - session.getLog().debug("List failed", e);
> + session.getLog().info("List failed", e);
> no(command, tag, responder, HumanReadableText.SEARCH_FAILED);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/LogoutProcessor.java Sat Oct 8 17:42:39 2011
> @@ -44,7 +44,7 @@ public class LogoutProcessor extends Abs
> bye(responder);
> okComplete(command, tag, responder);
> } catch (MailboxException e) {
> - session.getLog().debug("Logout failed", e);
> + session.getLog().info("Logout failed", e);
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/RenameProcessor.java Sat Oct 8 17:42:39 2011
> @@ -64,13 +64,13 @@ public class RenameProcessor extends Abs
> okComplete(command, tag, responder);
> unsolicitedResponses(session, responder, false);
> } catch (MailboxExistsException e) {
> - session.getLog().debug("Rename failed", e);
> + session.getLog().debug("Rename from " + existingPath + " to " + newPath + " failed because the target mailbox exists", e);
> no(command, tag, responder, HumanReadableText.FAILURE_MAILBOX_EXISTS);
> } catch (MailboxNotFoundException e) {
> - session.getLog().debug("Rename failed", e);
> + session.getLog().debug("Rename from " + existingPath + " to " + newPath + " failed because the source mailbox not exists", e);
> no(command, tag, responder, HumanReadableText.MAILBOX_NOT_FOUND);
> } catch (MailboxException e) {
> - session.getLog().debug("Rename failed", e);
> + session.getLog().info("Rename from " + existingPath + " to " + newPath + " failed", e);
> no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SearchProcessor.java Sat Oct 8 17:42:39 2011
> @@ -197,10 +197,10 @@ public class SearchProcessor extends Abs
> unsolicitedResponses(session, responder, omitExpunged, useUids);
> okComplete(command, tag, responder);
> } catch (MessageRangeException e) {
> - session.getLog().debug("Search failed", e);
> + session.getLog().debug("Search failed in mailbox " + session.getSelected().getPath() + " because of an invalid sequence-set ", e);
> taggedBad(command, tag, responder, HumanReadableText.INVALID_MESSAGESET);
> } catch (MailboxException e) {
> - session.getLog().debug("Search failed", e);
> + session.getLog().info("Search failed in mailbox " + session.getSelected().getPath(), e);
> no(command, tag, responder, HumanReadableText.SEARCH_FAILED);
>
> if (resultOptions.contains(SearchResultOption.SAVE)) {
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StatusProcessor.java Sat Oct 8 17:42:39 2011
> @@ -89,7 +89,7 @@ public class StatusProcessor extends Abs
> okComplete(command, tag, responder);
>
> } catch (MailboxException e) {
> - session.getLog().debug("Status failed", e);
> + session.getLog().info("Status failed for mailbox " + mailboxPath, e);
> no(command, tag, responder, HumanReadableText.SEARCH_FAILED);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/StoreProcessor.java Sat Oct 8 17:42:39 2011
> @@ -193,10 +193,10 @@ public class StoreProcessor extends Abst
>
> }
> } catch (MessageRangeException e) {
> - session.getLog().debug("Store failed", e);
> + session.getLog().debug("Store failed for mailbox " + session.getSelected().getPath() + " because of an invalid sequence-set " + idSet.toString(), e);
> taggedBad(imapCommand, tag, responder, HumanReadableText.INVALID_MESSAGESET);
> } catch (MailboxException e) {
> - session.getLog().debug("Store failed", e);
> + session.getLog().info("Store failed for mailbox " + session.getSelected().getPath(), e);
> no(imapCommand, tag, responder, HumanReadableText.SAVE_FAILED);
> }
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/SubscribeProcessor.java Sat Oct 8 17:42:39 2011
> @@ -56,7 +56,7 @@ public class SubscribeProcessor extends
> okComplete(command, tag, responder);
>
> } catch (SubscriptionException e) {
> - session.getLog().debug("Subscribe failed", e);
> + session.getLog().info("Subscribe failed for mailbox " + mailboxName, e);
> unsolicitedResponses(session, responder, false);
> no(command, tag, responder, HumanReadableText.GENERIC_SUBSCRIPTION_FAILURE);
> }
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/UnsubscribeProcessor.java Sat Oct 8 17:42:39 2011
> @@ -56,7 +56,7 @@ public class UnsubscribeProcessor extend
> okComplete(command, tag, responder);
>
> } catch (SubscriptionException e) {
> - session.getLog().debug("Unsubscribe failed", e);
> + session.getLog().info("Unsubscribe failed for mailbox " + mailboxName, e);
> unsolicitedResponses(session, responder, false);
>
> no(command, tag, responder, HumanReadableText.GENERIC_SUBSCRIPTION_FAILURE);
>
> Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java
> URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java?rev=1180423&r1=1180422&r2=1180423&view=diff
> ==============================================================================
> --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java (original)
> +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java Sat Oct 8 17:42:39 2011
> @@ -128,11 +128,11 @@ public class FetchProcessor extends Abst
> unsolicitedResponses(session, responder, omitExpunged, useUids);
> okComplete(command, tag, responder);
> } catch (MessageRangeException e) {
> - session.getLog().debug("Fetch failed", e);
> + session.getLog().debug("Fetch failed for mailbox " + session.getSelected().getPath() + " because of invalid sequence-set " + idSet.toString(), e);
>
> taggedBad(command, tag, responder, HumanReadableText.INVALID_MESSAGESET);
> } catch (MailboxException e) {
> - session.getLog().debug("Fetch failed", e);
> + session.getLog().info("Fetch failed for mailbox " + session.getSelected().getPath() + " and sequence-set " + idSet.toString(), e);
> no(command, tag, responder, HumanReadableText.SEARCH_FAILED);
> }
> }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
--
Eric
http://about.echarles.net
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org