You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/12/01 06:32:40 UTC

[GitHub] incubator-zeppelin pull request: ZEPPELIN-442: utilize space betwe...

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/447#issuecomment-160858227
  
    Okay, I tested it again and saw things to improve.
    
    Originally the insertParagraph method (used in the menu) is adding a paragraph under the actual one, however with your changes, it always add that paragraph before. And while changing that could be discussed, it would be good for now to not change the behavior users are used to.
    
    So, instead of having that ``lastPragraph`` parameter, we could have a position parameter with values like _under_ and _upper_. This way, if we call ``insertParagraph('upper')`` it would do ``newIndex = i;`` and `insertParagraph('under')`` would do ``newIndex = i + 1;``



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---