[jira] [Commented] (THRIFT-5414) Use of specific parameter names generates uncompileable code

["Thomas Bruggink (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344966#comment-17344966 ] 

Thomas Bruggink commented on THRIFT-5414:
-----------------------------------------

This is about the thrift compiler generating code for netstd that does not compile. I mentioned Java because the same thrift file does generate compilable Java code.
The problem seems to be here https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_netstd_generator.cc#L2072 and https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_netstd_generator.cc#L2079 here where the generated code assumes the variable names x and result are not being used by the user.

> Use of specific parameter names generates uncompileable code
> ------------------------------------------------------------
>
>                 Key: THRIFT-5414
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5414
>             Project: Thrift
>          Issue Type: Bug
>          Components: netstd - Compiler
>            Reporter: Thomas Bruggink
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The csharp service client generator creates some local variables that prevent the usage of those names in the Thrift file.
>  For example the following thrift file breaks:
> {code:c++}
> service Test {
>     void Calculate( 
> 		1 : i32 x, # This breaks because the variable name x is the same as the TApplicationException variable name x
> 		2 : i32 result, # This breaks because the variable name result is the same as the InternalStructs variable name result
> 	)
> }
> {code}
> The above example will generate the following C# code which does not compile because x and result are also used below:
> {code:c#}
> public async global::System.Threading.Tasks.Task Calculate(int x, int result, CancellationToken cancellationToken = default)
> {
>     await OutputProtocol.WriteMessageBeginAsync(new TMessage("Calculate", TMessageType.Call, SeqId), cancellationToken);
>     
>     var args = new InternalStructs.CalculateArgs() {
>         X = x,
>         Result = result,
>     };
>     
>     await args.WriteAsync(OutputProtocol, cancellationToken);
>     await OutputProtocol.WriteMessageEndAsync(cancellationToken);
>     await OutputProtocol.Transport.FlushAsync(cancellationToken);
>     
>     var msg = await InputProtocol.ReadMessageBeginAsync(cancellationToken);
>     if (msg.Type == TMessageType.Exception)
>     {
>         var x = await TApplicationException.ReadAsync(InputProtocol, cancellationToken);
>         await InputProtocol.ReadMessageEndAsync(cancellationToken);
>         throw x;
>     }
>     var result = new InternalStructs.CalculateResult();
>     await result.ReadAsync(InputProtocol, cancellationToken);
>     await InputProtocol.ReadMessageEndAsync(cancellationToken);
>     return;
> }
> {code}
> When compiling this code with `-gen java` the generated sources build fine.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)