You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2019/11/19 02:05:47 UTC

[GitHub] [madlib] reductionista commented on a change in pull request #459: DL: Add support for asymmetric segment distribution to preprocessor

reductionista commented on a change in pull request #459: DL: Add support for asymmetric segment distribution to preprocessor
URL: https://github.com/apache/madlib/pull/459#discussion_r347635180
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/input_data_preprocessor.sql_in
 ##########
 @@ -707,7 +707,8 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.validation_preprocessor_dl(
     dependent_varname           VARCHAR,
     independent_varname         VARCHAR,
     training_preprocessor_table VARCHAR,
-    buffer_size                 INTEGER
+    buffer_size                 INTEGER,
+    distribution_rules          TEXT
 ) RETURNS VOID AS $$
     PythonFunctionBodyOnly(deep_learning, input_data_preprocessor)
     from utilities.control import MinWarning
 
 Review comment:
   The documentation (near line 70 in this file) should be updated to reflex the new parameter.  (I can't figure out an easy way to get github to let me comment on line 70, so leaving this comment here.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services