You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/05 15:07:28 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue #11669: Make governance from independent config to plugged rules

terrymanu opened a new issue #11669:
URL: https://github.com/apache/shardingsphere/issues/11669


   The governance module is the master feature in the product. 
   I just consider about refactor it to plugged features by the plugged architecture.
   
   The current YAML configuration is:
   
   ```yaml
   governance:
     registryCenter:
       type: ZooKeeper
       namespace: governance_ds
       serverLists: localhost:2181
     overwrite: false
   
   rules:
     - !AUTHORITY
       users:
         - root@%:root
       provider:
         type: NATIVE
   ```
   
   It should be changed to:
   
   ```yaml
   rules:
     - !AUTHORITY
       users:
         - root@%:root
       provider:
         type: NATIVE
     
     - !GOVERNANCE
       registryCenter:
         type: ZooKeeper
         namespace: governance_ds
         serverLists: localhost:2181
       overwrite: false
   ```
   
   The tasks are:
   
   - [ ] Proxy YAML configuration change
   - [ ] JDBC YAML configuration change
   - [ ] JDBC java API change
   - [ ] JDBC spring namespace change
   - [ ] JDBC spring boot starter change
   - [ ] Move governance module from top level to the submodule of feature
   - [ ] Adjust DistMetadataPersistService as plugged rule
   - [ ] Resolve conflict if independent DistMetadataPersistService rule and governance rule in the same config file
   
   After finish all tasks, I prefer to discuss about change governance module name to cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #11669: Make governance from independent config to plugged rules

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #11669:
URL: https://github.com/apache/shardingsphere/issues/11669#issuecomment-895022023


   We need to redesign here, just relate with #11709


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #11669: Make governance from independent config to plugged rules

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #11669:
URL: https://github.com/apache/shardingsphere/issues/11669#issuecomment-895299319


   I just close this issue because the design is changed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu closed issue #11669: Make governance from independent config to plugged rules

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #11669:
URL: https://github.com/apache/shardingsphere/issues/11669


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org