You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "rob05c (GitHub)" <gi...@apache.org> on 2018/08/27 01:46:13 UTC
[GitHub] [trafficcontrol] rob05c opened pull request #2751: WIP
Change Traffic Ops Go CRUDer to use Generic Funcs
WIP - Don't Merge! I haven't tested this thoroughly (though unit tests pass).
This serves as an example of using generic functions to create, read, update, and delete.
It basically removes 2,000 lines of duplicate code, essentially half of the CRUD handlers.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "rob05c (GitHub)" <gi...@apache.org>.
retest this please
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2406/
Test PASSed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2376/
Test PASSed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] DylanVolz closed pull request #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "DylanVolz (GitHub)" <gi...@apache.org>.
[ pull request closed by DylanVolz ]
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "rob05c (GitHub)" <gi...@apache.org>.
Removed WIP - the API tests all pass now, this should be good to merge.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2391/
Test FAILed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: WIP Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2334/
Test PASSed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "rob05c (GitHub)" <gi...@apache.org>.
@DylanVolz Changed, removed Txx/Tx alias.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "rob05c (GitHub)" <gi...@apache.org>.
@DylanVolz The `Tx` and `Txx` thing was really just a convenience. I feel pretty strongly though, about keeping bottom-level funcs that don't need `sqlx` using standard Go, to maintain vendor-agnosticism where possible, and where it doesn't hurt and callers can easily pass `Tx.Tx`.
Would you be ok with a middle ground, if I removed the `Tx` vs `Txx` thing, but still kept low-level things using `sql.Tx` and being given `Tx.Tx`?
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2397/
Test FAILed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #2751: WIP Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "rob05c (GitHub)" <gi...@apache.org>.
@DylanVolz Thoughts?
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "rob05c (GitHub)" <gi...@apache.org>.
retest this please
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: WIP Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2335/
Test PASSed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: WIP Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2336/
Test PASSed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2390/
Test FAILed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2403/
Test FAILed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] asfgit commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2398/
Test FAILed.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficcontrol] DylanVolz commented on issue #2751: Change
Traffic Ops Go CRUDer to use Generic Funcs
Posted by "DylanVolz (GitHub)" <gi...@apache.org>.
Yeah that middle ground works for me it removes the complexity in the ApiInfo object.
[ Full content available at: https://github.com/apache/trafficcontrol/pull/2751 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org