You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by lindzh <gi...@git.apache.org> on 2017/07/06 06:53:58 UTC
[GitHub] incubator-rocketmq pull request #129: [ROCKETMQ-239]fix query message by tim...
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/129
[ROCKETMQ-239]fix query message by time and fix get queue offset by time
When using queryMessageByTime or searchOffsetByTime or resetOffsetByTime , DefaultMessageStore return offset is not so accurate as we want.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lindzh/incubator-rocketmq fix_query_message_by_time
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/129.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #129
----
commit c37adb566f7c0ee9920def4e9cfd02579e6ce4cf
Author: lindzh <li...@163.com>
Date: 2017-07-06T06:44:22Z
fix query message by time and fix get queue offset by time
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12271475)
Coverage increased (+0.3%) to 39.417% when pulling **c37adb566f7c0ee9920def4e9cfd02579e6ce4cf on lindzh:fix_query_message_by_time** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12760428)
Coverage increased (+0.5%) to 39.627% when pulling **a8835c401df884ec2a4006331770794db0aee8be on lindzh:fix_query_message_by_time** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12334616)
Coverage increased (+0.4%) to 39.511% when pulling **2c24b6777b2f0d0a85e1e8b0b2f64b1c00d184ef on lindzh:fix_query_message_by_time** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12771891)
Coverage increased (+0.6%) to 39.7% when pulling **f2f2fba2432534e0fddc316f078e6f3257668c2c on lindzh:fix_query_message_by_time** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12791061)
Coverage increased (+0.6%) to 39.711% when pulling **d1f2b9d6bcd7324774a0cc75ee577a1726ff9505 on lindzh:fix_query_message_by_time** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12817918)
Coverage increased (+0.6%) to 39.637% when pulling **e3988d3fa66a76ec228f2c00682d6bc0797ced5e on lindzh:fix_query_message_by_time** into **332df78e2bb6caadfc6f4714450000ebb1f9d224 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #129: [ROCKETMQ-239]fix query message by tim...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/129#discussion_r140684767
--- Diff: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java ---
@@ -151,7 +151,7 @@ public void recover() {
}
}
- public long getOffsetInQueueByTime(final long timestamp) {
+ public long getOffsetInQueueByTime(final long timestamp, boolean isGetTimeLast) {
MappedFile mappedFile = this.mappedFileQueue.getMappedFileByTime(timestamp);
--- End diff --
It is not reliable to get mapped file by modification time, as if the dispatch service fall behind too much, it may get the wrong mapped file.
How about checking each file's first message and last message it pointed to?
This may cause performance loss, but it is acceptable, for such api is used only for some specific diagnoses. It is rarely used, but when using it, it'd better to return the exactly correct result.
---
[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12760428)
Coverage increased (+0.5%) to 39.627% when pulling **a8835c401df884ec2a4006331770794db0aee8be on lindzh:fix_query_message_by_time** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12791570)
Coverage increased (+0.6%) to 39.648% when pulling **8302bb878afb37c199fbfa6659b2cc7f0168e43a on lindzh:fix_query_message_by_time** into **aa1c75774eb33fca9a1c3f036249b6c5b86ef0f5 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---