You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/25 15:07:53 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #2105: bt_hcicore.c: Fix wrong order of bt_send() and setting last command sent

v01d opened a new pull request #2105:
URL: https://github.com/apache/incubator-nuttx/pull/2105


   ## Summary
   
   In `hci_tx_kthread()` of `bt_hcicore.c` the `g_btdev.sent_cmd = buf;` line was after the actual send and this breaks the `cmd_complete` handling since this assumes by the time it is called this variable is already set. This is due to the fact that the response is generated on the same callback that handles the reception of this message.
   
   ## Impact
   
   Fixes HCI initialization failure (#2084)
   
   ## Testing
   
   sim:bluetooth (uses bt_null driver)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2105: bt_hcicore.c: Fix wrong order of bt_send() and setting last command sent

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2105:
URL: https://github.com/apache/incubator-nuttx/pull/2105


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org