[jira] Commented: (SLING-214) RequestLogger logs incorrect information

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577395#action_12577395 ] 

Felix Meschberger commented on SLING-214:
-----------------------------------------

Refactored the RequestLoggerFilter into a RequestLogger class which is now registered as an OSGi service and directly referred to by the SlingMainServlet to log request entry and request exit.

LoggerResonse functionality - gathering all status, cookies, headers as well as data counting output channels - merged into SlingHttpServletResponseImpl.

Modified the RequestData to only require the ResourceResolver instance with the initResource method. In addition populating now the RequestProgressTracker with timing information on resource and servlet resolution.

Implemented in Rev. 635888

> RequestLogger logs incorrect information
> ----------------------------------------
>
>                 Key: SLING-214
>                 URL: https://issues.apache.org/jira/browse/SLING-214
>             Project: Sling
>          Issue Type: Bug
>          Components: Core
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: 2.0.0
>
>
> The RequestLogger is currently implemented as a Request Level filter. In case of uncaught runtime exceptions, this logger may log incorrect information, that is a positive status 200 may be logged instead of the actual 500 (internal server error) caused by the runtime exception.
> The fix is to actually not implement the request logger as a request level filter but simply "around" the SlingMainServlet.service method, such that we may get the correct information, which may be injected by the error handler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.