You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/10/18 14:52:09 UTC

[GitHub] [lucene] mocobeta commented on a change in pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

mocobeta commented on a change in pull request #391:
URL: https://github.com/apache/lucene/pull/391#discussion_r731013013



##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -1033,7 +1030,7 @@ def confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
   os.chdir(unpackPath)
 
   print('    run TestBackwardsCompatibility..')
-  command = 'gradlew test -p lucene/backward-codecs --tests TestBackwardsCompatibility --max-workers=1 ' \
+  command = './gradlew test -p lucene/backward-codecs --tests TestBackwardsCompatibility --max-workers=1 ' \

Review comment:
       Is this work on Windows?
   I haven't tried it on Windows but just noticed this script doesn't append `./` to commands in branch_8x.
   For example:
   https://github.com/apache/lucene-solr/blob/277e1e064559117ccbc3004be88160bf24380d55/dev-tools/scripts/smokeTestRelease.py#L1326




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org