You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joe Lee <jo...@gmail.com> on 2015/03/12 15:18:09 UTC
Review Request 31988: Do not have search filter input field disappear
when query yields no results
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31988/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-2479
https://issues.apache.org/jira/browse/MESOS-2479
Repository: mesos
Description
-------
Do not have search filter input field disappear when query yields no results
Diffs
-----
src/webui/master/static/directives/tableHeader.html ad64864c0ab76165286c4f05a7af1245d7b09196
Diff: https://reviews.apache.org/r/31988/diff/
Testing
-------
Thanks,
Joe Lee
Re: Review Request 31988: Do not have search filter input field
disappear when query yields no results
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31988/#review76250
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31988]
All tests passed.
- Mesos ReviewBot
On March 12, 2015, 2:18 p.m., Joe Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31988/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 2:18 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2479
> https://issues.apache.org/jira/browse/MESOS-2479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not have search filter input field disappear when query yields no results
>
>
> Diffs
> -----
>
> src/webui/master/static/directives/tableHeader.html ad64864c0ab76165286c4f05a7af1245d7b09196
>
> Diff: https://reviews.apache.org/r/31988/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Lee
>
>
Re: Review Request 31988: Do not have search filter input field
disappear when query yields no results
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31988/#review76270
-----------------------------------------------------------
I'd love to help land this for you.
Would you mind describing how this fixes the issue, how you tested this, and include screenshots if possible? Thank you!
- Ben Mahler
On March 12, 2015, 2:18 p.m., Joe Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31988/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 2:18 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2479
> https://issues.apache.org/jira/browse/MESOS-2479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not have search filter input field disappear when query yields no results
>
>
> Diffs
> -----
>
> src/webui/master/static/directives/tableHeader.html ad64864c0ab76165286c4f05a7af1245d7b09196
>
> Diff: https://reviews.apache.org/r/31988/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Lee
>
>