You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2023/08/30 16:52:50 UTC

[GitHub] [superset] sfirke opened a new pull request, #25129: refactor(frontend): make "Search" box the first filter for charts and datasets

sfirke opened a new pull request, #25129:
URL: https://github.com/apache/superset/pull/25129

   ### SUMMARY
   Continues https://github.com/apache/superset/pull/19721, making that same change for Charts and Datasets for consistency.
   
   Fixes https://github.com/apache/superset/issues/25128.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **BEFORE**
   
   ![image](https://github.com/apache/superset/assets/7569808/36cd9002-9dbc-4747-b6ef-c2e8e0d162e6)
   ![image](https://github.com/apache/superset/assets/7569808/ac5c6fe9-4bad-4513-9c1b-6022cecd16d0)
   
   **AFTER**
   ![image](https://github.com/apache/superset/assets/7569808/eb279f4a-a77c-4cd8-8066-9584636603c3)
   ![image](https://github.com/apache/superset/assets/7569808/3439e0aa-81d4-4d80-9312-cd2f8348d40a)
   
   
   ### TESTING INSTRUCTIONS
   Compare before & after.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   - [x] Has associated issue: fixes #25128
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] sfirke merged pull request #25129: refactor(frontend): make "Search" box the first filter for charts and datasets

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #25129:
URL: https://github.com/apache/superset/pull/25129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] sfirke commented on pull request #25129: refactor(frontend): make "Search" box the first filter for charts and datasets

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #25129:
URL: https://github.com/apache/superset/pull/25129#issuecomment-1699546701

   cc @michael-s-molina in case you think this would be suitable to cherrypick for 3.0.0rc4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org