You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2024/11/15 16:44:05 UTC
(superset) branch master updated: fix: blocks UI elements on right side (#30886)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new df479940a6 fix: blocks UI elements on right side (#30886)
df479940a6 is described below
commit df479940a6afdff36826042a1923ed804cbfe337
Author: Sukuna <90...@users.noreply.github.com>
AuthorDate: Fri Nov 15 22:13:57 2024 +0530
fix: blocks UI elements on right side (#30886)
Co-authored-by: Evan Rusackas <ev...@preset.io>
---
.../components/gridComponents/ChartHolder.tsx | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx b/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx
index 2f4a77c39b..d31e240e4f 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx
@@ -21,7 +21,7 @@ import { useState, useMemo, useCallback, useEffect } from 'react';
import { ResizeCallback, ResizeStartCallback } from 're-resizable';
import cx from 'classnames';
import { useSelector } from 'react-redux';
-import { css } from '@superset-ui/core';
+import { css, useTheme } from '@superset-ui/core';
import { LayoutItem, RootState } from 'src/dashboard/types';
import AnchorLink from 'src/dashboard/components/AnchorLink';
import Chart from 'src/dashboard/containers/Chart';
@@ -70,15 +70,6 @@ interface ChartHolderProps {
isInView: boolean;
}
-const fullSizeStyle = css`
- && {
- position: fixed;
- z-index: 3000;
- left: 0;
- top: 0;
- }
-`;
-
const ChartHolder: React.FC<ChartHolderProps> = ({
id,
parentId,
@@ -102,6 +93,16 @@ const ChartHolder: React.FC<ChartHolderProps> = ({
setFullSizeChartId,
isInView,
}) => {
+ const theme = useTheme();
+ const fullSizeStyle = css`
+ && {
+ position: fixed;
+ z-index: 3000;
+ left: 0;
+ top: 0;
+ padding: ${theme.gridUnit * 2}px;
+ }
+ `;
const { chartId } = component.meta;
const isFullSize = fullSizeChartId === chartId;