You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/11 11:16:35 UTC

[GitHub] [incubator-nuttx] fjpanag edited a comment on pull request #1561: Fix in STM32F4 over-drive configuration.

fjpanag edited a comment on pull request #1561:
URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-671884881


   Hi @davids5 
   
   Indeed STM32F437, STM32F439, STM32F479 are not included in Kconfig. I can remove those.
   Certainly STM32F427 was missing though...
   
   PWR_CR_VOS is not affected. It is a requirement though to be set to scale 1 or 2 only when over-drive is enabled. Currently it is set to scale 1 specifically, so this change shouldn't be a problem. It would be best to have PWR_CR_VOS configurable in Kconfig, but this is another PR...
   
   Indeed the code previously was not checking the frequency before enabling over-drive. So I left it as is. But then also PWR_CR_VOS is not configurable...
   
   I will check a bit later regarding STM32_HAS_OVERDRIVE.
   I am will somehow improve this PR, and then maybe work separately on making power scale and over-drive configurable, as it may affect other MCUs than just the STM32F4.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org