You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/09/10 15:18:42 UTC

[GitHub] [accumulo] jkosh44 commented on issue #1643: Rename master references in public API

jkosh44 commented on issue #1643:
URL: https://github.com/apache/accumulo/issues/1643#issuecomment-690360318


   I have a couple questions on this. 
   
   - Do we just want to change the method names or all references? 
   - What about variable names, enum values, and constants? 
   - Do we just care about public API methods are do we also want to change internal methods? 
   - What about class names? For example `MasterClient`. One solution could be to refactor this to `ManagerClient`, then have a subclass called `MasterClient` that just delegates all methods to `ManagerClient`.
   - It looks like there are some files called master or that have the word master in it (https://github.com/apache/accumulo/blob/main/minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java#L56 for example). How should those be treated? It seems like renaming the file could break existing instances.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org