You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2026/07/24 18:48:15 UTC
[PR] ci: pass env vars down into cibuildwheel container [arrow-adbc]
amoeba opened a new pull request, #4585:
URL: https://github.com/apache/arrow-adbc/pull/4585
This PR makes the filenames of our driver manager wheel nightlies consistent. While nightlies are not official project artifacts and users should never depend on them, it's nice to make them a bit easier to use.
As noticed in https://github.com/apache/arrow-adbc/issues/4578, the manylinux wheels for the driver manager use a `.dev0` prefix whereas all other wheels just use the MAJOR.MINOR.PATCH. The driver manager manylinux wheels are special in that they go through cibuildwheel and cibuildwheel uses an inner container for its build. To get a consistent version, we need let cibuildwheel pass `SETUPTOOLS_SCM_PRETEND_VERSION` into the container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: pass env vars down into cibuildwheel container [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #4585:
URL: https://github.com/apache/arrow-adbc/pull/4585#issuecomment-5073687387
This looks good to me. I compared the wheel filenames between a run with and without this change.
CI run before: https://github.com/apache/arrow-adbc/actions/runs/30089666671/job/89469920732
CI run with this PR: https://github.com/apache/arrow-adbc/actions/runs/30118343805/job/89564523415
In each CI run, I downloaded the artifacts from the "Archive wheels" step and compared them to show this PR fixes the filename inconsistency:
```sh
# without this change
$ ls -1 python-amd64-manylinux-before/adbc_driver_manager/repaired_wheels/
adbc_driver_manager-1.12.0.dev0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp312-cp312-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp313-cp313-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp314-cp314-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp314-cp314t-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
# with this change, wheels no longer have `.dev0`
$ ls -1 python-amd64-manylinux-after/adbc_driver_manager/repaired_wheels/
adbc_driver_manager-1.12.0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp312-cp312-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp313-cp313-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp314-cp314-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp314-cp314t-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: pass env vars down into cibuildwheel container [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #4585:
URL: https://github.com/apache/arrow-adbc/pull/4585#issuecomment-5073376647
Converted to draft until I can verify this fixes the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: pass env vars down into cibuildwheel container [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #4585:
URL: https://github.com/apache/arrow-adbc/pull/4585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org