[GitHub] [kafka] cmccabe commented on pull request #11386: MINOR: Fix highest offset when loading KRaft metadata snapshots

[GitBox <gi...@apache.org>]

cmccabe commented on pull request #11386:
URL: https://github.com/apache/kafka/pull/11386#issuecomment-940558999


   > When loading a snapshot the broker BrokerMetadataListener was using the batch's append time, offset and epoch. These are not the same as the append time, offset and epoch from the log. We must instead use the lastContainedLogTimeStamp, lastContainedLogOffset and lastContainedLogEpoch from the SnapshotReader.
   
   OK. If I understand correctly, this is the only bugfix here (that fixes incorrect behavior). The other points are refactors.
   
   > Include the highest offset and epoch into the MetadataImage and MetadataDelta. Adding the offset and epoch to MetadataImage is useful to version the image and to simplify the API. Adding the offset and epoch to MetadataDelta is needed to generate the MetadataImage.
   
   I guess this is reasonable, since we might like to print this for debugging purposes (for example).
   
   > Swapped the order of the arguments for ReplicaManager.applyDelta for consistency to match the order of the arguments for MetadataPublisher.publish.
   
   OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org