[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for ratio metrics

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for ratio metrics
URL: https://github.com/apache/incubator-pinot/pull/4246#discussion_r288763834
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/SummaryResource.java
 ##########
 @@ -180,4 +181,69 @@ public String buildSummaryManualDimensionOrder(@QueryParam("dataset") String dat
     }
     return OBJECT_MAPPER.writeValueAsString(response);
   }
+
+  @GET
+  @Path(value = "/summary/autoRatioDimensionOrder")
 
 Review comment:
    how about sharing the same endpoint with additive metrics and run a separate code path in the back end? Instead of making different frontend calls. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org