[jira] [Commented] (CALCITE-1220) Further extend simplify for reducing expressions

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453765#comment-15453765 ] 

Julian Hyde commented on CALCITE-1220:
--------------------------------------

[~jcamachorodriguez], In RexUtil, why did you write

{code}
          terms.remove(i);
          terms.add(i, term);
{code}

instead of

{code}
          terms.set(i, term);
{code}

On an ArrayList, the former are two O(n) operations, and the latter is an O(1) operation.

> Further extend simplify for reducing expressions
> ------------------------------------------------
>
>                 Key: CALCITE-1220
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1220
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 1.9.0
>
>
> We would extend expression simplification, e.g.:
> - add walker to perform recursive simplification of expressions for Filter operators, and
> - extends simplification for CASE expressions to cover more cases e.g. if all return values are equal (including ELSE), CASE can be removed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)