[GitHub] spark pull request #21108: [SPARK-24027][SQL] Support MapType with StringTyp...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21108#discussion_r187383654
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
    @@ -326,4 +326,61 @@ class JsonFunctionsSuite extends QueryTest with SharedSQLContext {
         assert(errMsg4.getMessage.startsWith(
           "A type of keys and values in map() must be string, but got"))
       }
    +
    +  test("SPARK-24027: from_json - map<string, int>") {
    +    val in = Seq("""{"a": 1, "b": 2, "c": 3}""").toDS()
    +    val schema =
    +      """
    +        |{
    +        |  "type" : "map",
    +        |  "keyType" : "string",
    +        |  "valueType" : "integer",
    +        |  "valueContainsNull" : true
    +        |}
    +      """.stripMargin
    +    val out = in.select(from_json($"value", schema, Map[String, String]()))
    +
    +    assert(out.columns.head == "entries")
    +    checkAnswer(out, Row(Map("a" -> 1, "b" -> 2, "c" -> 3)))
    +  }
    +
    +  test("SPARK-24027: from_json - map<string, struct>") {
    --- End diff --
    
    Any negative test case? For example, when the key of MapType is not StringType?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org