You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2023/08/09 04:17:14 UTC
[GitHub] [spark] yaooqinn opened a new pull request, #42407: [SPARK-44737][SQL][UI] Should not display json format errors on SQL page for non-SparkThrowables on SQL Tab
yaooqinn opened a new pull request, #42407:
URL: https://github.com/apache/spark/pull/42407
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This pull request addresses the issue of inconsistent display for SparkThrowables and others. Currently, SparkThrowables appear as plain text while others are displayed in JSON format on SQL Tab. This fix aims to make the display consistent across all items.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To fix the inconsistent behavior, and the JSON format is not correctly displayed.
For those non-SparkThrowables thrown by SQLExecution may contain errors either that we are not ready covered by the new error handling framework or some critical path(what I have met is OOM in RDD.getPartitions), we shall supply the stacktraces
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
add a unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42407: [SPARK-44737][SQL][UI] Should not display json format errors on SQL page for non-SparkThrowables on SQL Tab
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42407:
URL: https://github.com/apache/spark/pull/42407#issuecomment-1672488281
cc @gengliangwang too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn closed pull request #42407: [SPARK-44737][SQL][UI] Should not display json format errors on SQL page for non-SparkThrowables on SQL Tab
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #42407: [SPARK-44737][SQL][UI] Should not display json format errors on SQL page for non-SparkThrowables on SQL Tab
URL: https://github.com/apache/spark/pull/42407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42407: [SPARK-44737][SQL][UI] Should not display json format errors on SQL page for non-SparkThrowables on SQL Tab
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42407:
URL: https://github.com/apache/spark/pull/42407#issuecomment-1671237342
@panbingkun
https://github.com/yaooqinn/spark/actions/runs/5805477173/job/15746890453
This is the third time I've witnessed a RocksDB crash. It seems like a risk. Do we need to roll back to the previous version that we were using?
There is already a Jira ticket tracking this issue: https://issues.apache.org/jira/browse/SPARK-44580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42407: [SPARK-44737][SQL][UI] Should not display json format errors on SQL page for non-SparkThrowables on SQL Tab
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #42407:
URL: https://github.com/apache/spark/pull/42407#issuecomment-1674295112
thanks, merged to master and 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42407: [SPARK-44737][SQL][UI] Should not display json format errors on SQL page for non-SparkThrowables on SQL Tab
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42407:
URL: https://github.com/apache/spark/pull/42407#issuecomment-1672441263
> @panbingkun https://github.com/yaooqinn/spark/actions/runs/5805477173/job/15736662791
>
> <img alt="image" width="1102" src="https://user-images.githubusercontent.com/1475305/259406523-4c4d2cbe-0ed3-40bd-bef5-386fc49ff4b9.png">
> This is the third time I've witnessed the RocksDB crash. It seems like a risk. Do we need to revert to the previous version that we were using?
>
> There is already a Jira ticket tracking this issue: https://issues.apache.org/jira/browse/SPARK-44580
Let me investigate it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org