[GitHub] [superset] betodealmeida commented on a diff in pull request #19770: chore: remove druid datasource from the config

[GitBox <gi...@apache.org>]

betodealmeida commented on code in PR #19770:
URL: https://github.com/apache/superset/pull/19770#discussion_r861227053


##########
superset/datasets/commands/importers/v0.py:
##########
@@ -97,9 +76,6 @@ def import_dataset(
     if isinstance(i_datasource, SqlaTable):
         lookup_database = lookup_sqla_database
         lookup_datasource = lookup_sqla_table
-    else:
-        lookup_database = lookup_druid_cluster
-        lookup_datasource = lookup_druid_datasource

Review Comment:
   Let's leave the `else` and raise an exception inside the block, otherwise we would end with undefined variables in lines 107, 108.



##########
superset/datasets/commands/importers/v0.py:
##########
@@ -152,22 +115,9 @@ def lookup_sqla_column(session: Session, column: TableColumn) -> TableColumn:
     )
 
 
-def lookup_druid_column(session: Session, column: DruidColumn) -> DruidColumn:
-    return (
-        session.query(DruidColumn)
-        .filter(
-            DruidColumn.datasource_id == column.datasource_id,
-            DruidColumn.column_name == column.column_name,
-        )
-        .first()
-    )
-
-
 def import_column(session: Session, column: BaseColumn) -> BaseColumn:
     if isinstance(column, TableColumn):
         lookup_column = lookup_sqla_column
-    else:
-        lookup_column = lookup_druid_column

Review Comment:
   Same here.



##########
superset/datasets/commands/importers/v0.py:
##########
@@ -122,22 +98,9 @@ def lookup_sqla_metric(session: Session, metric: SqlMetric) -> SqlMetric:
     )
 
 
-def lookup_druid_metric(session: Session, metric: DruidMetric) -> DruidMetric:
-    return (
-        session.query(DruidMetric)
-        .filter(
-            DruidMetric.datasource_id == metric.datasource_id,
-            DruidMetric.metric_name == metric.metric_name,
-        )
-        .first()
-    )
-
-
 def import_metric(session: Session, metric: BaseMetric) -> BaseMetric:
     if isinstance(metric, SqlMetric):
         lookup_metric = lookup_sqla_metric
-    else:
-        lookup_metric = lookup_druid_metric

Review Comment:
   Same here:
   
   ```python
   else:
       raise Exception(f"Invalid metric type: {metric}")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org