You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2017/07/01 07:01:00 UTC
[jira] [Commented] (OOZIE-2975) code clean up in pig sharelib,
replace Exception with more explicit, add try with resources, StringBuilder
instead of StringBuffer
[ https://issues.apache.org/jira/browse/OOZIE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071056#comment-16071056 ]
Hadoop QA commented on OOZIE-2975:
----------------------------------
Testing JIRA OOZIE-2975
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 132
. {color:green}+1{color} the patch does adds/modifies 4 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
. {color:red}WARNING{color}: the current HEAD has 1 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 1968
. Tests rerun: 11
. Tests failed at first run: org.apache.oozie.action.hadoop.TestHdfsOperations,org.apache.oozie.event.TestEventGeneration,
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3935/
> code clean up in pig sharelib, replace Exception with more explicit, add try with resources, StringBuilder instead of StringBuffer
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-2975
> URL: https://issues.apache.org/jira/browse/OOZIE-2975
> Project: Oozie
> Issue Type: Improvement
> Reporter: Artem Ervits
> Assignee: Artem Ervits
> Priority: Trivial
> Labels: newbie
> Fix For: 5.0.0
>
> Attachments: OOZIE-2975-0.patch
>
>
> 1. Replaced StringBuffer with StringBuilder
> 2. Replaced Exception with IOException and ExecException
> 3. Replaced old Hashmap notation with diamond notation
> 4. Added try-with-resources notation
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)