You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/25 16:26:49 UTC
[GitHub] [pulsar] shibd opened a new pull request, #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
shibd opened a new pull request, #16785:
URL: https://github.com/apache/pulsar/pull/16785
### Motivation
Currently, `FieldDoc` annotation has `required` and `defaultValue` config. But `IOConfigUtils` didn't deal with those.
The connector we implemented deserialized the configuration using `IOConfigUtils.loadWithSecrets()`
### Modifications
- IOConfigUtils support required and defaultValue annotations.
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16785:
URL: https://github.com/apache/pulsar/pull/16785#issuecomment-1200364943
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16785:
URL: https://github.com/apache/pulsar/pull/16785#issuecomment-1200786783
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16785:
URL: https://github.com/apache/pulsar/pull/16785#issuecomment-1200073876
@cbornet @freeznet @Technoboy- Please help review it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16785:
URL: https://github.com/apache/pulsar/pull/16785#issuecomment-1200075772
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd closed pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
shibd closed pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
URL: https://github.com/apache/pulsar/pull/16785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16785:
URL: https://github.com/apache/pulsar/pull/16785#issuecomment-1200128844
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16785:
URL: https://github.com/apache/pulsar/pull/16785#issuecomment-1201370385
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16785:
URL: https://github.com/apache/pulsar/pull/16785#issuecomment-1201924387
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16785:
URL: https://github.com/apache/pulsar/pull/16785#issuecomment-1200597433
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16785:
URL: https://github.com/apache/pulsar/pull/16785#issuecomment-1201943973
@shibd Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie merged pull request #16785: [fix][connector]IOConfigUtils support required and defaultValue annotations.
Posted by GitBox <gi...@apache.org>.
RobertIndie merged PR #16785:
URL: https://github.com/apache/pulsar/pull/16785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org