[GitHub] [spark] sunchao commented on a change in pull request #33997: [SPARK-36706][SQL][3.1] OverwriteByExpression conversion in DataSourceV2Strategy use wrong param in translateFilter

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #33997:
URL: https://github.com/apache/spark/pull/33997#discussion_r708858886



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWriterV2Suite.scala
##########
@@ -220,6 +220,33 @@ class DataFrameWriterV2Suite extends QueryTest with SharedSparkSession with Befo
       Seq(Row(1L, "a"), Row(2L, "b"), Row(4L, "d"), Row(5L, "e"), Row(6L, "f")))
   }
 
+  test("SPARK-36706 Overwrite: overwrite by expression: more than one filters") {

Review comment:
       should we test that the filters are changed? it seems we only check query answers but I think they should pass no matter with or without the fix?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org