You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Barrie Treloar <ba...@gmail.com> on 2009/06/03 08:00:40 UTC

[VOTE] Release Maven Eclipse plugin version 2.7

Hi,

We solved 11 issues:
http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11133&styleName=Html&version=15130

There are still a couple of issues left in JIRA:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=11133&resolution=-1&sorter/field=updated&sorter/order=DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-staging-005/

Staging site:
http://maven.apache.org/plugins/maven-eclipse-plugin-2.7/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Brett Porter <br...@apache.org>.
I believe adding the previous assembly plugin release with:

<descriptorRefs>
   <descriptorRef>src</descriptorRef>
</descriptorRefs>

is sufficient for our plugins. The purpose of the updated plugin is to  
make it possible to put that in a parent POM without generating  
unwanted assemblies and ensuring the content is correct rather than  
duplicating the above everywhere.

- Brett

On 04/06/2009, at 10:09 AM, David Jencks wrote:

>
> On Jun 3, 2009, at 4:36 PM, Barrie Treloar wrote:
>
>> On Thu, Jun 4, 2009 at 8:54 AM, David Jencks  
>> <da...@yahoo.com> wrote:
>>>
>>> On Jun 3, 2009, at 3:55 PM, Arnaud HERITIER wrote:
>>>
>>>> To be conform with ASF requirements, I understand that we have to  
>>>> wait the
>>>> new assembly plugin to be able to produce the new sources distro.  
>>>> There
>>>> are
>>>> already 3 or 4 attempts to vote the release and it's not yet ended.
>>>> I think also that others ASF projects using Maven won't wait for  
>>>> this fix
>>>> if
>>>> they want to release something.
>>>
>>>                                   <descriptors>
>>> <descriptor>src/assemble/source-release.xml</descriptor>
>>
>> Why isn't this descriptor part of the bundled ones?
>>
>> When can we add it do the release profile so it gets enforced without
>> individual projects having to maintain this separately?
>
> You might want to consult the original discussion on this, its  
> rather lengthy, and I'm sure I'll misrepresent it.
>
> The assembly plugin is not apache specific.  The assembly descriptor  
> might be. So it's being released as a separate artifact -- see the  
> svn url and that should be clear.
>
> The assembly descriptor isn't necessarily useful without the newest  
> assembly plugin.  So the plan is to
> 1. get the assembly plugin released,
> 2. then the assembly descriptor,
> 3. then the use baked into maven projects and thoroughly tested,   
> (other projects can also use it at this point)
> 4. finally release an apache 7 pom including this assembly config in  
> apache-release profile.
>
> I was hoping (1) would happen monday afternoon, looks like it might  
> possibly happen tomorrow morning -- one problem has surfaced but I'm  
> not sure it's a regression from beta-3.
>
> To hurry this along, if you have a vote, test the plugin and use  
> your vote.
>
> thanks
> david jencks
>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by David Jencks <da...@yahoo.com>.
On Jun 3, 2009, at 4:36 PM, Barrie Treloar wrote:

> On Thu, Jun 4, 2009 at 8:54 AM, David Jencks  
> <da...@yahoo.com> wrote:
>>
>> On Jun 3, 2009, at 3:55 PM, Arnaud HERITIER wrote:
>>
>>> To be conform with ASF requirements, I understand that we have to  
>>> wait the
>>> new assembly plugin to be able to produce the new sources distro.  
>>> There
>>> are
>>> already 3 or 4 attempts to vote the release and it's not yet ended.
>>> I think also that others ASF projects using Maven won't wait for  
>>> this fix
>>> if
>>> they want to release something.
>>
>>                                    <descriptors>
>>  <descriptor>src/assemble/source-release.xml</descriptor>
>
> Why isn't this descriptor part of the bundled ones?
>
> When can we add it do the release profile so it gets enforced without
> individual projects having to maintain this separately?

You might want to consult the original discussion on this, its rather  
lengthy, and I'm sure I'll misrepresent it.

The assembly plugin is not apache specific.  The assembly descriptor  
might be. So it's being released as a separate artifact -- see the svn  
url and that should be clear.

The assembly descriptor isn't necessarily useful without the newest  
assembly plugin.  So the plan is to
1. get the assembly plugin released,
2. then the assembly descriptor,
3. then the use baked into maven projects and thoroughly tested,   
(other projects can also use it at this point)
4. finally release an apache 7 pom including this assembly config in  
apache-release profile.

I was hoping (1) would happen monday afternoon, looks like it might  
possibly happen tomorrow morning -- one problem has surfaced but I'm  
not sure it's a regression from beta-3.

To hurry this along, if you have a vote, test the plugin and use your  
vote.

thanks
david jencks

>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Barrie Treloar <ba...@gmail.com>.
On Thu, Jun 4, 2009 at 8:54 AM, David Jencks <da...@yahoo.com> wrote:
>
> On Jun 3, 2009, at 3:55 PM, Arnaud HERITIER wrote:
>
>> To be conform with ASF requirements, I understand that we have to wait the
>> new assembly plugin to be able to produce the new sources distro. There
>> are
>> already 3 or 4 attempts to vote the release and it's not yet ended.
>> I think also that others ASF projects using Maven won't wait for this fix
>> if
>> they want to release something.
>
>                                    <descriptors>
>  <descriptor>src/assemble/source-release.xml</descriptor>

Why isn't this descriptor part of the bundled ones?

When can we add it do the release profile so it gets enforced without
individual projects having to maintain this separately?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by David Jencks <da...@yahoo.com>.
On Jun 3, 2009, at 3:55 PM, Arnaud HERITIER wrote:

> To be conform with ASF requirements, I understand that we have to  
> wait the
> new assembly plugin to be able to produce the new sources distro.  
> There are
> already 3 or 4 attempts to vote the release and it's not yet ended.
> I think also that others ASF projects using Maven won't wait for  
> this fix if
> they want to release something.


The purpose of assembly 2.2-beta-4 is to make it difficult to avoid  
complying with apache policy.  Right now it's not all that hard but  
you have to do something apart from the release plugin.  I haven't  
tried this with say beta 2, but think it will work included in the  
project root pom and run with mvn -Psource-distro -N deploy on a fresh  
svn export, say after running release:perform.

         <profile>
             <id>source-distro</id>
             <build>
                 <plugins>
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-assembly-plugin</artifactId>
                         <version>2.2-beta-2</version>
                         <executions>
                             <execution>
                                 <goals>
                                     <goal>single</goal>
                                 </goals>
                                 <phase>package</phase>
                                 <configuration>
                                     <descriptors>
                                         <descriptor>src/assemble/ 
source-release.xml</descriptor>
                                     </descriptors>
                                 </configuration>
                             </execution>
                         </executions>
                     </plugin>
                 </plugins>
             </build>
         </profile>

src/assemble/source-release.xml contains:

<assembly>
   <id>source-release</id>
   <formats>
     <format>tar.gz</format>
     <format>zip</format>
   </formats>
   <fileSets>
     <fileSet>
       <directory>${project.basedir}</directory>
       <useDefaultExcludes>true</useDefaultExcludes>
       <excludes>
         <exclude>**/${project.build.directory}/**</exclude>
       </excludes>
     </fileSet>
   </fileSets>
</assembly>


from
https://svn.apache.org/repos/asf/maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml

david jencks



>
>
> I have no problem, myself, to wait the release of the plugin some  
> more days
> (I maintain it but I don't use it for myself ;-) ). But I don't  
> think it's a
> good thing for our users. If Barry can do it today, it's possible  
> that he
> can't in few days/weeks.
>
> Cheers,
>
> Arnaud
>
> # Arnaud Héritier
> # http://blog.aheritier.net
>
>
> On Thu, Jun 4, 2009 at 12:40 AM, Barrie Treloar <ba...@gmail.com>  
> wrote:
>
>> On Thu, Jun 4, 2009 at 7:18 AM, Benjamin Bentmann
>> <be...@udo.edu> wrote:
>>> Barrie Treloar wrote:
>>>
>>>> Staging repo:
>>>> https://repository.apache.org/content/repositories/maven-staging-005/
>>>
>>> -1
>>>
>>> As far as I understand the recent discussions about proper  
>>> releases [0]
>> and
>>> the current docs [1], we are required to provide "a source  
>>> package, which
>>> must be sufficient for a user to build and test the release". This
>>> requirement is not met by the "*-sources.jar" (no POM, no tests).
>>>
>>> One needs to grap an assembly descriptor to create a proper source  
>>> bundle
>>> (John and Brian are working on improvements to our tooling to make  
>>> this
>>> easy).
>>>
>>> Others may please correct me if I misunderstood the Apache release
>> policy.
>>
>> Fair enough.
>>
>> David mentions the assembly plugin makes this trivial.
>> Can someone link to step by step instructions?
>>
>> As Arnaud says we have been bad previously and given the limited
>> resource on m-e-p to push releases it will be easier to let this one
>> slide.
>> If I can get the instructions I can ensure that future releases will
>> be fixed. But I don't have the capacity to create another release for
>> a while.
>>
>> The release documentation
>> http://maven.apache.org/developers/release/releasing.html doesn't
>> mention anything about the ASF requirement.
>> I have some outstanding minor changes to that document so I will make
>> sure that something is added as well.
>>
>> Barrie
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Arnaud HERITIER <ah...@gmail.com>.
To be conform with ASF requirements, I understand that we have to wait the
new assembly plugin to be able to produce the new sources distro. There are
already 3 or 4 attempts to vote the release and it's not yet ended.
I think also that others ASF projects using Maven won't wait for this fix if
they want to release something.

I have no problem, myself, to wait the release of the plugin some more days
(I maintain it but I don't use it for myself ;-) ). But I don't think it's a
good thing for our users. If Barry can do it today, it's possible that he
can't in few days/weeks.

Cheers,

Arnaud

# Arnaud Héritier
# http://blog.aheritier.net


On Thu, Jun 4, 2009 at 12:40 AM, Barrie Treloar <ba...@gmail.com> wrote:

> On Thu, Jun 4, 2009 at 7:18 AM, Benjamin Bentmann
> <be...@udo.edu> wrote:
> > Barrie Treloar wrote:
> >
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-staging-005/
> >
> > -1
> >
> > As far as I understand the recent discussions about proper releases [0]
> and
> > the current docs [1], we are required to provide "a source package, which
> > must be sufficient for a user to build and test the release". This
> > requirement is not met by the "*-sources.jar" (no POM, no tests).
> >
> > One needs to grap an assembly descriptor to create a proper source bundle
> > (John and Brian are working on improvements to our tooling to make this
> > easy).
> >
> > Others may please correct me if I misunderstood the Apache release
> policy.
>
> Fair enough.
>
> David mentions the assembly plugin makes this trivial.
> Can someone link to step by step instructions?
>
> As Arnaud says we have been bad previously and given the limited
> resource on m-e-p to push releases it will be easier to let this one
> slide.
> If I can get the instructions I can ensure that future releases will
> be fixed. But I don't have the capacity to create another release for
> a while.
>
> The release documentation
> http://maven.apache.org/developers/release/releasing.html doesn't
> mention anything about the ASF requirement.
> I have some outstanding minor changes to that document so I will make
> sure that something is added as well.
>
> Barrie
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Barrie Treloar <ba...@gmail.com>.
On Thu, Jun 4, 2009 at 7:18 AM, Benjamin Bentmann
<be...@udo.edu> wrote:
> Barrie Treloar wrote:
>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-staging-005/
>
> -1
>
> As far as I understand the recent discussions about proper releases [0] and
> the current docs [1], we are required to provide "a source package, which
> must be sufficient for a user to build and test the release". This
> requirement is not met by the "*-sources.jar" (no POM, no tests).
>
> One needs to grap an assembly descriptor to create a proper source bundle
> (John and Brian are working on improvements to our tooling to make this
> easy).
>
> Others may please correct me if I misunderstood the Apache release policy.

Fair enough.

David mentions the assembly plugin makes this trivial.
Can someone link to step by step instructions?

As Arnaud says we have been bad previously and given the limited
resource on m-e-p to push releases it will be easier to let this one
slide.
If I can get the instructions I can ensure that future releases will
be fixed. But I don't have the capacity to create another release for
a while.

The release documentation
http://maven.apache.org/developers/release/releasing.html doesn't
mention anything about the ASF requirement.
I have some outstanding minor changes to that document so I will make
sure that something is added as well.

Barrie

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Barrie Treloar <ba...@gmail.com>.
Ok here are the steps I took:

Copied https://svn.apache.org/repos/asf/maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml
to src/assemble/

Modified pom to include
      <plugin>
        <artifactId>maven-assembly-plugin</artifactId>
        <executions>
          <execution>
            <goals>
              <goal>single</goal>
            </goals>
            <phase>package</phase>
            <configuration>
              <descriptors>
                <descriptor>src/assemble/source-release.xml</descriptor>
              </descriptors>
            </configuration>
          </execution>
        </executions>
      </plugin>

After checking the source-release archive I found that it was building
the archives with an internal path that was my local path e.g.
D:\ide\maven

Why? After running with -X here is the output

--------------console output - Start
[DEBUG] Before assembly is interpolated:

<?xml version="1.0" encoding="UTF-8"?><assembly>
  <id>source-release</id>
  <formats>
    <format>tar.gz</format>
    <format>zip</format>
  </formats>
  <fileSets>
    <fileSet>
      <directory>${project.basedir}</directory>
      <outputDirectory></outputDirectory>
      <excludes>
        <exclude>**/${project.build.directory}/**</exclude>
      </excludes>
    </fileSet>
  </fileSets>
</assembly>


[DEBUG] After assembly is interpolated:

<?xml version="1.0" encoding="UTF-8"?><assembly>
  <id>source-release</id>
  <formats>
    <format>tar.gz</format>
    <format>zip</format>
  </formats>
  <fileSets>
    <fileSet>
      <directory>D:\ide\maven\maven-eclipse-plugin</directory>
      <outputDirectory></outputDirectory>
      <excludes>
        <exclude>**/D:\ide\maven\maven-eclipse-plugin\target/**</exclude>
      </excludes>
    </fileSet>
  </fileSets>
</assembly>
--------------console output - Stop

It looks like the interpolation doesn't work for windows paths (nor
does it make those paths relative)

Also the descriptor is not ignoring IDE files so they were added as well.

I changed src/assemble/source-release.xml to

<assembly>
  <id>source-release</id>
  <formats>
    <format>tar.gz</format>
    <format>zip</format>
  </formats>
  <fileSets>
    <fileSet>
      <directory>.</directory>
      <outputDirectory></outputDirectory>
      <useDefaultExcludes>true</useDefaultExcludes>
      <excludes>
        <exclude>target/**</exclude>
        <exclude>.classpath</exclude>
        <exclude>.project</exclude>
        <exclude>.settings/**</exclude>
      </excludes>
    </fileSet>
  </fileSets>
</assembly>

All up it took 30-60 minutes to fiddle, re-run and check files.

It's going to sound like griping but links to threads and reasonable
instructions would be preferred.
I am happy to do the work but I am at an information disadvantage
compared to people requesting the work being done.
Instead of being able to do this investigation at my leisure where it
wouldn't matter so much I've had to find the time over the weekend to
do this so I can push the release forward.
And a bit more hand holding would have saved me time :)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Paul Gier <pg...@redhat.com>.
If you need an example, you can look at what I did for the ant tasks [1].  The 
same assembly should work fine for the eclipse plugin.  You probably just want 
to make minor changes for any files that do/don't exist.

[1]http://svn.apache.org/repos/asf/maven/ant-tasks/tags/maven-ant-tasks-2.0.10/src/assembly/src.xml

Arnaud HERITIER wrote:
> I thought we needed to have a fix in the assembly plugin to be able to
> release with ASF rules.If we can do it with just some local changes in our
> pom, we have to do it.
> 
> However I agree with Barry and we cannot loose too many time to do the
> release.
> Is there someone who can help us to setup the eclipse plugin build to follow
> ASF requirements for the release ?
> Arnaud
> 
> # Arnaud Héritier
> # http://blog.aheritier.net
> 
> 
> On Fri, Jun 5, 2009 at 1:48 AM, Barrie Treloar <ba...@gmail.com> wrote:
> 
>> On Fri, Jun 5, 2009 at 7:13 AM, Brian Fox <br...@infinity.nu> wrote:
>>> On Thu, Jun 4, 2009 at 11:43 AM, Benjamin Bentmann <
>>> benjamin.bentmann@udo.edu> wrote:
>>>
>>>> Arnaud HERITIER wrote:
>>>>
>>>>  I think there's no value to block all releases, waiting for this fix.I
>>>>> agree, support this change, but it won't help our users to have them
>>>>> waiting
>>>>> all our releases for several weeks.
>>>>>
>>>> I don't really understand why fixing a project to produce a proper
>> source
>>>> bundle (e.g. by means of copying one of the existing assembly
>> descriptors)
>>>> would take several weeks...
>>>>
>>> It should take a few minutes and can be done with the current assembly
>>> release. The changes i made to the plugin are to make it possible to set
>>> this up at a top level pom (maven or asf) and have it do the right thing
>> for
>>> each build.
>> The problem is that neither myself or Arnaud have a lot of capacity to
>> cut another release.
>>
>> If I can get an explicit and complete set of instructions to build
>> whatever is required then I can do it.
>> If I have to spend any time thinking about it or start the release
>> process again then it will have to wait until I have spare time.
>>
>> My preference is to:
>> * update the pom on trunk to include whatever will build the source
>> distro (this is different than the "-sources.jar") [Note: I dont
>> really want to change my pom I want the parent pom release profile to
>> do it for me instead]
>> * run the command to generate the distro archive from the tag
>> * deploy the distro
>>
>> Suggestions?
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Stephen Connolly <st...@gmail.com>.
My understanding of the problems that are being had with the assembly stuff
is around releasing multi-module projects (e.g. surefire, enforcer).  If all
you are releasing is a single module (e.g. maven-eclipse-plugin), then
assembly does exactly what you want right now.

The issue that John and Brian is working on is multi-module projects, which
might decide to use non-standard output directories, etc.

When adding a source assembly to the parent pom, you need that to work
correctly for all release types... which is why they're having so many
issues

Just my €0.02

-Stephen

2009/6/5 Brian Fox <br...@infinity.nu>

> Seriously just use the assembly plugin to zip up the source folder,
> excluding target. There are several examples in the related threads.
>
> On Thu, Jun 4, 2009 at 5:04 PM, Arnaud HERITIER <ah...@gmail.com>
> wrote:
>
> > I thought we needed to have a fix in the assembly plugin to be able to
> > release with ASF rules.If we can do it with just some local changes in
> our
> > pom, we have to do it.
> >
> > However I agree with Barry and we cannot loose too many time to do the
> > release.
> > Is there someone who can help us to setup the eclipse plugin build to
> > follow
> > ASF requirements for the release ?
> > Arnaud
> >
> > # Arnaud Héritier
> > # http://blog.aheritier.net
> >
> >
> > On Fri, Jun 5, 2009 at 1:48 AM, Barrie Treloar <ba...@gmail.com>
> wrote:
> >
> > > On Fri, Jun 5, 2009 at 7:13 AM, Brian Fox <br...@infinity.nu> wrote:
> > > > On Thu, Jun 4, 2009 at 11:43 AM, Benjamin Bentmann <
> > > > benjamin.bentmann@udo.edu> wrote:
> > > >
> > > >> Arnaud HERITIER wrote:
> > > >>
> > > >>  I think there's no value to block all releases, waiting for this
> > fix.I
> > > >>> agree, support this change, but it won't help our users to have
> them
> > > >>> waiting
> > > >>> all our releases for several weeks.
> > > >>>
> > > >>
> > > >> I don't really understand why fixing a project to produce a proper
> > > source
> > > >> bundle (e.g. by means of copying one of the existing assembly
> > > descriptors)
> > > >> would take several weeks...
> > > >>
> > > >
> > > > It should take a few minutes and can be done with the current
> assembly
> > > > release. The changes i made to the plugin are to make it possible to
> > set
> > > > this up at a top level pom (maven or asf) and have it do the right
> > thing
> > > for
> > > > each build.
> > >
> > > The problem is that neither myself or Arnaud have a lot of capacity to
> > > cut another release.
> > >
> > > If I can get an explicit and complete set of instructions to build
> > > whatever is required then I can do it.
> > > If I have to spend any time thinking about it or start the release
> > > process again then it will have to wait until I have spare time.
> > >
> > > My preference is to:
> > > * update the pom on trunk to include whatever will build the source
> > > distro (this is different than the "-sources.jar") [Note: I dont
> > > really want to change my pom I want the parent pom release profile to
> > > do it for me instead]
> > > * run the command to generate the distro archive from the tag
> > > * deploy the distro
> > >
> > > Suggestions?
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>

Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Brian Fox <br...@infinity.nu>.
Seriously just use the assembly plugin to zip up the source folder,
excluding target. There are several examples in the related threads.

On Thu, Jun 4, 2009 at 5:04 PM, Arnaud HERITIER <ah...@gmail.com> wrote:

> I thought we needed to have a fix in the assembly plugin to be able to
> release with ASF rules.If we can do it with just some local changes in our
> pom, we have to do it.
>
> However I agree with Barry and we cannot loose too many time to do the
> release.
> Is there someone who can help us to setup the eclipse plugin build to
> follow
> ASF requirements for the release ?
> Arnaud
>
> # Arnaud Héritier
> # http://blog.aheritier.net
>
>
> On Fri, Jun 5, 2009 at 1:48 AM, Barrie Treloar <ba...@gmail.com> wrote:
>
> > On Fri, Jun 5, 2009 at 7:13 AM, Brian Fox <br...@infinity.nu> wrote:
> > > On Thu, Jun 4, 2009 at 11:43 AM, Benjamin Bentmann <
> > > benjamin.bentmann@udo.edu> wrote:
> > >
> > >> Arnaud HERITIER wrote:
> > >>
> > >>  I think there's no value to block all releases, waiting for this
> fix.I
> > >>> agree, support this change, but it won't help our users to have them
> > >>> waiting
> > >>> all our releases for several weeks.
> > >>>
> > >>
> > >> I don't really understand why fixing a project to produce a proper
> > source
> > >> bundle (e.g. by means of copying one of the existing assembly
> > descriptors)
> > >> would take several weeks...
> > >>
> > >
> > > It should take a few minutes and can be done with the current assembly
> > > release. The changes i made to the plugin are to make it possible to
> set
> > > this up at a top level pom (maven or asf) and have it do the right
> thing
> > for
> > > each build.
> >
> > The problem is that neither myself or Arnaud have a lot of capacity to
> > cut another release.
> >
> > If I can get an explicit and complete set of instructions to build
> > whatever is required then I can do it.
> > If I have to spend any time thinking about it or start the release
> > process again then it will have to wait until I have spare time.
> >
> > My preference is to:
> > * update the pom on trunk to include whatever will build the source
> > distro (this is different than the "-sources.jar") [Note: I dont
> > really want to change my pom I want the parent pom release profile to
> > do it for me instead]
> > * run the command to generate the distro archive from the tag
> > * deploy the distro
> >
> > Suggestions?
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>

Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Arnaud HERITIER <ah...@gmail.com>.
I thought we needed to have a fix in the assembly plugin to be able to
release with ASF rules.If we can do it with just some local changes in our
pom, we have to do it.

However I agree with Barry and we cannot loose too many time to do the
release.
Is there someone who can help us to setup the eclipse plugin build to follow
ASF requirements for the release ?
Arnaud

# Arnaud Héritier
# http://blog.aheritier.net


On Fri, Jun 5, 2009 at 1:48 AM, Barrie Treloar <ba...@gmail.com> wrote:

> On Fri, Jun 5, 2009 at 7:13 AM, Brian Fox <br...@infinity.nu> wrote:
> > On Thu, Jun 4, 2009 at 11:43 AM, Benjamin Bentmann <
> > benjamin.bentmann@udo.edu> wrote:
> >
> >> Arnaud HERITIER wrote:
> >>
> >>  I think there's no value to block all releases, waiting for this fix.I
> >>> agree, support this change, but it won't help our users to have them
> >>> waiting
> >>> all our releases for several weeks.
> >>>
> >>
> >> I don't really understand why fixing a project to produce a proper
> source
> >> bundle (e.g. by means of copying one of the existing assembly
> descriptors)
> >> would take several weeks...
> >>
> >
> > It should take a few minutes and can be done with the current assembly
> > release. The changes i made to the plugin are to make it possible to set
> > this up at a top level pom (maven or asf) and have it do the right thing
> for
> > each build.
>
> The problem is that neither myself or Arnaud have a lot of capacity to
> cut another release.
>
> If I can get an explicit and complete set of instructions to build
> whatever is required then I can do it.
> If I have to spend any time thinking about it or start the release
> process again then it will have to wait until I have spare time.
>
> My preference is to:
> * update the pom on trunk to include whatever will build the source
> distro (this is different than the "-sources.jar") [Note: I dont
> really want to change my pom I want the parent pom release profile to
> do it for me instead]
> * run the command to generate the distro archive from the tag
> * deploy the distro
>
> Suggestions?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Barrie Treloar <ba...@gmail.com>.
On Fri, Jun 5, 2009 at 7:13 AM, Brian Fox <br...@infinity.nu> wrote:
> On Thu, Jun 4, 2009 at 11:43 AM, Benjamin Bentmann <
> benjamin.bentmann@udo.edu> wrote:
>
>> Arnaud HERITIER wrote:
>>
>>  I think there's no value to block all releases, waiting for this fix.I
>>> agree, support this change, but it won't help our users to have them
>>> waiting
>>> all our releases for several weeks.
>>>
>>
>> I don't really understand why fixing a project to produce a proper source
>> bundle (e.g. by means of copying one of the existing assembly descriptors)
>> would take several weeks...
>>
>
> It should take a few minutes and can be done with the current assembly
> release. The changes i made to the plugin are to make it possible to set
> this up at a top level pom (maven or asf) and have it do the right thing for
> each build.

The problem is that neither myself or Arnaud have a lot of capacity to
cut another release.

If I can get an explicit and complete set of instructions to build
whatever is required then I can do it.
If I have to spend any time thinking about it or start the release
process again then it will have to wait until I have spare time.

My preference is to:
* update the pom on trunk to include whatever will build the source
distro (this is different than the "-sources.jar") [Note: I dont
really want to change my pom I want the parent pom release profile to
do it for me instead]
* run the command to generate the distro archive from the tag
* deploy the distro

Suggestions?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Brian Fox <br...@infinity.nu>.
On Thu, Jun 4, 2009 at 11:43 AM, Benjamin Bentmann <
benjamin.bentmann@udo.edu> wrote:

> Arnaud HERITIER wrote:
>
>  I think there's no value to block all releases, waiting for this fix.I
>> agree, support this change, but it won't help our users to have them
>> waiting
>> all our releases for several weeks.
>>
>
> I don't really understand why fixing a project to produce a proper source
> bundle (e.g. by means of copying one of the existing assembly descriptors)
> would take several weeks...
>

It should take a few minutes and can be done with the current assembly
release. The changes i made to the plugin are to make it possible to set
this up at a top level pom (maven or asf) and have it do the right thing for
each build.

>
>
>  We are doing it like that (yes badly) for a long time now. Thus I don't
>> think that one or two releases will change something.
>>
>
> This is a sentiment that I don't share. However, if it proves to be
> community sense to knowingly violate the ASF policy, I won't stand in
> people's way. So I change my to vote to -0.


I disagree, we didn't know it was wrong before. Now we do, and we must
comply.

-1


>
>
>
> Benjamin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Benjamin Bentmann <be...@udo.edu>.
Arnaud HERITIER wrote:

> I think there's no value to block all releases, waiting for this fix.I
> agree, support this change, but it won't help our users to have them waiting
> all our releases for several weeks.

I don't really understand why fixing a project to produce a proper 
source bundle (e.g. by means of copying one of the existing assembly 
descriptors) would take several weeks...

> We are doing it like that (yes badly) for a long time now. Thus I don't
> think that one or two releases will change something.

This is a sentiment that I don't share. However, if it proves to be 
community sense to knowingly violate the ASF policy, I won't stand in 
people's way. So I change my to vote to -0.


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by David Jencks <da...@yahoo.com>.
The new assembly plugin makes it trivially easy to have the release  
profile build the source distro, which is really amazingly nice.   
However you can easily have a separate profile to run an earlier  
assembly plugin to construct just the required source distro and run  
it with -N so it only runs once.

Now that the policy has been clarified there are no more excuses to  
not following it.

thanks
david jencks

On Jun 3, 2009, at 3:10 PM, Arnaud HERITIER wrote:

> I think there's no value to block all releases, waiting for this fix.I
> agree, support this change, but it won't help our users to have them  
> waiting
> all our releases for several weeks.
> We are doing it like that (yes badly) for a long time now. Thus I  
> don't
> think that one or two releases will change something.
>
> Arnaud
>
> On Wed, Jun 3, 2009 at 11:48 PM, Benjamin Bentmann <
> benjamin.bentmann@udo.edu> wrote:
>
>> Barrie Treloar wrote:
>>
>> Staging repo:
>>> https://repository.apache.org/content/repositories/maven- 
>>> staging-005/
>>>
>>
>> -1
>>
>> As far as I understand the recent discussions about proper releases  
>> [0] and
>> the current docs [1], we are required to provide "a source package,  
>> which
>> must be sufficient for a user to build and test the release". This
>> requirement is not met by the "*-sources.jar" (no POM, no tests).
>>
>> One needs to grap an assembly descriptor to create a proper source  
>> bundle
>> (John and Brian are working on improvements to our tooling to make  
>> this
>> easy).
>>
>> Others may please correct me if I misunderstood the Apache release  
>> policy.
>>
>>
>> Benjamin
>>
>>
>> [0]
>> http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200904.mbox/browser
>> [1] http://www.apache.org/dev/release.html#what-must-every-release-contain
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Arnaud HERITIER <ah...@gmail.com>.
I think there's no value to block all releases, waiting for this fix.I
agree, support this change, but it won't help our users to have them waiting
all our releases for several weeks.
We are doing it like that (yes badly) for a long time now. Thus I don't
think that one or two releases will change something.

Arnaud

On Wed, Jun 3, 2009 at 11:48 PM, Benjamin Bentmann <
benjamin.bentmann@udo.edu> wrote:

> Barrie Treloar wrote:
>
>  Staging repo:
>> https://repository.apache.org/content/repositories/maven-staging-005/
>>
>
> -1
>
> As far as I understand the recent discussions about proper releases [0] and
> the current docs [1], we are required to provide "a source package, which
> must be sufficient for a user to build and test the release". This
> requirement is not met by the "*-sources.jar" (no POM, no tests).
>
> One needs to grap an assembly descriptor to create a proper source bundle
> (John and Brian are working on improvements to our tooling to make this
> easy).
>
> Others may please correct me if I misunderstood the Apache release policy.
>
>
> Benjamin
>
>
> [0]
> http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200904.mbox/browser
> [1] http://www.apache.org/dev/release.html#what-must-every-release-contain
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Benjamin Bentmann <be...@udo.edu>.
Barrie Treloar wrote:

> Staging repo:
> https://repository.apache.org/content/repositories/maven-staging-005/

-1

As far as I understand the recent discussions about proper releases [0] 
and the current docs [1], we are required to provide "a source package, 
which must be sufficient for a user to build and test the release". This 
requirement is not met by the "*-sources.jar" (no POM, no tests).

One needs to grap an assembly descriptor to create a proper source 
bundle (John and Brian are working on improvements to our tooling to 
make this easy).

Others may please correct me if I misunderstood the Apache release policy.


Benjamin


[0] 
http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200904.mbox/browser
[1] http://www.apache.org/dev/release.html#what-must-every-release-contain


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Maven Eclipse plugin version 2.7

Posted by Arnaud HERITIER <ah...@gmail.com>.
+1
Just a remark about the note on the home page. I think it's better to say
that "Starting at version 2.6, *by default,* the generated .classpath now
includes "... And you can add a link on the page which explains how to
change it.

Arnaud


Cheers,

Arnaud

# Arnaud Héritier
# http://blog.aheritier.net


On Wed, Jun 3, 2009 at 8:00 AM, Barrie Treloar <ba...@gmail.com> wrote:

> Hi,
>
> We solved 11 issues:
>
> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11133&styleName=Html&version=15130
>
> There are still a couple of issues left in JIRA:
>
> http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=11133&resolution=-1&sorter/field=updated&sorter/order=DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-staging-005/
>
> Staging site:
> http://maven.apache.org/plugins/maven-eclipse-plugin-2.7/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>