You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/29 21:55:33 UTC
[GitHub] [cloudstack] rhtyd opened a new pull request #4051: db: add support for MySQL 8
rhtyd opened a new pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051
- Splits commands to create user and grant access on database, the old
statement is no longer supported by MySQL 8.x
- `NO_AUTO_CREATE_USER` is no longer supported by MySQL 8.x so remove
that from db.properties conn parameters
For mysql-server 8.x setup the following changes were added/tested to
make it work with CloudStack in /etc/mysql/mysql.conf.d/mysqld.cnf and
then restart the mysql-server process:
server_id = 1
sql-mode="STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION,ERROR_FOR_DIVISION_BY_ZERO,NO_ZERO_DATE,NO_ZERO_IN_DATE,NO_ENGINE_SUBSTITUTION"
innodb_rollback_on_timeout=1
innodb_lock_wait_timeout=600
max_connections=1000
log-bin=mysql-bin
binlog-format = 'ROW'
default-authentication-plugin=mysql_native_password
Notice the last line above, this is to reset the old password-based
authentication used by MySQL 5.x.
Developers can set empty password as follows:
> sudo mysql -u root
ALTER USER 'root'@'localhost' IDENTIFIED BY '';
mysql8-deploydb
Tested on Ubuntu 20.04 for a local Primate setup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#discussion_r417863029
##########
File path: utils/conf/db.properties
##########
@@ -44,8 +44,7 @@ db.cloud.testWhileIdle=true
db.cloud.timeBetweenEvictionRunsMillis=40000
db.cloud.minEvictableIdleTimeMillis=240000
db.cloud.poolPreparedStatements=false
-db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&prepStmtCacheSqlLimit=4096&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'
-
+db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&prepStmtCacheSqlLimit=4096&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION,ERROR_FOR_DIVISION_BY_ZERO,NO_ZERO_DATE,NO_ZERO_IN_DATE,NO_ENGINE_SUBSTITUTION'
Review comment:
two NO_ENGINE_SUBSTITUTION
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-622867199
<b>Trillian test result (tid-1495)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34545 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4051-t1495-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621487601
Smoke tests or some test cases that should be validated:
- [x] MySQL 5.7 (or MariaDB 10.x compatible with 5.7) + CloudStack against this PR
- [ ] MySQL 8.x + CloudStack against this PR with (a) single mgmt/usage server and (b) multiple mgmt servers and usage servers
- [x] Travis/developers to test mvn deploydb on their MySQL 5.7 env
- [x] Travis/developers to test mvn deploydb on their MySQL 8.x env (Rohit validated on Ubuntu 20.04 against mvn)
Other Notes:
- Installation docs may need to be updated.
- Optional: Upgrade from MySQL 5.7 to 8.x; against CloudStack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621492342
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621487601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621504519
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621487601
Smoke tests or some test cases:
- MySQL 5.7 + CloudStack against this PR
- MySQL 8.x + CloudStack against this PR
- Travis/developers to test mvn deploydb on their MySQL 5.7 env
- Travis/developers to test mvn deploydb on their MySQL 8.x env
- Upgrade from MySQL 5.7 to 8.x; against CloudStack (optional)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621487601
Smoke tests or some test cases that should be validated:
- MySQL 5.7 + CloudStack against this PR
- MySQL 8.x + CloudStack against this PR with (a) single mgmt/usage server and (b) multiple mgmt servers and usage servers
- Travis/developers to test mvn deploydb on their MySQL 5.7 env
- Travis/developers to test mvn deploydb on their MySQL 8.x env
- Optional: Upgrade from MySQL 5.7 to 8.x; against CloudStack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621491891
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621487601
Smoke tests or some test cases that should be validated:
- [ ] MySQL 5.7 + CloudStack against this PR
- [ ] MySQL 8.x + CloudStack against this PR with (a) single mgmt/usage server and (b) multiple mgmt servers and usage servers
- [ ] Travis/developers to test mvn deploydb on their MySQL 5.7 env
- [x] Travis/developers to test mvn deploydb on their MySQL 8.x env (Rohit validated on Ubuntu 20.04 against mvn)
Other Notes:
- Installation docs may need to be updated.
- Optional: Upgrade from MySQL 5.7 to 8.x; against CloudStack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-622193819
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621486363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621486363
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621487601
Smoke tests or some test cases that should be validated:
- [x] MySQL 5.7 + CloudStack against this PR
- [ ] MySQL 8.x + CloudStack against this PR with (a) single mgmt/usage server and (b) multiple mgmt servers and usage servers
- [x] Travis/developers to test mvn deploydb on their MySQL 5.7 env
- [x] Travis/developers to test mvn deploydb on their MySQL 8.x env (Rohit validated on Ubuntu 20.04 against mvn)
Other Notes:
- Installation docs may need to be updated.
- Optional: Upgrade from MySQL 5.7 to 8.x; against CloudStack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-622996125
> Smoke tests or some test cases that should be validated:
>
> * [ ] MySQL 5.7 + CloudStack against this PR
>
> * [ ] MySQL 8.x + CloudStack against this PR with (a) single mgmt/usage server and (b) multiple mgmt servers and usage servers
>
You are trying to keep this compatible with mysql 5 and 8, @rhtyd ? Does it not make more sense to actively seek support mariadb ?
look good otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621504205
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621503226
Packaging result: ✔centos7 ✔debian. JID-1204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621487601
Smoke tests or some test cases that should be validated:
- MySQL 5.7 + CloudStack against this PR
- MySQL 8.x + CloudStack against this PR
- Travis/developers to test mvn deploydb on their MySQL 5.7 env
- Travis/developers to test mvn deploydb on their MySQL 8.x env
- Optional: Upgrade from MySQL 5.7 to 8.x; against CloudStack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-622193527
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#discussion_r417894730
##########
File path: utils/conf/db.properties
##########
@@ -44,8 +44,7 @@ db.cloud.testWhileIdle=true
db.cloud.timeBetweenEvictionRunsMillis=40000
db.cloud.minEvictableIdleTimeMillis=240000
db.cloud.poolPreparedStatements=false
-db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&prepStmtCacheSqlLimit=4096&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'
-
+db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&prepStmtCacheSqlLimit=4096&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION,ERROR_FOR_DIVISION_BY_ZERO,NO_ZERO_DATE,NO_ZERO_IN_DATE,NO_ENGINE_SUBSTITUTION'
Review comment:
Good catch I'll fix that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621486144
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-623018705
@DaanHoogland yes we should support both versions until 5.x reaches EOL.
MariaDB is largely compatible with MySQL 5.x at least per their docs.
We need to check if trillian default test on CentOS7 uses mariadb.
From an applications point of view, the mysql-java library and wire protocol stays the same as well as support for (ansi) SQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-626205693
cc @shwstppr @davidjumani - while deploying database, and a zone against mysql 8.0 (on Ubuntu 20.04 on raspberrypi4) I found an issue with the `nics` table where `update_time` was being set as null which it didn't like (the default column was not null), I could alter/modify the default param; but this needs checking against mysql8/CentOS8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621487601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621486144
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-634411710
Closing in favour of https://github.com/apache/cloudstack/pull/4068/commits/b895cf98f3927b8fbae7c927367e2c1d3bb68e0b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621491729
Packaging result: ✖centos7 ✖debian. JID-1203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4051: db: add support for MySQL 8
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4051:
URL: https://github.com/apache/cloudstack/pull/4051#issuecomment-621487601
Smoke tests or some test cases that should be validated:
- [ ] MySQL 5.7 + CloudStack against this PR
- [ ] MySQL 8.x + CloudStack against this PR with (a) single mgmt/usage server and (b) multiple mgmt servers and usage servers
- [x] Travis/developers to test mvn deploydb on their MySQL 5.7 env
- [x] Travis/developers to test mvn deploydb on their MySQL 8.x env (Rohit validated on Ubuntu 20.04 against mvn)
Other Notes:
- Installation docs may need to be updated.
- Optional: Upgrade from MySQL 5.7 to 8.x; against CloudStack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org