You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/10/19 13:17:01 UTC

[GitHub] [cordova-common] dpogue commented on pull request #181: Updated PluginInfo to pass through XML attributes.

dpogue commented on PR #181:
URL: https://github.com/apache/cordova-common/pull/181#issuecomment-1283999176

   This looks good, and definitely helps make it easier for platforms to support new attributes in the future!
   
   It would be good to add unit tests to show that custom attributes do, in fact, get passed through and returned by the methods after this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org