You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/02 18:42:11 UTC
[GitHub] [ozone-go] elek commented on a change in pull request #6: HDDS-5085. Create initial project structure with importing POC code
elek commented on a change in pull request #6:
URL: https://github.com/apache/ozone-go/pull/6#discussion_r624737567
##########
File path: proto/ratis-grpc.proto
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review comment:
Thanks the suggestinos.
I don't see such a recommendation in the thread, but I think it's a good idea.
But in the current phase of the project I would prefer to keep the Ratis related code here as we don't need full, Ratis client (implementing all the Ratis calls) the only thing what we need to do is wrap the request in the Ratis envelope.
After we have a working demo: I agree. We can move out the Ratis related code, create a full-featured Ratis client and switch to use it. Until that I would prefer to keep here.
##########
File path: proto/ratis-grpc.proto
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review comment:
Thanks the suggestions.
I don't see such a recommendation in the thread, but I think it's a good idea.
But in the current phase of the project I would prefer to keep the Ratis related code here as we don't need full, Ratis client (implementing all the Ratis calls) the only thing what we need to do is wrap the request in the Ratis envelope.
After we have a working demo: I agree. We can move out the Ratis related code, create a full-featured Ratis client and switch to use it. Until that I would prefer to keep here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org