You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/16 11:43:34 UTC
[GitHub] [phoenix-connectors] richardantal opened a new pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
richardantal opened a new pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-660241708
This is what I have done:
* `mvn install` from master on phoenix.git
* `mvn verify -am -pl phoenix-hive3`
I then see test failures:
```
[INFO] Running org.apache.phoenix.hive.HiveMapReduceIT
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.005 s <<< FAILURE! - in org.apache.phoenix.hive.HiveMapReduceIT
[ERROR] org.apache.phoenix.hive.HiveMapReduceIT Time elapsed: 0.005 s <<< ERROR!
java.lang.NoClassDefFoundError: org/apache/hadoop/crypto/key/KeyProviderTokenIssuer
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
at org.apache.phoenix.query.BaseTest.initMiniCluster(BaseTest.java:544)
at org.apache.phoenix.query.BaseTest.setUpTestCluster(BaseTest.java:448)
at org.apache.phoenix.query.BaseTest.checkClusterInitialized(BaseTest.java:434)
at org.apache.phoenix.query.BaseTest.setUpTestDriver(BaseTest.java:520)
at org.apache.phoenix.query.BaseTest.setUpTestDriver(BaseTest.java:515)
at org.apache.phoenix.end2end.BaseHBaseManagedTimeIT.doSetup(BaseHBaseManagedTimeIT.java:57)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)
at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:87)
at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.crypto.key.KeyProviderTokenIssuer
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
... 48 more
```
Seems like we're missing hadoop-common on the class path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-666206745
Some minor issues:
- Hive-exec dependency is duplicated
- Pom indentation (since it's technically a new POM, you may want to have your IDE reformat it)
- You may want to rename the hive version property to hive3.version, as it is distinct from the other hive connector's hive version
- Netty dependency is in the test section, but not marked as test scope (probably just add test scope)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-662079691
> Maybe pre-emptively move this code to org.apache.phoenix.hive3 package now, so that we don't have to deal with the 2.x vs 3.x conflicts later ?
That's a really smart idea. Hive's classpath gets the entire world, most of the time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-661008726
If you don't need to rebase, then please push additional commits instead of force-rebases.
That way we can track the changes that you've made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-660236358
Running a `mvn verify` on HEAD of this pull request, fails on the phoenix-hive module with a Jersey compatibility issue:
```
2020-07-17 12:59:35,108 ERROR [main] org.mortbay.log: Error starting handlers
java.lang.IncompatibleClassChangeError: com.sun.jersey.json.impl.provider.entity.JSONRootElementProvider and com.sun.jersey.json.impl.provider.entity.JSONRootElementProvider$Wadl disagree on InnerClasses attribute
at java.lang.Class.getDeclaringClass0(Native Method)
at java.lang.Class.getDeclaringClass(Class.java:1235)
at java.lang.Class.getEnclosingClass(Class.java:1277)
at com.sun.jersey.core.spi.component.ComponentConstructor.getInstance(ComponentConstructor.java:169)
at com.sun.jersey.core.spi.component.ProviderFactory.__getComponentProvider(ProviderFactory.java:166)
at com.sun.jersey.core.spi.component.ProviderFactory.getComponentProvider(ProviderFactory.java:137)
at com.sun.jersey.core.spi.component.ProviderServices.getComponent(ProviderServices.java:256)
at com.sun.jersey.core.spi.component.ProviderServices.getServices(ProviderServices.java:160)
at com.sun.jersey.core.spi.factory.MessageBodyFactory.initReaders(MessageBodyFactory.java:176)
at com.sun.jersey.core.spi.factory.MessageBodyFactory.init(MessageBodyFactory.java:162)
at com.sun.jersey.server.impl.application.WebApplicationImpl._initiate(WebApplicationImpl.java:1277)
at com.sun.jersey.server.impl.application.WebApplicationImpl.access$700(WebApplicationImpl.java:169)
at com.sun.jersey.server.impl.application.WebApplicationImpl$13.f(WebApplicationImpl.java:775)
at com.sun.jersey.server.impl.application.WebApplicationImpl$13.f(WebApplicationImpl.java:771)
at com.sun.jersey.spi.inject.Errors.processWithErrors(Errors.java:193)
at com.sun.jersey.server.impl.application.WebApplicationImpl.initiate(WebApplicationImpl.java:771)
at com.sun.jersey.guice.spi.container.servlet.GuiceContainer.initiate(GuiceContainer.java:121)
at com.sun.jersey.spi.container.servlet.ServletContainer$InternalWebComponent.initiate(ServletContainer.java:318)
at com.sun.jersey.spi.container.servlet.WebComponent.load(WebComponent.java:609)
at com.sun.jersey.spi.container.servlet.WebComponent.init(WebComponent.java:210)
at com.sun.jersey.spi.container.servlet.ServletContainer.init(ServletContainer.java:373)
at com.sun.jersey.spi.container.servlet.ServletContainer.init(ServletContainer.java:710)
at com.google.inject.servlet.FilterDefinition.init(FilterDefinition.java:114)
at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:98)
at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:172)
at org.mortbay.jetty.servlet.FilterHolder.doStart(FilterHolder.java:97)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:713)
at org.mortbay.jetty.servlet.Context.startContext(Context.java:140)
at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1282)
at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:518)
at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:499)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.mortbay.jetty.handler.HandlerCollection.doStart(HandlerCollection.java:152)
at org.mortbay.jetty.handler.ContextHandlerCollection.doStart(ContextHandlerCollection.java:156)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
at org.mortbay.jetty.Server.doStart(Server.java:224)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:877)
at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:306)
at org.apache.hadoop.mapreduce.v2.app.client.MRClientService.serviceStart(MRClientService.java:144)
at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster.serviceStart(MRAppMaster.java:1147)
at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster$5.run(MRAppMaster.java:1552)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1754)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster.initAndStartAppMaster(MRAppMaster.java:1548)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster.main(MRAppMaster.java:1481)
2020-07-17 12:59:35,113 INFO [main] org.mortbay.log: Started HttpServer2$SelectChannelConnectorWithSafeStartup@0.0.0.0:60485
2020-07-17 12:59:35,113 ERROR [main] org.apache.hadoop.mapreduce.v2.app.client.MRClientService: Webapps failed to start. Ignoring for now:
org.apache.hadoop.yarn.webapp.WebAppException: Error starting http server
at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:310)
at org.apache.hadoop.mapreduce.v2.app.client.MRClientService.serviceStart(MRClientService.java:144)
at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster.serviceStart(MRAppMaster.java:1147)
at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster$5.run(MRAppMaster.java:1552)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1754)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster.initAndStartAppMaster(MRAppMaster.java:1548)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster.main(MRAppMaster.java:1481)
Caused by: java.io.IOException: Problem in starting http server. Server handlers failed
at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:889)
at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:306)
... 10 more
```
Maybe this being broken is out of scope for this issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-664790988
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on a change in pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#discussion_r457833584
##########
File path: phoenix-hive3/pom.xml
##########
@@ -0,0 +1,327 @@
+<?xml version='1.0'?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-connectors</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-hive3</artifactId>
+ <name>Phoenix - Hive3</name>
+<properties>
+ <test.tmp.dir>${project.build.directory}/tmp</test.tmp.dir>
+ <netty.version>4.1.47.Final</netty.version>
+ <phoenix.version>5.1.0-SNAPSHOT</phoenix.version>
+ <hbase.version>2.2.1</hbase.version>
Review comment:
But since we'll need to make another pass on the dependencies anyway, 2.2.4 is fine for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] asfgit closed pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on a change in pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#discussion_r456544275
##########
File path: pom.xml
##########
@@ -60,6 +61,8 @@
<test.output.tofile>true</test.output.tofile>
<top.dir>${project.basedir}</top.dir>
+ <jdk.version>1.7</jdk.version>
Review comment:
Do we need to be supporting Java7 for anything? Can we move to 8?
##########
File path: phoenix-hive3/src/it/java/org/apache/phoenix/hive/HiveMapReduceIT.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.hive;
+
+import static org.junit.Assert.fail;
+
+import org.junit.BeforeClass;
+import org.junit.Ignore;
+import org.junit.Test;
+
+public class HiveMapReduceIT extends HivePhoenixStoreIT {
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ final String hadoopConfDir = System.getenv("HADOOP_CONF_DIR");
+ if (hadoopConfDir != null && hadoopConfDir.length() != 0) {
+ fail("HADOOP_CONF_DIR is non-empty in the current shell environment which will very likely cause this test to fail.");
+ }
+ setup(HiveTestUtil.MiniClusterType.mr);
+ }
+
+ @Override
+ @Test
+ @Ignore
+ /**
+ * Ignoring because precicate pushdown is skipped for MR (ref:HIVE-18873) when there are multiple aliases
Review comment:
Looks like this did get resolved, but only for Hive4 :(
##########
File path: phoenix-hive3/pom.xml
##########
@@ -0,0 +1,327 @@
+<?xml version='1.0'?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-connectors</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-hive3</artifactId>
+ <name>Phoenix - Hive3</name>
+<properties>
+ <test.tmp.dir>${project.build.directory}/tmp</test.tmp.dir>
+ <netty.version>4.1.47.Final</netty.version>
+ <phoenix.version>5.1.0-SNAPSHOT</phoenix.version>
+ <hbase.version>2.2.1</hbase.version>
+ <hadoop.version>3.0.0</hadoop.version>
+ <hadoop-two.version>3.0.0</hadoop-two.version>
+ <avatica.version>1.12.0</avatica.version>
+ <hive.version>3.1.2</hive.version>
+ <curator.version>4.0.0</curator.version>
+ <jdk.version>1.8</jdk.version>
+</properties>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-core</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-cli</artifactId>
+ <version>${hive.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-exec</artifactId>
+ <version>${hive.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-metastore</artifactId>
+ <version>${hive.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-standalone-metastore</artifactId>
+ <type>test-jar</type>
+ <version>${hive.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-exec</artifactId>
+ <version>${hive.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <version>${slf4j.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ <version>${slf4j.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ <version>${log4j.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>io.netty</groupId>
+ <artifactId>netty</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <!-- Test dependencies -->
+ <dependency>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-core</artifactId>
+ <classifier>tests</classifier>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-testing-util</artifactId>
+ <scope>test</scope>
+ <optional>true</optional>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-it</artifactId>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-all</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs</artifactId>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-auth</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-common</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-jobclient</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.tez</groupId>
+ <artifactId>tez-tests</artifactId>
+ <scope>test</scope>
+ <version>0.9.1</version>
+ <type>test-jar</type>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-yarn-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.tez</groupId>
+ <artifactId>tez-dag</artifactId>
+ <scope>test</scope>
+ <version>0.9.1</version>
Review comment:
nit: lift this to properties.
##########
File path: phoenix-hive3/pom.xml
##########
@@ -0,0 +1,327 @@
+<?xml version='1.0'?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-connectors</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-hive3</artifactId>
+ <name>Phoenix - Hive3</name>
+<properties>
+ <test.tmp.dir>${project.build.directory}/tmp</test.tmp.dir>
+ <netty.version>4.1.47.Final</netty.version>
+ <phoenix.version>5.1.0-SNAPSHOT</phoenix.version>
+ <hbase.version>2.2.1</hbase.version>
+ <hadoop.version>3.0.0</hadoop.version>
+ <hadoop-two.version>3.0.0</hadoop-two.version>
+ <avatica.version>1.12.0</avatica.version>
+ <hive.version>3.1.2</hive.version>
+ <curator.version>4.0.0</curator.version>
+ <jdk.version>1.8</jdk.version>
+</properties>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-core</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-cli</artifactId>
+ <version>${hive.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-exec</artifactId>
+ <version>${hive.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-metastore</artifactId>
+ <version>${hive.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-standalone-metastore</artifactId>
+ <type>test-jar</type>
+ <version>${hive.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-exec</artifactId>
+ <version>${hive.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <version>${slf4j.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ <version>${slf4j.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ <version>${log4j.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>io.netty</groupId>
+ <artifactId>netty</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <!-- Test dependencies -->
+ <dependency>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-core</artifactId>
+ <classifier>tests</classifier>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-testing-util</artifactId>
+ <scope>test</scope>
+ <optional>true</optional>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-it</artifactId>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-all</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs</artifactId>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-auth</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-common</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-jobclient</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-minicluster</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.tez</groupId>
+ <artifactId>tez-tests</artifactId>
+ <scope>test</scope>
+ <version>0.9.1</version>
+ <type>test-jar</type>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-yarn-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.tez</groupId>
+ <artifactId>tez-dag</artifactId>
+ <scope>test</scope>
+ <version>0.9.1</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-yarn-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-util</artifactId>
+ <scope>test</scope>
+ <version>9.3.8.v20160314</version>
Review comment:
lift jetty.version to properties too, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-661648359
> As I understand it, this is largely just copy-paste'ing from `phoenix-hive` into a `phoenix-hive3`, and then modifying the pom.xml to pull in the correct dependencies. While this approach is effective, I'm worried about the long-term maintenance of supporting multiple versions of Hive via separate copies of code.
>
> Maybe we can stop caring about Hive2 soon and we just drop the `phoenix-hive` module entirely?
The current Apache connector is actually based on Hive 1. I don't think it'd even work with Hive 2. This patch contains significant code changes to support the V3 API instead of the V1 one.
According to @richardantal's research Hive1 and Hive2 is only supported with Hadoop2, while Hive3+ is Hadoop3 only.
This in turn means that 4.x can only hope to support Hive1,2, while 5.x can only support Hive 3+.
Replacing phoenix-hive would mean that we'd drop hive connector support for 4.x completely. I don't know how large the Hive1 installed base is, and whether it'd be even possible for them to use a recent-ish Phoenix on such an old cluster, so it could be a good thing.
While there are significant changes between between the Hive 1 and Hive 2 APIs, the Hive2 and Hive3 APIs seem similar enough that it should be possible to backport this Hive3 connector for Hive2/Phoenix 4.x, and then refactor the Hive3 connector as an extension on top of the new Hive2 connector, though that would either need copying and overwriting the source files, or putting the hive2 and hive3 connectors into different java packages.
However, the Hive 2.x and 3.x connectors would need to live in their own their own Hive version specific sub-projects, so I still think that putting this into a new repo is a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-662162633
Rerunning tests worked this time. Not sure why they failed the first time.
> I think that this needs a thorough review of the dependency handling. We are dependencyManaging some versions that we shouldn't, and there are dependencies and exclusions that I think are not needed.
Do you think we should do this now, @stoty? I am OK to defer dependency cleanup to having a "good" state of this branch with hive3, and then try to make incremental changes to reduce subsequent "dependency cleanup" patches.
You have my +1 if you want to merge this one now, Istvan, but I respect the decision to clean up dependencies right away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-661632023
In general, I think that this needs a thorough review of the dependency handling. We are dependencyManaging some versions that we shouldn't, and there are dependencies and exclusions that I think are not needed.
However, fixing those would be much easier once we have something that we can use as a baseline, so I think that we should first commit this, and re-think the dependencies after.
+1 from me, but please get @joshelser 's approval too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on a change in pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#discussion_r458356709
##########
File path: phoenix-hive3/pom.xml
##########
@@ -0,0 +1,327 @@
+<?xml version='1.0'?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-connectors</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-hive3</artifactId>
+ <name>Phoenix - Hive3</name>
+<properties>
+ <test.tmp.dir>${project.build.directory}/tmp</test.tmp.dir>
+ <netty.version>4.1.47.Final</netty.version>
+ <phoenix.version>5.1.0-SNAPSHOT</phoenix.version>
+ <hbase.version>2.2.1</hbase.version>
Review comment:
2.1.9 or 2.2.4 are fine by me, either way :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] richardantal commented on a change in pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
richardantal commented on a change in pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#discussion_r457223134
##########
File path: pom.xml
##########
@@ -60,6 +61,8 @@
<test.output.tofile>true</test.output.tofile>
<top.dir>${project.basedir}</top.dir>
+ <jdk.version>1.7</jdk.version>
Review comment:
There are significant changes in the java code between phoenix-hive and phoenix-hive, it is not just a copy and pom.xml change.
Hive 3.x supports Hadoop 3 but hive 2 does not, Hive3 is intended to be used with Phoenix 5 meanwhile the old phoenix-hive connector is working with phoenix 4.
This JDK version is in connectors pom.xml, all the modules but the phoenix-hive3 uses jdk 1.7. In phoenix-hive3 it is being overwritten to 1.8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on a change in pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#discussion_r458357916
##########
File path: pom.xml
##########
@@ -60,6 +61,8 @@
<test.output.tofile>true</test.output.tofile>
<top.dir>${project.basedir}</top.dir>
+ <jdk.version>1.7</jdk.version>
Review comment:
Ok, cool. I didn't have an easy way to validate this. Copying is probably easiest! Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-661649695
Maybe pre-emptively move this code to org.apache.phoenix.hive3 package now, so that we don't have to deal with the 2.x vs 3.x conflicts later ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-662271718
> > Maybe pre-emptively move this code to org.apache.phoenix.hive3 package now, so that we don't have to deal with the 2.x vs 3.x conflicts later ?
>
> That's a really smart idea. Hive's classpath gets the entire world, most of the time.
I've slept on (literally), and now I think that that's not the way to, as this package name is exposed to the Hive user-facing API, and having to deal with version specific package names would be an unnecessary inconvenience for the users.
We should just have have something like phoenix-hbase-common, where we make the version-dependent classes abstract, and build the Hive2 and Hive3 connectors on top of it.
This is of course just a plan for the future connector for 4.x, not for the present patch.
> You have my +1 if you want to merge this one now, Istvan, but I respect the decision to clean up dependencies right away.
Thank you. I'd like to get the code in ASAP, and deal with the dependencies and possible shaded JAR later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on a change in pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#discussion_r456573840
##########
File path: phoenix-hive3/pom.xml
##########
@@ -0,0 +1,327 @@
+<?xml version='1.0'?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-connectors</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-hive3</artifactId>
+ <name>Phoenix - Hive3</name>
+<properties>
+ <test.tmp.dir>${project.build.directory}/tmp</test.tmp.dir>
+ <netty.version>4.1.47.Final</netty.version>
+ <phoenix.version>5.1.0-SNAPSHOT</phoenix.version>
+ <hbase.version>2.2.1</hbase.version>
+ <hadoop.version>3.0.0</hadoop.version>
Review comment:
phoenix is at 3.0.3. Should we use that too?
##########
File path: phoenix-hive3/pom.xml
##########
@@ -0,0 +1,327 @@
+<?xml version='1.0'?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-connectors</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-hive3</artifactId>
+ <name>Phoenix - Hive3</name>
+<properties>
+ <test.tmp.dir>${project.build.directory}/tmp</test.tmp.dir>
+ <netty.version>4.1.47.Final</netty.version>
+ <phoenix.version>5.1.0-SNAPSHOT</phoenix.version>
+ <hbase.version>2.2.1</hbase.version>
Review comment:
And 2.2.4 for HBase from Phoenix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on a change in pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#discussion_r456573655
##########
File path: phoenix-hive3/pom.xml
##########
@@ -0,0 +1,327 @@
+<?xml version='1.0'?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-connectors</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-hive3</artifactId>
+ <name>Phoenix - Hive3</name>
+<properties>
+ <test.tmp.dir>${project.build.directory}/tmp</test.tmp.dir>
+ <netty.version>4.1.47.Final</netty.version>
+ <phoenix.version>5.1.0-SNAPSHOT</phoenix.version>
+ <hbase.version>2.2.1</hbase.version>
+ <hadoop.version>3.0.0</hadoop.version>
+ <hadoop-two.version>3.0.0</hadoop-two.version>
Review comment:
unused
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on a change in pull request #21: PHOENIX-5786 Update phoenix-hive to support current hive versions
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#discussion_r457215052
##########
File path: phoenix-hive3/pom.xml
##########
@@ -0,0 +1,327 @@
+<?xml version='1.0'?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-connectors</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-hive3</artifactId>
+ <name>Phoenix - Hive3</name>
+<properties>
+ <test.tmp.dir>${project.build.directory}/tmp</test.tmp.dir>
+ <netty.version>4.1.47.Final</netty.version>
+ <phoenix.version>5.1.0-SNAPSHOT</phoenix.version>
+ <hbase.version>2.2.1</hbase.version>
Review comment:
At the moment Phoenix is set to use 2.2.4 by default, but I think that we should consider changing the default to the 2.1 profile (always the oldest supported), and publish the maven artifacts built with that. (Going to open a ticket for that right away)
For the same reason, building with 2.1.9 instead may be a better solution here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org