You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/08/01 15:08:08 UTC

[GitHub] markusthoemmes commented on a change in pull request #3934: Adjust Kafka's config to not contain any more warnings.

markusthoemmes commented on a change in pull request #3934: Adjust Kafka's config to not contain any more warnings.
URL: https://github.com/apache/incubator-openwhisk/pull/3934#discussion_r206917975
 
 

 ##########
 File path: common/scala/src/main/resources/application.conf
 ##########
 @@ -81,7 +81,9 @@ whisk {
             // A low value improves latency performance but it is important to not set it too low
             // as that will cause excessive busy-waiting.
             fetch-max-wait-ms = 20
-            metric-flush-interval-s = 60
+
+            // Used to control the window size of kafka metric reporting and cadence of consumer lag checking
+            metrics-sample-window-ms = 60000 // 60 seconds
 
 Review comment:
   @sven-lange-last made me aware of the fact that this a really bad idea because of conflating two things. Will update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services