You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2011/11/17 23:33:09 UTC

DO NOT REPLY [Bug 118613] New: IP clearance: Remove KDE Crystal image icons

https://issues.apache.org/ooo/show_bug.cgi?id=118613

             Bug #: 118613
        Issue Type: DEFECT
           Summary: IP clearance: Remove KDE Crystal  image icons
    Classification: Code
           Product: external
           Version: version58
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: blocker
          Priority: P5
         Component: www
        AssignedTo: st@openoffice.org
        ReportedBy: pfg@apache.org
                CC: ooo-issues@incubator.apache.org


The icon theme at:
external_images/ooo_crystal_images-1.tar.gz
was introduced by Issue 60434 and while it is claimed there that this
is "partially JCA covered", the thirdpartylicenses.html file
makes it clear that this si copyleft (LGPL).

I made an attempt to remove this icon set and have us use
Tango for KDE in r1203215 but this resulted breaking the world
in the packimages module:

> dmake:  Error: --
> `../unxmacxi.pro/misc/hicontrast.flag' not found, and can't
> be made
> ERROR: error 65280 occurred while making
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/packimages/pack

It was probably something easy to solve but for now I preferred
to revert it. I will be working on a less invasive patch and
I will post it here for future review.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118613] IP clearance: Remove KDE Crystal image icons

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118613

--- Comment #2 from Pedro Giffuni <pf...@apache.org> 2011-11-24 10:42:10 UTC ---
(In reply to comment #1)
> Hi Pedro,
> 
> how is your work coming along?
> Can I help?

I have been a little busy but I will have a patch for this today.

Thanks!

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118613] IP clearance: Remove KDE Crystal image icons

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118613

--- Comment #3 from Pedro Giffuni <pf...@apache.org> 2011-11-25 03:03:44 UTC ---
Created attachment 77045
  --> https://issues.apache.org/ooo/attachment.cgi?id=77045
Remove crystal icons theme

I found where I failed in my first attempt.

This should work but is still untested so I review it further.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118613] IP clearance: Remove KDE Crystal image icons

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118613

hdu@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
                 CC|                            |hdu@apache.org

--- Comment #5 from hdu@apache.org 2012-01-30 13:37:00 UTC ---
Closing resolved issue.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118613] IP clearance: Remove KDE Crystal image icons

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118613

Andre <af...@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |af@a-w-f.de

--- Comment #1 from Andre <af...@a-w-f.de> 2011-11-24 10:01:37 UTC ---
Hi Pedro,

how is your work coming along?
Can I help?

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118613] IP clearance: Remove KDE Crystal image icons

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118613

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Pedro Giffuni <pf...@apache.org> 2011-11-25 16:10:43 UTC ---
svn commit -m "i118613 - IP clearance: Remove LGPLd KDE Crystal image icons."
Sending        binfilter/bf_svtools/source/config/svt_miscopt.cxx
Sending        binfilter/inc/bf_svtools/imgdef.hxx
Sending        cui/source/options/optgdlg.src
Deleting       external_images
Sending        packimages/pack/makefile.mk
Sending        readlicense_oo/html/THIRDPARTYLICENSEREADME.html
Sending        scp2/source/ooo/file_ooo.scp
Sending        scp2/source/ooo/module_hidden_ooo.scp
Sending        solenv/config/sooo340.ini
Sending        vcl/inc/toolbox.h
Sending        vcl/inc/vcl/settings.hxx
Sending        vcl/source/app/settings.cxx
Sending        vcl/source/window/toolbox2.cxx
Transmitting file data ............
Committed revision 1206244.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118613] IP clearance: Remove KDE Crystal image icons

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118613

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Issue Type|DEFECT                      |TASK
           See Also|                            |https://issues.apache.org/o
                   |                            |oo/show_bug.cgi?id=60434
             Blocks|                            |118566

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.