You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sneha Kanekar <sk...@us.ibm.com> on 2017/12/06 09:05:10 UTC

Review Request 64366: Set ambari.repo. in ambari-server setup script

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64366/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: AMBARI-22592
    https://issues.apache.org/jira/browse/AMBARI-22592


Repository: ambari


Description
-------

The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>


Diffs
-----

  ambari-server/src/main/python/ambari-server.py 188910e 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py f744fa0 
  ambari-server/src/main/python/ambari_server/serverSetup.py af45584 
  ambari-server/src/test/python/TestAmbariServer.py ad4e371 


Diff: https://reviews.apache.org/r/64366/diff/1/


Testing
-------

Tests were successful in ambari-web and ambari-server.


Thanks,

Sneha Kanekar


Re: Review Request 64366: Set ambari.repo. in ambari-server setup script

Posted by Sneha Kanekar <sk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64366/
-----------------------------------------------------------

(Updated Dec. 7, 2017, 8:50 a.m.)


Review request for Ambari and Nate Cole.


Changes
-------

Reuploading the patch as the changes were not getting applied to serverSetup.py


Bugs: AMBARI-22592
    https://issues.apache.org/jira/browse/AMBARI-22592


Repository: ambari


Description
-------

The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>


Diffs (updated)
-----

  ambari-server/src/main/python/ambari-server.py 188910e 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py f744fa0 
  ambari-server/src/main/python/ambari_server/serverSetup.py af45584 
  ambari-server/src/test/python/TestAmbariServer.py ad4e371 


Diff: https://reviews.apache.org/r/64366/diff/2/

Changes: https://reviews.apache.org/r/64366/diff/1-2/


Testing
-------

Tests were successful in ambari-web and ambari-server.


Thanks,

Sneha Kanekar


Re: Review Request 64366: Set ambari.repo. in ambari-server setup script

Posted by Sneha Kanekar <sk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64366/
-----------------------------------------------------------

(Updated Dec. 7, 2017, 5:34 a.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-22592
    https://issues.apache.org/jira/browse/AMBARI-22592


Repository: ambari


Description
-------

The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>


Diffs
-----

  ambari-server/src/main/python/ambari-server.py 188910e 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py f744fa0 
  ambari-server/src/main/python/ambari_server/serverSetup.py af45584 
  ambari-server/src/test/python/TestAmbariServer.py ad4e371 


Diff: https://reviews.apache.org/r/64366/diff/1/


Testing
-------

Tests were successful in ambari-web and ambari-server.


Thanks,

Sneha Kanekar