You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/11 00:05:45 UTC
[GitHub] [tvm] tkonolige opened a new pull request, #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd
tkonolige opened a new pull request, #13755:
URL: https://github.com/apache/tvm/pull/13755
The generic scatter nd was almost identical to the x86 one and was not tested. They now are one and the same.
@AndrewZhaoLuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13755:
URL: https://github.com/apache/tvm/pull/13755#issuecomment-1378058156
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `fix`, `topi` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on a diff in pull request #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on code in PR #13755:
URL: https://github.com/apache/tvm/pull/13755#discussion_r1067342210
##########
python/tvm/topi/scatter.py:
##########
@@ -268,63 +268,58 @@ def scatter_nd(data, indices, updates, mode):
_verify_scatter_nd_inputs(data, indices, updates)
def gen_ir(data_ptr, indices_ptr, updates_ptr, out_ptr):
+ # pylint: disable=invalid-name
Review Comment:
nit: just give it a good name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on a diff in pull request #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on code in PR #13755:
URL: https://github.com/apache/tvm/pull/13755#discussion_r1067398808
##########
python/tvm/topi/scatter.py:
##########
@@ -268,63 +268,58 @@ def scatter_nd(data, indices, updates, mode):
_verify_scatter_nd_inputs(data, indices, updates)
def gen_ir(data_ptr, indices_ptr, updates_ptr, out_ptr):
+ # pylint: disable=invalid-name
Review Comment:
can you fix it while you are here, small change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a diff in pull request #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd
Posted by GitBox <gi...@apache.org>.
tkonolige commented on code in PR #13755:
URL: https://github.com/apache/tvm/pull/13755#discussion_r1067385975
##########
python/tvm/topi/scatter.py:
##########
@@ -268,63 +268,58 @@ def scatter_nd(data, indices, updates, mode):
_verify_scatter_nd_inputs(data, indices, updates)
def gen_ir(data_ptr, indices_ptr, updates_ptr, out_ptr):
+ # pylint: disable=invalid-name
Review Comment:
This is from the old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige merged pull request #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd
Posted by GitBox <gi...@apache.org>.
tkonolige merged PR #13755:
URL: https://github.com/apache/tvm/pull/13755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org