[jira] [Commented] (PHOENIX-1809) Improve explain plan

["Maryann Xue (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396352#comment-14396352 ] 

Maryann Xue commented on PHOENIX-1809:
--------------------------------------

+1 to the patch, [~jamestaylor].

> Improve explain plan
> --------------------
>
>                 Key: PHOENIX-1809
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1809
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>         Attachments: PHOENIX-1809.patch, PHOENIX-1809_v2.patch
>
>
> Two changes:
> 1) We already output the limit information, so it's redundant to display the PageFilter filter. Instead we should skip that filter in ExplainTable when we generate the explain plan - there are about 5 places in the code that need to be changed that expect this in the explain plan.
> 2) Instead of the hacky boolean we pass through MergeSortTopNResultIterator to control the output of the server-side order by/limit, we should output that information in ExplainTable as well. We'd need to pass through the LIMIT information there too. Then the MergeSortTopNResultIterator would only output the CLIENT MERGE SORT step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)